Skip to contentSkip to conversation

block: Replace qdict_put() by qdict_put_obj() where appropriate

PATCH Applied Markus Armbruster 4 participants 4 messages Dec 13, 2018 – Jan 8, 2019 Block layer

lore
Share & tools
lore

Markus Armbruster

author
#0 lore raw

PATCH 1/1 block: Replace qdict_put() by qdict_put_obj() where appropriate

Patch created mechanically by rerunning:

  $  spatch --sp-file scripts/coccinelle/qobject.cocci \
	    --macro-file scripts/cocci-macro-file.h \
	    --dir block --in-place
Signed-off-by Markus Armbruster <[email protected]>
---
 block/blklogwrites.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
block/blklogwrites.c +2 -3
index ff98cd5533..d2e01bdb1d 100644
@@ -295,10 +295,9 @@ static void blk_log_writes_refresh_filename(BlockDriverState *bs,
         qdict_put_str(opts, "driver", "blklogwrites");
 
         qobject_ref(bs->file->bs->full_open_options);
-        qdict_put_obj(opts, "file", QOBJECT(bs->file->bs->full_open_options));
+        qdict_put(opts, "file", bs->file->bs->full_open_options);
         qobject_ref(s->log_file->bs->full_open_options);
-        qdict_put_obj(opts, "log",
-                      QOBJECT(s->log_file->bs->full_open_options));
+        qdict_put(opts, "log", s->log_file->bs->full_open_options);
         qdict_put_int(opts, "log-sector-size", s->sectorsize);
 
         bs->full_open_options = opts;
Signature · 1 line
2.17.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Markus Armbruster

Patch created mechanically by rerunning:

   $  spatch --sp-file scripts/coccinelle/qobject.cocci \
	    --macro-file scripts/cocci-macro-file.h \
	    --dir block --in-place
Signed-off-by Markus Armbruster <[email protected]>
---
  block/blklogwrites.c | 5 ++---
  1 file changed, 2 insertions(+), 3 deletions(-)
Reviewed-by Eric Blake <[email protected]>
Signature · 3 lines
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org