Skip to contentSkip to conversation

package/liquid-dsp: add missing dependency on fftw

PATCH New Thomas Petazzoni 3 participants 7 messages Dec 12, 2018 – Dec 16, 2018

lore
Share & tools
lore

Thomas Petazzoni

author
#0 lore raw

PATCH 1/1 package/liquid-dsp: add missing dependency on fftw

When one of BR2_PACKAGE_FFTW_PRECISION_* is enabled, liquid-dsp links against fftw3f, fftw3 or fftw3l, but forgets to add the fftw package in its dependencies. It works fine in practice because "fftw" is before "liquid-dsp" in the alphabetic ordering, but building with "make liquid-dsp" or with per-package directory causes a build failure.

Fix that by adding the missing dependencies.

Signed-off-by Thomas Petazzoni <[email protected]>
---
 package/liquid-dsp/liquid-dsp.mk | 3 +++
 1 file changed, 3 insertions(+)
package/liquid-dsp/liquid-dsp.mk +3 -0
index e3114a2d15..db67893844 100644
@@ -32,6 +32,7 @@ endif
 # use FFTW instead of built-in FFT
 ifeq ($(BR2_PACKAGE_FFTW_PRECISION_SINGLE),y)
 LIQUID_DSP_LDFLAGS += -lfftw3f
+LIQUID_DSP_DEPENDENCIES += fftw
 endif
 
 # disable altivec, it has build issues

@@ -41,10 +42,12 @@ endif
 
 ifeq ($(BR2_PACKAGE_FFTW_PRECISION_DOUBLE),y)
 LIQUID_DSP_LDFLAGS += -lfftw3
+LIQUID_DSP_DEPENDENCIES += fftw
 endif
 
 ifeq ($(BR2_PACKAGE_FFTW_PRECISION_LONG_DOUBLE),y)
 LIQUID_DSP_LDFLAGS += -lfftw3l
+LIQUID_DSP_DEPENDENCIES += fftw
 endif
 
 LIQUID_DSP_CONF_OPTS += \
Signature · 1 line
2.19.2
#1 lore raw

PATCH 1/1 package/liquid-dsp: add missing dependency on fftw

Thomas,
This issue is also fixed by http://patchwork.ozlabs.org/patch/1011657/

Regards,
Gwen

Quoted 46 lines · On Wed, 12 Dec 2018 10:04:58 +0100 Thomas Petazzoni…

When one of BR2_PACKAGE_FFTW_PRECISION_* is enabled, liquid-dsp links against fftw3f, fftw3 or fftw3l, but forgets to add the fftw package in its dependencies. It works fine in practice because "fftw" is before "liquid-dsp" in the alphabetic ordering, but building with "make liquid-dsp" or with per-package directory causes a build failure.

Fix that by adding the missing dependencies.

Signed-off-by Thomas Petazzoni <[email protected]>
---
 package/liquid-dsp/liquid-dsp.mk | 3 +++
 1 file changed, 3 insertions(+)
(quoted diff) +0 -0

b/package/liquid-dsp/liquid-dsp.mk index e3114a2d15..db67893844 100644

package/liquid-dsp/liquid-dsp.mk +3 -0
@@ -32,6 +32,7 @@ endif
 # use FFTW instead of built-in FFT
 ifeq ($(BR2_PACKAGE_FFTW_PRECISION_SINGLE),y)
 LIQUID_DSP_LDFLAGS += -lfftw3f
+LIQUID_DSP_DEPENDENCIES += fftw
 endif
 
 # disable altivec, it has build issues

@@ -41,10 +42,12 @@ endif
 
 ifeq ($(BR2_PACKAGE_FFTW_PRECISION_DOUBLE),y)
 LIQUID_DSP_LDFLAGS += -lfftw3
+LIQUID_DSP_DEPENDENCIES += fftw
 endif
 
 ifeq ($(BR2_PACKAGE_FFTW_PRECISION_LONG_DOUBLE),y)
 LIQUID_DSP_LDFLAGS += -lfftw3l
+LIQUID_DSP_DEPENDENCIES += fftw
 endif
 
 LIQUID_DSP_CONF_OPTS += \
Signature · 6 lines
2.19.2

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
author
#2 lore raw

PATCH 1/1 package/liquid-dsp: add missing dependency on fftw

Hello,

Quoted 1 line · Gwenhael Goavec-Merou

This issue is also fixed by http://patchwork.ozlabs.org/patch/1011657/

Yes, but I think we want to apply my patch first, because it is the minimal fix that doesn't depend on the FFTW rework. My patch can then be easily backported to the stable branches, because it doesn't depend on the heavier FFTW rework.

And then on top of that, we can of course apply your FFTW rework.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

PATCH 1/1 package/liquid-dsp: add missing dependency on fftw

Quoted 11 lines · On Wed, 12 Dec 2018 10:25:22 +0100 Thomas Petazzoni…

Hello,

Quoted 1 line · Gwenhael Goavec-Merou

This issue is also fixed by http://patchwork.ozlabs.org/patch/1011657/

Yes, but I think we want to apply my patch first, because it is the minimal fix that doesn't depend on the FFTW rework. My patch can then be easily backported to the stable branches, because it doesn't depend on the heavier FFTW rework.

Yes, it's true. And finally with the rework of FFTW and the fact that fftw depends on fftw-xx the only thing that is needed is to change the name of the variables

Quoted 3 lines

And then on top of that, we can of course apply your FFTW rework.

Regards,

Gwen

#4 lore raw

PATCH 1/1 package/liquid-dsp: add missing dependency on fftw

In reply to Thomas Petazzoni
Quoted 10 lines · On Wed, 12 Dec 2018 10:04:58 +0100 Thomas Petazzoni…

When one of BR2_PACKAGE_FFTW_PRECISION_* is enabled, liquid-dsp links against fftw3f, fftw3 or fftw3l, but forgets to add the fftw package in its dependencies. It works fine in practice because "fftw" is before "liquid-dsp" in the alphabetic ordering, but building with "make liquid-dsp" or with per-package directory causes a build failure.

Fix that by adding the missing dependencies.

Signed-off-by Thomas Petazzoni <[email protected]>
Tested-by Gwenhael Goavec-Merou <[email protected]>
Reviewed-by Gwenhael Goavec-Merou <[email protected]>
Quoted 36 lines
---
 package/liquid-dsp/liquid-dsp.mk | 3 +++
 1 file changed, 3 insertions(+)
(quoted diff) +0 -0

b/package/liquid-dsp/liquid-dsp.mk index e3114a2d15..db67893844 100644

package/liquid-dsp/liquid-dsp.mk +3 -0
@@ -32,6 +32,7 @@ endif
 # use FFTW instead of built-in FFT
 ifeq ($(BR2_PACKAGE_FFTW_PRECISION_SINGLE),y)
 LIQUID_DSP_LDFLAGS += -lfftw3f
+LIQUID_DSP_DEPENDENCIES += fftw
 endif
 
 # disable altivec, it has build issues

@@ -41,10 +42,12 @@ endif
 
 ifeq ($(BR2_PACKAGE_FFTW_PRECISION_DOUBLE),y)
 LIQUID_DSP_LDFLAGS += -lfftw3
+LIQUID_DSP_DEPENDENCIES += fftw
 endif
 
 ifeq ($(BR2_PACKAGE_FFTW_PRECISION_LONG_DOUBLE),y)
 LIQUID_DSP_LDFLAGS += -lfftw3l
+LIQUID_DSP_DEPENDENCIES += fftw
 endif
 
 LIQUID_DSP_CONF_OPTS += \
Signature · 6 lines
2.19.2

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
author Applied
#5 lore raw

PATCH 1/1 package/liquid-dsp: add missing dependency on fftw

In reply to Thomas Petazzoni

Hello,

Quoted 7 lines · Thomas Petazzoni

When one of BR2_PACKAGE_FFTW_PRECISION_* is enabled, liquid-dsp links against fftw3f, fftw3 or fftw3l, but forgets to add the fftw package in its dependencies. It works fine in practice because "fftw" is before "liquid-dsp" in the alphabetic ordering, but building with "make liquid-dsp" or with per-package directory causes a build failure.

Quoted 6 lines

Fix that by adding the missing dependencies.

Signed-off-by Thomas Petazzoni <[email protected]>
---
 package/liquid-dsp/liquid-dsp.mk | 3 +++
 1 file changed, 3 insertions(+)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#6 lore raw

PATCH 1/1 package/liquid-dsp: add missing dependency on fftw

In reply to Thomas Petazzoni
Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

When one of BR2_PACKAGE_FFTW_PRECISION_* is enabled, liquid-dsp links against fftw3f, fftw3 or fftw3l, but forgets to add the fftw package in its dependencies. It works fine in practice because "fftw" is before "liquid-dsp" in the alphabetic ordering, but building with "make liquid-dsp" or with per-package directory causes a build failure.

Quoted 3 lines

Fix that by adding the missing dependencies.

Signed-off-by Thomas Petazzoni <[email protected]>

Committed to 2018.02.x, 2018.08.x and 2018.11.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard