Skip to contentSkip to conversation

acsccid: fix build with pkgconf 1.5.3

PATCH New Fabrice Fontaine 2 participants 2 messages Dec 12, 2018 – Dec 13, 2018

lore
Share & tools
lore

Fabrice Fontaine

author
#0 lore raw

PATCH 1/1 acsccid: fix build with pkgconf 1.5.3

Since the bump to 1.5.3, pkgconf prepends the sysroot to all absolute paths found in the .pc file. This is correct when the paths refer to something in STAGING_DIR (e.g. libdir, includedir), but not when it refers to something used for the target.

acsccid uses the usbdropdir variable from libpcsclite.pc to decide where to install things. Since DESTDIR is prepended to the install destination, this will end up in the wrong location.

Until a better solution is found in pkgconf, pass the usbdropdir to use explicitly instead of relying on libpcsclite.pc.

Fixes:
- http://autobuild.buildroot.org/results/9dc76478d81ea2469900a4b4aab0e31fee9c4032

Signed-off-by Fabrice Fontaine <[email protected]>
---
 package/acsccid/acsccid.mk | 1 +
 1 file changed, 1 insertion(+)
package/acsccid/acsccid.mk +1 -0
index 06a04185e2..a59a16d76f 100644
@@ -11,5 +11,6 @@ ACSCCID_LICENSE = LGPL-2.1+
 ACSCCID_LICENSE_FILES = COPYING
 ACSCCID_INSTALL_STAGING = YES
 ACSCCID_DEPENDENCIES = pcsc-lite host-flex host-pkgconf libusb
+ACSCCID_CONF_OPTS = --enable-usbdropdir=/usr/lib/pcsc/drivers
 
 $(eval $(autotools-package))
Signature · 1 line
2.14.1
Applied
#1 lore raw

PATCH 1/1 acsccid: fix build with pkgconf 1.5.3

Hello,

Quoted 12 lines · Fabrice Fontaine

Since the bump to 1.5.3, pkgconf prepends the sysroot to all absolute paths found in the .pc file. This is correct when the paths refer to something in STAGING_DIR (e.g. libdir, includedir), but not when it refers to something used for the target.

acsccid uses the usbdropdir variable from libpcsclite.pc to decide where to install things. Since DESTDIR is prepended to the install destination, this will end up in the wrong location.

Until a better solution is found in pkgconf, pass the usbdropdir to use explicitly instead of relying on libpcsclite.pc.

Quoted 7 lines

Fixes:
- http://autobuild.buildroot.org/results/9dc76478d81ea2469900a4b4aab0e31fee9c4032

Signed-off-by Fabrice Fontaine <[email protected]>
---
 package/acsccid/acsccid.mk | 1 +
 1 file changed, 1 insertion(+)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com