Skip to contentSkip to conversation

libv4l: fix udev build with pkgconf 1.5.3

PATCH New Fabrice Fontaine 2 participants 2 messages Dec 12, 2018 – Dec 13, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libv4l: fix udev build with pkgconf 1.5.3

Since the bump to 1.5.3, pkgconf prepends the sysroot to all absolute paths found in the .pc file. This is correct when the paths refer to something in STAGING_DIR (e.g. libdir, includedir), but not when it refers to something used for the target.

libv4l uses the udevdir variable from libudev.pc to decide where to install things. Since DESTDIR is prepended to the install destination, this will end up in the wrong location.

Until a better solution is found in pkgconf, pass the udevdir to use explicitly instead of relying on libudev.pc.

Fixes:
- http://autobuild.buildroot.org/results/597cd814225c2af9b896a1f25f98cdff33fd810a

---
 package/libv4l/libv4l.mk | 1 +
 1 file changed, 1 insertion(+)
package/libv4l/libv4l.mk +1 -0
index 6b5b7bd2ee..6df69c19f0 100644
@@ -45,6 +45,7 @@ LIBV4L_DEPENDENCIES += libgl
 endif
 
 ifeq ($(BR2_PACKAGE_HAS_UDEV),y)
+LIBV4L_CONF_OPTS += --with-udevdir=/usr/lib/udev
 LIBV4L_DEPENDENCIES += udev
 endif
 
Signature · 1 line
2.14.1
#1 lore raw

PATCH 1/1 libv4l: fix udev build with pkgconf 1.5.3

Hello,

Quoted 12 lines · Fabrice Fontaine

Since the bump to 1.5.3, pkgconf prepends the sysroot to all absolute paths found in the .pc file. This is correct when the paths refer to something in STAGING_DIR (e.g. libdir, includedir), but not when it refers to something used for the target.

libv4l uses the udevdir variable from libudev.pc to decide where to install things. Since DESTDIR is prepended to the install destination, this will end up in the wrong location.

Until a better solution is found in pkgconf, pass the udevdir to use explicitly instead of relying on libudev.pc.

Quoted 7 lines

Fixes:
- http://autobuild.buildroot.org/results/597cd814225c2af9b896a1f25f98cdff33fd810a

---
 package/libv4l/libv4l.mk | 1 +
 1 file changed, 1 insertion(+)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com