Skip to contentSkip to conversation

package/acpid: fix acpid.service permissions

PATCH New james.hilliard1 at gmail.com 3 participants 4 messages Dec 12, 2018 – Dec 13, 2018

lore
Share & tools
lore

james.hilliard1 at gmail.com

author
#0 lore raw

PATCH 1/1 package/acpid: fix acpid.service permissions

From: James Hilliard <[email protected]>

Signed-off-by James Hilliard <[email protected]>
---
 package/acpid/acpid.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/acpid/acpid.mk +1 -1
index 514fd31..adcc175 100644
@@ -11,7 +11,7 @@ ACPID_LICENSE = GPL-2.0+
 ACPID_LICENSE_FILES = COPYING
 
 define ACPID_INSTALL_INIT_SYSTEMD
-	$(INSTALL) -D -m 0755 package/acpid/acpid.service \
+	$(INSTALL) -D -m 0644 package/acpid/acpid.service \
 		$(TARGET_DIR)/usr/lib/systemd/system/acpid.service
 	mkdir -p $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants
 	ln -sf ../../../../usr/lib/systemd/system/acpid.service \
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 package/acpid: fix acpid.service permissions

Hi James,

Quoted 1 line · On 12/12/2018 03:20, james.hilliard1 at gmail.com wrote:

From: James Hilliard <[email protected]>

Could you give a little more detail here? In particular: is it just because
it's not supposed to be executed, or does it in fact give some runtime problems if it is executable? That information is important to decide if the patch should be backported to the stable branches or not.

Regards,
Arnout

Quoted 20 lines
Signed-off-by James Hilliard <[email protected]>
---
 package/acpid/acpid.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/acpid/acpid.mk +1 -1
index 514fd31..adcc175 100644
@@ -11,7 +11,7 @@ ACPID_LICENSE = GPL-2.0+
 ACPID_LICENSE_FILES = COPYING
 
 define ACPID_INSTALL_INIT_SYSTEMD
-	$(INSTALL) -D -m 0755 package/acpid/acpid.service \
+	$(INSTALL) -D -m 0644 package/acpid/acpid.service \
 		$(TARGET_DIR)/usr/lib/systemd/system/acpid.service
 	mkdir -p $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants
 	ln -sf ../../../../usr/lib/systemd/system/acpid.service \
author
#2 lore raw

PATCH 1/1 package/acpid: fix acpid.service permissions

Quoted 10 lines · Arnout Vandecappelle

Hi James,

Quoted 1 line · On 12/12/2018 03:20, james.hilliard1 at gmail.com wrote:

From: James Hilliard <[email protected]>

Could you give a little more detail here? In particular: is it just because
it's not supposed to be executed, or does it in fact give some runtime problems if it is executable? That information is important to decide if the patch should be backported to the stable branches or not.

It causes systemd to throw runtime warnings since systemd service files are essentially a type of configuration file and are not designed to be executed like init scripts. You should probably backport it to get rid of the noise in the logs it causes.

Quoted 24 lines

Regards,
Arnout

Quoted 20 lines
Signed-off-by James Hilliard <[email protected]>
---
 package/acpid/acpid.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/acpid/acpid.mk +1 -1
index 514fd31..adcc175 100644
@@ -11,7 +11,7 @@ ACPID_LICENSE = GPL-2.0+
 ACPID_LICENSE_FILES = COPYING
 
 define ACPID_INSTALL_INIT_SYSTEMD
-     $(INSTALL) -D -m 0755 package/acpid/acpid.service \
+     $(INSTALL) -D -m 0644 package/acpid/acpid.service \
              $(TARGET_DIR)/usr/lib/systemd/system/acpid.service
      mkdir -p $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants
      ln -sf ../../../../usr/lib/systemd/system/acpid.service \
Applied
#3 lore raw

PATCH 1/1 package/acpid: fix acpid.service permissions

In reply to james.hilliard1 at gmail.com

Hello,

Quoted 6 lines · On Wed, 12 Dec 2018 10:20:04 +0800, james.hilliard1 at gmail.com wrote:

From: James Hilliard <[email protected]>

Signed-off-by James Hilliard <[email protected]>
---
 package/acpid/acpid.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master with an extended commit log. Thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com