net: remove duplicate definition of ETHADDR_WILDCARD

PATCH In review Simon Goldschmidt 3 participants 11 messages Nov 22, 2018 – Jan 24, 2019

lore

Share & tools

lore

Simon Goldschmidt

author

2018-11-22 15:58 UTC #0 lore raw

PATCH 1/1 net: remove duplicate definition of ETHADDR_WILDCARD

ETHADDR_WILDCARD is defined as the same value in both env_flags.h and env_callback.h

As env_callback.h includes env_flags.h, remove the duplicate definition from env_callback.h

Signed-off-by Simon Goldschmidt <[email protected]>

---

 include/env_callback.h | 2 --
 1 file changed, 2 deletions(-)

include/env_callback.h +0 -2

index 3c44ff574b..507a52e13c 100644
@@ -32,10 +32,8 @@
 
 #ifdef CONFIG_REGEX
 #define ENV_DOT_ESCAPE "\\"
-#define ETHADDR_WILDCARD "\\d?"
 #else
 #define ENV_DOT_ESCAPE
-#define ETHADDR_WILDCARD
 #endif
 
 #ifdef CONFIG_CMD_DNS

Signature · 1 line

2.17.1

Simon Goldschmidt

author

2018-12-14 08:55 UTC #2 lore raw

PATCH 1/1 net: remove duplicate definition of ETHADDR_WILDCARD

+ Tom

Quoted 28 lines · Simon Goldschmidt

Am 22.11.2018 um 16:58 schrieb Simon Goldschmidt:
Quoted 26 lines
ETHADDR_WILDCARD is defined as the same value in both env_flags.h and env_callback.h
As env_callback.h includes env_flags.h, remove the duplicate definition from env_callback.h
Signed-off-by Simon Goldschmidt <[email protected]>
---
  include/env_callback.h | 2 --
  1 file changed, 2 deletions(-)
include/env_callback.h +0 -2
index 3c44ff574b..507a52e13c 100644
@@ -32,10 +32,8 @@
 
  #ifdef CONFIG_REGEX
  #define ENV_DOT_ESCAPE "\\"
-#define ETHADDR_WILDCARD "\\d?"
  #else
  #define ENV_DOT_ESCAPE
-#define ETHADDR_WILDCARD
  #endif
 

Quoted 4 lines

include/env_callback.h line 39
Quoted 2 lines
include/env_callback.h +0 -0
  #ifdef CONFIG_CMD_DNS
Ping?

I haven't gotten an answer to this for nearly one month. It's a small change, can this go in for v2019.01 please?

Regards,
Simon

Tom Rini

2018-12-14 13:28 UTC #3 lore raw

PATCH 1/1 net: remove duplicate definition of ETHADDR_WILDCARD

Quoted 33 lines · Simon Goldschmidt

+ Tom
Quoted 28 lines · Simon Goldschmidt
Am 22.11.2018 um 16:58 schrieb Simon Goldschmidt:
Quoted 26 lines
ETHADDR_WILDCARD is defined as the same value in both env_flags.h and env_callback.h
As env_callback.h includes env_flags.h, remove the duplicate definition from env_callback.h
Signed-off-by Simon Goldschmidt <[email protected]>
---
  include/env_callback.h | 2 --
  1 file changed, 2 deletions(-)
include/env_callback.h +0 -2
index 3c44ff574b..507a52e13c 100644
@@ -32,10 +32,8 @@
 
  #ifdef CONFIG_REGEX
  #define ENV_DOT_ESCAPE "\\"
-#define ETHADDR_WILDCARD "\\d?"
  #else
  #define ENV_DOT_ESCAPE
-#define ETHADDR_WILDCARD
  #endif
 

Quoted 7 lines

Quoted 4 lines
include/env_callback.h line 39
Quoted 2 lines
include/env_callback.h +0 -0
  #ifdef CONFIG_CMD_DNS
Ping?
I haven't gotten an answer to this for nearly one month. It's a small change, can this go in for v2019.01 please?

I'd filed this off to Joe to grab since it is indeed small and a clean-up.

Signature · 8 lines

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181214/4340128a/attachment.sig>

Simon Goldschmidt

author

2018-12-14 13:43 UTC #4 lore raw

PATCH 1/1 net: remove duplicate definition of ETHADDR_WILDCARD

Quoted 40 lines · Tom Rini

Quoted 38 lines · Simon Goldschmidt
+ Tom
Quoted 32 lines · Simon Goldschmidt
Am 22.11.2018 um 16:58 schrieb Simon Goldschmidt:
Quoted 18 lines
ETHADDR_WILDCARD is defined as the same value in both env_flags.h and env_callback.h
As env_callback.h includes env_flags.h, remove the duplicate definition from env_callback.h
Signed-off-by Simon Goldschmidt <[email protected]>
---
  include/env_callback.h | 2 --
  1 file changed, 2 deletions(-)
include/env_callback.h +0 -0
index 3c44ff574b..507a52e13c 100644
include/env_callback.h line 39
Quoted 10 lines
include/env_callback.h +0 -2
@@ -32,10 +32,8 @@
 
  #ifdef CONFIG_REGEX
  #define ENV_DOT_ESCAPE "\\"
-#define ETHADDR_WILDCARD "\\d?"
  #else
  #define ENV_DOT_ESCAPE
-#define ETHADDR_WILDCARD
  #endif
 
  #ifdef CONFIG_CMD_DNS
Ping?

Quoted 5 lines

Quoted 2 lines
I haven't gotten an answer to this for nearly one month. It's a small change, can this go in for v2019.01 please?
I'd filed this off to Joe to grab since it is indeed small and a clean-up.

Well, I haven't heard from Joe since about one months now, that's why I added you...

Regards,
Simon

Simon Goldschmidt

author

2019-01-14 15:42 UTC #5 lore raw

PATCH 1/1 net: remove duplicate definition of ETHADDR_WILDCARD

Joe,

Am 14.12.2018 um 14:43 schrieb Simon Goldschmidt:

Quoted 41 lines · Tom Rini

Quoted 40 lines · Simon Goldschmidt
Quoted 38 lines
+ Tom
Quoted 32 lines · Simon Goldschmidt
Am 22.11.2018 um 16:58 schrieb Simon Goldschmidt:
Quoted 18 lines
ETHADDR_WILDCARD is defined as the same value in both env_flags.h and env_callback.h
As env_callback.h includes env_flags.h, remove the duplicate definition from env_callback.h
Signed-off-by Simon Goldschmidt <[email protected]>
---
   include/env_callback.h | 2 --
   1 file changed, 2 deletions(-)
include/env_callback.h +0 -0
index 3c44ff574b..507a52e13c 100644
include/env_callback.h line 39
Quoted 10 lines
include/env_callback.h +0 -2
@@ -32,10 +32,8 @@
 
   #ifdef CONFIG_REGEX
   #define ENV_DOT_ESCAPE "\\"
-#define ETHADDR_WILDCARD "\\d?"
   #else
   #define ENV_DOT_ESCAPE
-#define ETHADDR_WILDCARD
   #endif
 
   #ifdef CONFIG_CMD_DNS
Ping?

Quoted 8 lines

Quoted 5 lines
Quoted 2 lines
I haven't gotten an answer to this for nearly one month. It's a small change, can this go in for v2019.01 please?
I'd filed this off to Joe to grab since it is indeed small and a clean-up.
Well, I haven't heard from Joe since about one months now, that's why I added you...

Will you be taking this after the release or is there anything missing? It's assigned to you in patchwork but I didn't get any real reply...

Regards,
Simon

Joe Hershberger

2019-01-15 08:59 UTC #6 lore raw

PATCH 1/1 net: remove duplicate definition of ETHADDR_WILDCARD

In reply to Simon Goldschmidt

Quoted 8 lines · Simon Goldschmidt

ETHADDR_WILDCARD is defined as the same value in both env_flags.h and env_callback.h
As env_callback.h includes env_flags.h, remove the duplicate definition from env_callback.h
Signed-off-by Simon Goldschmidt <[email protected]>

Acked-by Joe Hershberger <[email protected]>

Simon Goldschmidt

author

2019-01-22 07:25 UTC #7 lore raw

PATCH 1/1 net: remove duplicate definition of ETHADDR_WILDCARD

Hi Joe,

Quoted 7 lines · Joe Hershberger

Quoted 4 lines · Simon Goldschmidt
ETHADDR_WILDCARD is defined as the same value in both env_flags.h and env_callback.h

Quoted 6 lines

Quoted 4 lines
As env_callback.h includes env_flags.h, remove the duplicate definition from env_callback.h
Signed-off-by Simon Goldschmidt <[email protected]>
Acked-by Joe Hershberger <[email protected]>

I don't want to be annoying, but could you tell me when this patch (and the other
3 I have pending in patchwork that are assigned to you) will make it into the main
repository? Or if there's anything preventing that? I sent them mid of November...

Thanks,
Simon

Joe Hershberger

2019-01-22 17:31 UTC #8 lore raw

PATCH 1/1 net: remove duplicate definition of ETHADDR_WILDCARD

Quoted 16 lines · Simon Goldschmidt

Hi Joe,
Quoted 12 lines · Joe Hershberger
Quoted 8 lines · Simon Goldschmidt
ETHADDR_WILDCARD is defined as the same value in both env_flags.h and env_callback.h
As env_callback.h includes env_flags.h, remove the duplicate definition from env_callback.h
Signed-off-by Simon Goldschmidt <[email protected]>

Quoted 8 lines

Quoted 1 line
Acked-by Joe Hershberger <[email protected]>
I don't want to be annoying, but could you tell me when this patch (and the other
3 I have pending in patchwork that are assigned to you) will make it into the main
repository? Or if there's anything preventing that? I sent them mid of November...

Sorry for the delay. I'll be build testing everything this week and if all goes smoothly, I'll send a PR then.

Cheers,
-Joe

Simon Goldschmidt

author

2019-01-22 19:03 UTC #9 lore raw

PATCH 1/1 net: remove duplicate definition of ETHADDR_WILDCARD

Am 22.01.2019 um 18:31 schrieb Joe Hershberger:

Quoted 27 lines

Quoted 16 lines · Simon Goldschmidt
Hi Joe,
Quoted 12 lines · Joe Hershberger
Quoted 8 lines · Simon Goldschmidt
ETHADDR_WILDCARD is defined as the same value in both env_flags.h and env_callback.h
As env_callback.h includes env_flags.h, remove the duplicate definition from env_callback.h
Signed-off-by Simon Goldschmidt <[email protected]>
Quoted 8 lines
Quoted 1 line
Acked-by Joe Hershberger <[email protected]>
I don't want to be annoying, but could you tell me when this patch (and the other
3 I have pending in patchwork that are assigned to you) will make it into the main
repository? Or if there's anything preventing that? I sent them mid of November...

Quoted 2 lines

Sorry for the delay. I'll be build testing everything this week and if all goes smoothly, I'll send a PR then.

OK, thanks!

Regards,
Simon

Joe Hershberger

2019-01-24 17:38 UTC #10 lore raw

In reply to Simon Goldschmidt

Hi Simon,

https://patchwork.ozlabs.org/patch/1001862/ was applied to http://git.denx.de/?p=u-boot/u-boot-net.git

Thanks!
-Joe