net: fix env flags for eth10addr and above

PATCH In review Simon Goldschmidt 3 participants 10 messages Nov 22, 2018 – Jan 24, 2019

Share & tools

Simon Goldschmidt

author

2018-11-22 16:06 UTC #0 lore raw

PATCH 1/1 net: fix env flags for eth10addr and above

With CONFIG_REGEX enabled, ETHADDR_WILDCARD is set up for up to 10 interfaces (0..9) as the number can only have one digit.

On boards with more than 10 interfaces, this leads to the protection and format checks being absent for eth10addr and above.

Fix this by changing ETHADDR_WILDCARD from "\\d?" to "\\d*" to allow more than one digit.

Signed-off-by Simon Goldschmidt <[email protected]>

---

 include/env_flags.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

include/env_flags.h +1 -1

index cc2c34f939..23744e395c 100644
@@ -38,7 +38,7 @@ enum env_flags_varaccess {
 
 #ifdef CONFIG_CMD_NET
 #ifdef CONFIG_REGEX
-#define ETHADDR_WILDCARD "\\d?"
+#define ETHADDR_WILDCARD "\\d*"
 #else
 #define ETHADDR_WILDCARD
 #endif

Signature · 1 line

2.17.1

Simon Goldschmidt

author

2018-12-09 20:51 UTC #1 lore raw

PATCH 1/1 net: fix env flags for eth10addr and above

Am 22.11.2018 um 17:06 schrieb Simon Goldschmidt:

Quoted 21 lines

With CONFIG_REGEX enabled, ETHADDR_WILDCARD is set up for up to 10 interfaces (0..9) as the number can only have one digit.
On boards with more than 10 interfaces, this leads to the protection and format checks being absent for eth10addr and above.
Fix this by changing ETHADDR_WILDCARD from "\\d?" to "\\d*" to allow more than one digit.
Signed-off-by Simon Goldschmidt <[email protected]>
---
  include/env_flags.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
include/env_flags.h +0 -0
index cc2c34f939..23744e395c 100644

include/env_flags.h enum env_flags_varaccess { · line 44

Quoted 8 lines

include/env_flags.h +1 -1

@@ -38,7 +38,7 @@ enum env_flags_varaccess {
 
  #ifdef CONFIG_CMD_NET
  #ifdef CONFIG_REGEX
-#define ETHADDR_WILDCARD "\\d?"
+#define ETHADDR_WILDCARD "\\d*"
  #else
  #define ETHADDR_WILDCARD
  #endif

Ping?

Simon Goldschmidt

author

2018-12-14 08:56 UTC #2 lore raw

PATCH 1/1 net: fix env flags for eth10addr and above

+Tom

Quoted 23 lines · Simon Goldschmidt

Am 22.11.2018 um 17:06 schrieb Simon Goldschmidt:
Quoted 21 lines
With CONFIG_REGEX enabled, ETHADDR_WILDCARD is set up for up to 10 interfaces (0..9) as the number can only have one digit.
On boards with more than 10 interfaces, this leads to the protection and format checks being absent for eth10addr and above.
Fix this by changing ETHADDR_WILDCARD from "\\d?" to "\\d*" to allow more than one digit.
Signed-off-by Simon Goldschmidt <[email protected]>
---
  include/env_flags.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
include/env_flags.h +0 -0
index cc2c34f939..23744e395c 100644
@@ -38,7 +38,7 @@ enum env_flags_varaccess {
 

Quoted 10 lines

include/env_flags.h enum env_flags_varaccess { · line 44
Quoted 8 lines
include/env_flags.h +1 -1
  #ifdef CONFIG_CMD_NET
  #ifdef CONFIG_REGEX
-#define ETHADDR_WILDCARD "\\d?"
+#define ETHADDR_WILDCARD "\\d*"
  #else
  #define ETHADDR_WILDCARD
  #endif
Ping?

I haven't gotten an answer to this for nearly one month. It's a small change, can this go in for v2019.01 please?

Regards,
Simon

Tom Rini

2018-12-14 13:28 UTC #3 lore raw

PATCH 1/1 net: fix env flags for eth10addr and above

Quoted 38 lines · Simon Goldschmidt

+Tom
Quoted 23 lines · Simon Goldschmidt
Am 22.11.2018 um 17:06 schrieb Simon Goldschmidt:
Quoted 21 lines
With CONFIG_REGEX enabled, ETHADDR_WILDCARD is set up for up to 10 interfaces (0..9) as the number can only have one digit.
On boards with more than 10 interfaces, this leads to the protection and format checks being absent for eth10addr and above.
Fix this by changing ETHADDR_WILDCARD from "\\d?" to "\\d*" to allow more than one digit.
Signed-off-by Simon Goldschmidt <[email protected]>
---
  include/env_flags.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
include/env_flags.h +0 -0
index cc2c34f939..23744e395c 100644
@@ -38,7 +38,7 @@ enum env_flags_varaccess {
 
Quoted 10 lines
include/env_flags.h enum env_flags_varaccess { · line 44
Quoted 8 lines
include/env_flags.h +1 -1
  #ifdef CONFIG_CMD_NET
  #ifdef CONFIG_REGEX
-#define ETHADDR_WILDCARD "\\d?"
+#define ETHADDR_WILDCARD "\\d*"
  #else
  #define ETHADDR_WILDCARD
  #endif
Ping?

Quoted 2 lines

I haven't gotten an answer to this for nearly one month. It's a small change, can this go in for v2019.01 please?

I'd filed this off to Joe to grab since it is indeed small and a clean-up.

Signature · 8 lines

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181214/6ed861af/attachment.sig>

Simon Goldschmidt

author

2019-01-14 15:42 UTC #4 lore raw

PATCH 1/1 net: fix env flags for eth10addr and above

Am 14.12.2018 um 14:28 schrieb Tom Rini:

Quoted 40 lines · Simon Goldschmidt

Quoted 39 lines
+Tom
Quoted 33 lines · Simon Goldschmidt
Am 22.11.2018 um 17:06 schrieb Simon Goldschmidt:
Quoted 21 lines
With CONFIG_REGEX enabled, ETHADDR_WILDCARD is set up for up to 10 interfaces (0..9) as the number can only have one digit.
On boards with more than 10 interfaces, this leads to the protection and format checks being absent for eth10addr and above.
Fix this by changing ETHADDR_WILDCARD from "\\d?" to "\\d*" to allow more than one digit.
Signed-off-by Simon Goldschmidt <[email protected]>
---
   include/env_flags.h | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
include/env_flags.h +0 -0
index cc2c34f939..23744e395c 100644
include/env_flags.h enum env_flags_varaccess { · line 44
Quoted 8 lines
include/env_flags.h +1 -1
@@ -38,7 +38,7 @@ enum env_flags_varaccess {
 
   #ifdef CONFIG_CMD_NET
   #ifdef CONFIG_REGEX
-#define ETHADDR_WILDCARD "\\d?"
+#define ETHADDR_WILDCARD "\\d*"
   #else
   #define ETHADDR_WILDCARD
   #endif
Ping?

Quoted 5 lines

Quoted 2 lines
I haven't gotten an answer to this for nearly one month. It's a small change, can this go in for v2019.01 please?
I'd filed this off to Joe to grab since it is indeed small and a clean-up.

Will you be taking this after the release or is there anything missing? It's assigned to you in patchwork but I didn't get any real reply...

Regards,
Simon

Tom Rini

2019-01-14 16:28 UTC #5 lore raw

PATCH 1/1 net: fix env flags for eth10addr and above

Quoted 41 lines · Simon Goldschmidt

Am 14.12.2018 um 14:28 schrieb Tom Rini:
Quoted 40 lines · Simon Goldschmidt
Quoted 39 lines
+Tom
Quoted 33 lines · Simon Goldschmidt
Am 22.11.2018 um 17:06 schrieb Simon Goldschmidt:
Quoted 21 lines
With CONFIG_REGEX enabled, ETHADDR_WILDCARD is set up for up to 10 interfaces (0..9) as the number can only have one digit.
On boards with more than 10 interfaces, this leads to the protection and format checks being absent for eth10addr and above.
Fix this by changing ETHADDR_WILDCARD from "\\d?" to "\\d*" to allow more than one digit.
Signed-off-by Simon Goldschmidt <[email protected]>
---
  include/env_flags.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
include/env_flags.h +0 -0
index cc2c34f939..23744e395c 100644
include/env_flags.h enum env_flags_varaccess { · line 44
Quoted 8 lines
include/env_flags.h +1 -1
@@ -38,7 +38,7 @@ enum env_flags_varaccess {
 
  #ifdef CONFIG_CMD_NET
  #ifdef CONFIG_REGEX
-#define ETHADDR_WILDCARD "\\d?"
+#define ETHADDR_WILDCARD "\\d*"
  #else
  #define ETHADDR_WILDCARD
  #endif
Ping?

Quoted 8 lines

Quoted 5 lines
Quoted 2 lines
I haven't gotten an answer to this for nearly one month. It's a small change, can this go in for v2019.01 please?
I'd filed this off to Joe to grab since it is indeed small and a clean-up.
Will you be taking this after the release or is there anything missing? It's assigned to you in patchwork but I didn't get any real reply...

Yes, I'll be picking it up then, thanks for your patience.

Signature · 8 lines

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190114/165c928e/attachment.sig>

Joe Hershberger

2019-01-14 18:19 UTC #6 lore raw

PATCH 1/1 net: fix env flags for eth10addr and above

Hi Simon,

Quoted 43 lines · Tom Rini

Quoted 41 lines · Simon Goldschmidt
Am 14.12.2018 um 14:28 schrieb Tom Rini:
Quoted 40 lines · Simon Goldschmidt
Quoted 39 lines
+Tom
Quoted 33 lines · Simon Goldschmidt
Am 22.11.2018 um 17:06 schrieb Simon Goldschmidt:
Quoted 21 lines
With CONFIG_REGEX enabled, ETHADDR_WILDCARD is set up for up to 10 interfaces (0..9) as the number can only have one digit.
On boards with more than 10 interfaces, this leads to the protection and format checks being absent for eth10addr and above.
Fix this by changing ETHADDR_WILDCARD from "\\d?" to "\\d*" to allow more than one digit.
Signed-off-by Simon Goldschmidt <[email protected]>
---
  include/env_flags.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
include/env_flags.h +0 -0
index cc2c34f939..23744e395c 100644
include/env_flags.h enum env_flags_varaccess { · line 44
Quoted 8 lines
include/env_flags.h +1 -1
@@ -38,7 +38,7 @@ enum env_flags_varaccess {
 
  #ifdef CONFIG_CMD_NET
  #ifdef CONFIG_REGEX
-#define ETHADDR_WILDCARD "\\d?"
+#define ETHADDR_WILDCARD "\\d*"
  #else
  #define ETHADDR_WILDCARD
  #endif
Ping?

Quoted 5 lines

Quoted 5 lines
Quoted 5 lines
Quoted 2 lines
I haven't gotten an answer to this for nearly one month. It's a small change, can this go in for v2019.01 please?
I'd filed this off to Joe to grab since it is indeed small and a clean-up.

Apologies for the dead air... I was out for about a month and then the holidays hit. I've been trying to catch up on things that languished in that time and missed this one.

-Joe

Quoted 12 lines

Quoted 3 lines
Will you be taking this after the release or is there anything missing? It's assigned to you in patchwork but I didn't get any real reply...
Yes, I'll be picking it up then, thanks for your patience.
--
Tom
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot

Simon Goldschmidt

author

2019-01-14 18:23 UTC #7 lore raw

PATCH 1/1 net: fix env flags for eth10addr and above

Hi Joe,

Am 14.01.2019 um 19:19 schrieb Joe Hershberger:

Quoted 49 lines

Hi Simon,
Quoted 46 lines · Tom Rini
Quoted 44 lines · Simon Goldschmidt
Am 14.12.2018 um 14:28 schrieb Tom Rini:
Quoted 43 lines · Simon Goldschmidt
Quoted 41 lines
+Tom
Quoted 23 lines · Simon Goldschmidt
Am 22.11.2018 um 17:06 schrieb Simon Goldschmidt:
Quoted 21 lines
With CONFIG_REGEX enabled, ETHADDR_WILDCARD is set up for up to 10 interfaces (0..9) as the number can only have one digit.
On boards with more than 10 interfaces, this leads to the protection and format checks being absent for eth10addr and above.
Fix this by changing ETHADDR_WILDCARD from "\\d?" to "\\d*" to allow more than one digit.
Signed-off-by Simon Goldschmidt <[email protected]>
---
   include/env_flags.h | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
include/env_flags.h +0 -0
index cc2c34f939..23744e395c 100644
@@ -38,7 +38,7 @@ enum env_flags_varaccess {
 
Quoted 10 lines
include/env_flags.h enum env_flags_varaccess { · line 44
Quoted 8 lines
include/env_flags.h +1 -1
   #ifdef CONFIG_CMD_NET
   #ifdef CONFIG_REGEX
-#define ETHADDR_WILDCARD "\\d?"
+#define ETHADDR_WILDCARD "\\d*"
   #else
   #define ETHADDR_WILDCARD
   #endif
Ping?
I haven't gotten an answer to this for nearly one month. It's a small change, can this go in for v2019.01 please?

Quoted 6 lines

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
I'd filed this off to Joe to grab since it is indeed small and a clean-up.
Apologies for the dead air... I was out for about a month and then the holidays hit. I've been trying to catch up on things that languished in that time and missed this one.

I thought of something like that, given the time in the year :-)

Note that I sent 4 patches for net that are presumably in your area to pick up. This one and:

https://patchwork.ozlabs.org/patch/1001862/
https://patchwork.ozlabs.org/patch/999267/
https://patchwork.ozlabs.org/patch/999268/

Thanks,
Simon

Quoted 14 lines

-Joe
Quoted 12 lines
Quoted 3 lines
Will you be taking this after the release or is there anything missing? It's assigned to you in patchwork but I didn't get any real reply...
Yes, I'll be picking it up then, thanks for your patience.
--
Tom
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot

Joe Hershberger

2019-01-15 08:58 UTC #8 lore raw

PATCH 1/1 net: fix env flags for eth10addr and above

In reply to Simon Goldschmidt

Quoted 11 lines · Simon Goldschmidt

With CONFIG_REGEX enabled, ETHADDR_WILDCARD is set up for up to 10 interfaces (0..9) as the number can only have one digit.
On boards with more than 10 interfaces, this leads to the protection and format checks being absent for eth10addr and above.
Fix this by changing ETHADDR_WILDCARD from "\\d?" to "\\d*" to allow more than one digit.
Signed-off-by Simon Goldschmidt <[email protected]>

Acked-by Joe Hershberger <[email protected]>

Joe Hershberger

2019-01-24 17:38 UTC #9 lore raw

In reply to Simon Goldschmidt

Hi Simon,

https://patchwork.ozlabs.org/patch/1001866/ was applied to http://git.denx.de/?p=u-boot/u-boot-net.git

Thanks!
-Joe