Skip to contentSkip to conversation

net/failsafe: remove unnecessary debug messages

PATCH Applied Stephen Hemminger 2 participants 3 messages Dec 14, 2018 – Dec 20, 2018 Network drivers

lore
Share & tools
lore

Stephen Hemminger

author
#0 lore raw

PATCH 1/1 net/failsafe: remove unnecessary debug messages

The failsafe driver spews messages every time it is polling making debugging other things more difficult. Just remove it.

Example:
net_failsafe: Hot-plug mutex was locked by thread 140182066431744 by the hot-plug alarm
net_failsafe: Hot-plug mutex was locked by thread 140182066431744 by the hot-plug alarm
...

Signed-off-by Stephen Hemminger <[email protected]>
---
 drivers/net/failsafe/failsafe_private.h | 8 --------
 1 file changed, 8 deletions(-)
drivers/net/failsafe/failsafe_private.h +0 -8
index 7e3189685901..0dfea65c2a3c 100644
@@ -399,9 +399,6 @@ fs_lock(struct rte_eth_dev *dev, unsigned int is_alarm)
 			return ret;
 		}
 	}
-	DEBUG("Hot-plug mutex was locked by thread %" FS_THREADID_FMT "%s",
-	      (FS_THREADID_TYPE)pthread_self(),
-	      PRIV(dev)->alarm_lock ? " by the hot-plug alarm" : "");
 	return ret;
 }
 

@@ -413,7 +410,6 @@ static inline void
 fs_unlock(struct rte_eth_dev *dev, unsigned int is_alarm)
 {
 	int ret;
-	unsigned int prev_alarm_lock = PRIV(dev)->alarm_lock;
 
 	if (is_alarm) {
 		RTE_ASSERT(PRIV(dev)->alarm_lock == 1);

@@ -422,10 +418,6 @@ fs_unlock(struct rte_eth_dev *dev, unsigned int is_alarm)
 	ret = pthread_mutex_unlock(&PRIV(dev)->hotplug_mutex);
 	if (ret)
 		ERROR("Cannot unlock hot-plug mutex(%s)", strerror(ret));
-	else
-		DEBUG("Hot-plug mutex was unlocked by thread %" FS_THREADID_FMT "%s",
-		      (FS_THREADID_TYPE)pthread_self(),
-		      prev_alarm_lock ? " by the hot-plug alarm" : "");
 }
 
 /*
Signature · 1 line
2.19.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Stephen Hemminger

The failsafe driver spews messages every time it is polling making debugging other things more difficult. Just remove it.

Example:
net_failsafe: Hot-plug mutex was locked by thread 140182066431744 by the hot-plug alarm
net_failsafe: Hot-plug mutex was locked by thread 140182066431744 by the hot-plug alarm
...

Signed-off-by Stephen Hemminger <[email protected]>
Reviewed-by Ferruh Yigit <[email protected]>
Applied
#2 lore raw
Quoted 10 lines · Ferruh Yigit
Quoted 9 lines · Stephen Hemminger

The failsafe driver spews messages every time it is polling making debugging other things more difficult. Just remove it.

Example:
net_failsafe: Hot-plug mutex was locked by thread 140182066431744 by the hot-plug alarm
net_failsafe: Hot-plug mutex was locked by thread 140182066431744 by the hot-plug alarm
...

Quoted 4 lines
Quoted 1 line
Signed-off-by Stephen Hemminger <[email protected]>
Reviewed-by Ferruh Yigit <[email protected]>

Applied to dpdk-next-net/master, thanks.