package/vsomeip: new package

PATCH New Brenke 2 participants 3 messages Dec 12, 2018 – Jan 2, 2019 1 message not in the archive

lore

Share & tools

lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Brenke

2018-12-12 07:53 UTC #1 lore raw

PATCH 1/1 package/vsomeip: new package

From: Maik Brenke <[email protected]>

Signed-off-by Maik Brenke <[email protected]>

---
 DEVELOPERS                   |  3 +++
 package/Config.in            |  1 +
 package/vsomeip/Config.in    | 22 ++++++++++++++++++++++
 package/vsomeip/vsomeip.hash |  5 +++++
 package/vsomeip/vsomeip.mk   | 13 +++++++++++++
 5 files changed, 44 insertions(+)
 create mode 100644 package/vsomeip/Config.in
 create mode 100644 package/vsomeip/vsomeip.hash
 create mode 100644 package/vsomeip/vsomeip.mk

DEVELOPERS +3 -0

index 8d5ed19..54a0331 100644
@@ -1258,6 +1258,9 @@ F:        package/mpv/
 F:      package/rpi-firmware/
 F:      package/rpi-userland/
 
+N:     Maik Brenke, <[email protected]>
+F:     package/vsomeip/
+
 N:      Mamatha Inamdar <[email protected]>
 F:      package/nvme/

package/Config.in +1 -0

index 712e360..7ebb739 100644
@@ -1582,6 +1582,7 @@ menu "Networking"
         source "package/sofia-sip/Config.in"
         source "package/thrift/Config.in"
         source "package/usbredir/Config.in"
+       source "package/vsomeip/Config.in"
         source "package/wampcc/Config.in"
         source "package/zeromq/Config.in"
         source "package/zmqpp/Config.in"

package/vsomeip/Config.in new file +22 -0

new file mode 100644
index 0000000..7244c26
@@ -0,0 +1,22 @@
+config BR2_PACKAGE_VSOMEIP
+       bool "vsomeip"
+       depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
+       depends on BR2_INSTALL_LIBSTDCPP
+       depends on BR2_TOOLCHAIN_HAS_THREADS # boost
+       depends on BR2_PACKAGE_BOOST_ARCH_SUPPORTS
+       select BR2_PACKAGE_BOOST
+       select BR2_PACKAGE_BOOST_SYSTEM
+       select BR2_PACKAGE_BOOST_THREAD
+       select BR2_PACKAGE_BOOST_LOG
+       help
+         The vsomeip stack implements the Scalable service-Oriented
+         MiddlewarE over IP (SOME/IP)) protocol (http://some-ip.com/).
+         The stack consists out of:
+          * a shared library for SOME/IP (`libvsomeip.so`)
+          * a second shared library for SOME/IP's service discovery
+            (`libvsomeip-sd.so`) which is loaded during runtime if
+            the service discovery is enabled.
+         https://github.com/GENIVI/vsomeip
+comment "vsomeip needs a toolchain w/ C++, threads, gcc >= 4.8"
+       depends on BR2_PACKAGE_BOOST_ARCH_SUPPORTS
+       depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8

package/vsomeip/vsomeip.hash new file +5 -0

new file mode 100644
index 0000000..c872c72
@@ -0,0 +1,5 @@
+# Copied from https://github.com/GENIVI/vsomeip/
+md5    72c81358a15eb32e28b6249efda0635e        vsomeip-2.10.21.tar.gz
+sha256 c0ce3a3cf135f5c1538f7a33f98a2d6febfdfe7dcba3f42fdb7bb20d5fd1d4e3        vsomeip-2.10.21.tar.gz
+# License files, locally calculated
+sha256 fab3dd6bdab226f1c08630b1dd917e11fcb4ec5e1e020e2c16f83a0a13863e85        LICENSE

package/vsomeip/vsomeip.mk new file +13 -0

new file mode 100644
index 0000000..aebf707
@@ -0,0 +1,13 @@
+################################################################################
+#
+# vsomeip
+#
+################################################################################
+VSOMEIP_VERSION = 2.10.21
+VSOMEIP_SITE = $(call github,GENIVI,vsomeip,$(VSOMEIP_VERSION))
+VSOMEIP_LICENSE = MPL-2.0
+VSOMEIP_LICENSE_FILES = LICENSE
+
+VSOMEIP_DEPENDENCIES = boost
+
+$(eval $(cmake-package))

--
2.7.4

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20181212/26cca9ac/attachment.html>

Thomas Petazzoni

2018-12-15 14:14 UTC #2 lore raw

PATCH 1/1 package/vsomeip: new package

Hello Maik,

Quoted 3 lines · Maik

From: Maik Brenke <[email protected]>
Signed-off-by Maik Brenke <[email protected]>

Thanks for this new iteration. There are still some formatting issues, but the most important issue is that it doesn't build.

The following defconfig:

BR2_arm=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_TOOLCHAIN_EXTERNAL_CUSTOM=y
BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD=y BR2_TOOLCHAIN_EXTERNAL_URL="http://autobuild.buildroot.org/toolchains/tarballs/br-arm-full-2018.05.tar.bz2" BR2_TOOLCHAIN_EXTERNAL_GCC_4_9=y
BR2_TOOLCHAIN_EXTERNAL_HEADERS_4_1=y
BR2_TOOLCHAIN_EXTERNAL_LOCALE=y
# BR2_TOOLCHAIN_EXTERNAL_HAS_THREADS_DEBUG is not set
BR2_TOOLCHAIN_EXTERNAL_CXX=y
BR2_INIT_NONE=y
BR2_SYSTEM_BIN_SH_NONE=y
# BR2_PACKAGE_BUSYBOX is not set
BR2_PACKAGE_VSOMEIP=y
# BR2_TARGET_ROOTFS_TAR is not set

Causes the following build failure:

Quoted 1 line

Quoted 1 line
Quoted 1 line
vsomeip 2.10.21 Building

PATH="/home/thomas/projets/buildroot/output/host/bin:/home/thomas/projets/buildroot/output/host/sbin:/home/thomas/sys/bin/:/usr/local/bin:/usr/bin:/bin:/home/thomas/.rvm/bin:/usr/local/sbin:/usr/sbin:/home/thomas/.rvm/bin:/home/thomas/sys/bin:/home/thomas/.gem/ruby/2.1.0/bin:/home/thomas/.rvm/bin:/home/thomas/projets/git-wrappers/" /usr/bin/make -j5 -C /home/thomas/projets/buildroot/output/build/vsomeip-2.10.21/ Scanning dependencies of target vsomeip

[  1%] Building CXX object CMakeFiles/vsomeip.dir/implementation/endpoints/src/credentials.cpp.o
[  2%] Building CXX object CMakeFiles/vsomeip.dir/implementation/endpoints/src/client_endpoint_impl.cpp.o
[  4%] Building CXX object CMakeFiles/vsomeip.dir/implementation/endpoints/src/endpoint_definition.cpp.o
[  5%] Building CXX object CMakeFiles/vsomeip.dir/implementation/endpoints/src/local_client_endpoint_impl.cpp.o
[  7%] Building CXX object CMakeFiles/vsomeip.dir/implementation/endpoints/src/endpoint_impl.cpp.o

In file included from /home/thomas/projets/buildroot/output/build/vsomeip-2.10.21/implementation/helper/boost/asio/datagram_socket_service_ext.hpp:33:0,
from /home/thomas/projets/buildroot/output/build/vsomeip-2.10.21/implementation/helper/boost/asio/basic_datagram_socket_ext.hpp:24,
from /home/thomas/projets/buildroot/output/build/vsomeip-2.10.21/implementation/helper/boost/asio/ip/udp_ext.hpp:20,
from /home/thomas/projets/buildroot/output/build/vsomeip-2.10.21/implementation/endpoints/src/endpoint_impl.cpp:8:
/home/thomas/projets/buildroot/output/build/vsomeip-2.10.21/implementation/helper/boost/asio/detail/reactive_socket_service_ext.hpp:29:43: fatal error: boost/asio/detail/addressof.hpp: No such file or directory

 #include <boost/asio/detail/addressof.hpp>
                                           ^

compilation terminated.
make[4]: *** [CMakeFiles/vsomeip.dir/build.make:102: CMakeFiles/vsomeip.dir/implementation/endpoints/src/endpoint_impl.cpp.o] Error 1
make[4]: *** Waiting for unfinished jobs....
/home/thomas/projets/buildroot/output/build/vsomeip-2.10.21/implementation/endpoints/src/local_client_endpoint_impl.cpp: In member function ?virtual void vsomeip::local_client_endpoint_impl::connect()?:
/home/thomas/projets/buildroot/output/build/vsomeip-2.10.21/implementation/endpoints/src/local_client_endpoint_impl.cpp:128:64: error: ?class boost::asio::basic_stream_socket<boost::asio::local::stream_protocol>? has no member named ?native?

                         credentials::send_credentials(socket_->native(),
                                                                ^

make[4]: *** [CMakeFiles/vsomeip.dir/build.make:115: CMakeFiles/vsomeip.dir/implementation/endpoints/src/local_client_endpoint_impl.cpp.o] Error 1 make[3]: *** [CMakeFiles/Makefile2:214: CMakeFiles/vsomeip.dir/all] Error 2
make[2]: *** [Makefile:130: all] Error 2
make[1]: *** [package/pkg-generic.mk:233: /home/thomas/projets/buildroot/output/build/vsomeip-2.10.21/.stamp_built] Error 2
make: *** [Makefile:84: _all] Error 2

I'll comment below some more issues.

DEVELOPERS F: package/mpv/ · line 1262

Quoted 10 lines

DEVELOPERS +2 -0

index 8d5ed19..54a0331 100644
@@ -1258,6 +1258,9 @@ F:        package/mpv/
 F:      package/rpi-firmware/
 F:      package/rpi-userland/
 
+N:     Maik Brenke, <[email protected]>
+F:     package/vsomeip/

Indentation is wrong: one tab should be used between the field name and their values.

package/Config.in menu "Networking" · line 1585

Quoted 13 lines

DEVELOPERS +1 -0

+
 N:      Mamatha Inamdar <[email protected]>
 F:      package/nvme/

package/Config.in +1 -0

index 712e360..7ebb739 100644
@@ -1582,6 +1582,7 @@ menu "Networking"
         source "package/sofia-sip/Config.in"
         source "package/thrift/Config.in"
         source "package/usbredir/Config.in"
+       source "package/vsomeip/Config.in"

Indentation is wrong: use one tab. Perhaps it's because you didn't send your patch with "git send-email".

package/vsomeip/Config.in line 2

Quoted 8 lines

package/vsomeip/Config.in new file +2 -0

new file mode 100644
index 0000000..7244c26
@@ -0,0 +1,22 @@
+config BR2_PACKAGE_VSOMEIP
+       bool "vsomeip"

All over this file, the indentation is wrong: one need to use one tab.

package/vsomeip/Config.in line 6

Quoted 4 lines

package/vsomeip/Config.in new file +4 -0

+       depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
+       depends on BR2_INSTALL_LIBSTDCPP
+       depends on BR2_TOOLCHAIN_HAS_THREADS # boost
+       depends on BR2_PACKAGE_BOOST_ARCH_SUPPORTS

This option doesn't exist, so with dependency, the vsomeip package can never be selected. I'm wondering how you tested it.

package/vsomeip/Config.in line 18

Quoted 12 lines

package/vsomeip/Config.in new file +12 -0

+       select BR2_PACKAGE_BOOST
+       select BR2_PACKAGE_BOOST_SYSTEM
+       select BR2_PACKAGE_BOOST_THREAD
+       select BR2_PACKAGE_BOOST_LOG
+       help
+         The vsomeip stack implements the Scalable service-Oriented
+         MiddlewarE over IP (SOME/IP)) protocol (http://some-ip.com/).
+         The stack consists out of:
+          * a shared library for SOME/IP (`libvsomeip.so`)
+          * a second shared library for SOME/IP's service discovery
+            (`libvsomeip-sd.so`) which is loaded during runtime if
+            the service discovery is enabled.

One blank line needed here.

package/vsomeip/Config.in line 19

Quoted 1 line

package/vsomeip/Config.in new file +1 -0
+         https://github.com/GENIVI/vsomeip

And another one here.

package/vsomeip/Config.in line 21

Quoted 2 lines

package/vsomeip/Config.in new file +2 -0

+comment "vsomeip needs a toolchain w/ C++, threads, gcc >= 4.8"
+       depends on BR2_PACKAGE_BOOST_ARCH_SUPPORTS

Again, this option doesn't exist.

package/vsomeip/Config.in line 22

Quoted 1 line

package/vsomeip/Config.in new file +1 -0

+       depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8

Please split this long line.

package/vsomeip/vsomeip.mk line 5

Quoted 11 lines

package/vsomeip/vsomeip.mk new file +5 -0

new file mode 100644
index 0000000..aebf707
@@ -0,0 +1,13 @@
+################################################################################
+#
+# vsomeip
+#
+################################################################################

Please add one blank line here.

package/vsomeip/vsomeip.mk line 13

Quoted 8 lines

package/vsomeip/vsomeip.mk new file +8 -0

+VSOMEIP_VERSION = 2.10.21
+VSOMEIP_SITE = $(call github,GENIVI,vsomeip,$(VSOMEIP_VERSION))
+VSOMEIP_LICENSE = MPL-2.0
+VSOMEIP_LICENSE_FILES = LICENSE
+
+VSOMEIP_DEPENDENCIES = boost
+
+$(eval $(cmake-package))

I had fixed all the formatting issues, but then stumbled across the build failure, so I gave up. Could you fix those issues, and send an updated version ?

Thanks!

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Brenke

2019-01-02 09:22 UTC #3 lore raw

PATCH 1/1 package/vsomeip: new package

Hello Thomas,

sorry for the mess. It was necessary to resend the "git send-mail" via Microsoft office, which caused the formatting problems (excluding the missing new lines).

But the big problem is the build. I noticed that in the current buildroot version is nothing like "BR2_PACKAGE_BOOST_ARCH_SUPPORTS", as you already mentioned. But I am working on buildroot "2016.05, Released May 31st, 2016" (see [1]). The testing under "2016.05" went fine, but I do not have a config to test it on the latest buildroot version.

In this case my patch will not be compatible to the latest version. Is there a option to handle this case or should we cancel this process?

[1]:
Symbol: BR2_PACKAGE_BOOST_ARCH_SUPPORTS [=y]
Type : boolean
Defined at package/boost/Config.in:4

________________________________
Von: Thomas Petazzoni <[email protected]>
Gesendet: Samstag, 15. Dezember 2018 15:14
An: Brenke, Maik
Cc: buildroot at buildroot.org
Betreff: Re: [Buildroot] WG: [PATCH] package/vsomeip: new package

Hello Maik,

Quoted 3 lines · Maik

From: Maik Brenke <[email protected]>
Signed-off-by Maik Brenke <[email protected]>

Thanks for this new iteration. There are still some formatting issues, but the most important issue is that it doesn't build.

The following defconfig:

Causes the following build failure:

Quoted 1 line

Quoted 1 line
Quoted 1 line
vsomeip 2.10.21 Building

[  1%] Building CXX object CMakeFiles/vsomeip.dir/implementation/endpoints/src/credentials.cpp.o
[  2%] Building CXX object CMakeFiles/vsomeip.dir/implementation/endpoints/src/client_endpoint_impl.cpp.o
[  4%] Building CXX object CMakeFiles/vsomeip.dir/implementation/endpoints/src/endpoint_definition.cpp.o
[  5%] Building CXX object CMakeFiles/vsomeip.dir/implementation/endpoints/src/local_client_endpoint_impl.cpp.o
[  7%] Building CXX object CMakeFiles/vsomeip.dir/implementation/endpoints/src/endpoint_impl.cpp.o

 #include <boost/asio/detail/addressof.hpp>
                                           ^

                         credentials::send_credentials(socket_->native(),
                                                                ^

I'll comment below some more issues.

DEVELOPERS F: package/mpv/ · line 1262

Quoted 10 lines

DEVELOPERS +2 -0

index 8d5ed19..54a0331 100644
@@ -1258,6 +1258,9 @@ F:        package/mpv/
 F:      package/rpi-firmware/
 F:      package/rpi-userland/
 
+N:     Maik Brenke, <[email protected]>
+F:     package/vsomeip/

Indentation is wrong: one tab should be used between the field name and their values.

package/Config.in menu "Networking" · line 1585

Quoted 13 lines

DEVELOPERS +1 -0

+
 N:      Mamatha Inamdar <[email protected]>
 F:      package/nvme/

package/Config.in +1 -0

index 712e360..7ebb739 100644
@@ -1582,6 +1582,7 @@ menu "Networking"
         source "package/sofia-sip/Config.in"
         source "package/thrift/Config.in"
         source "package/usbredir/Config.in"
+       source "package/vsomeip/Config.in"

Indentation is wrong: use one tab. Perhaps it's because you didn't send your patch with "git send-email".

package/vsomeip/Config.in line 2

Quoted 8 lines

package/vsomeip/Config.in new file +2 -0

new file mode 100644
index 0000000..7244c26
@@ -0,0 +1,22 @@
+config BR2_PACKAGE_VSOMEIP
+       bool "vsomeip"

All over this file, the indentation is wrong: one need to use one tab.

package/vsomeip/Config.in line 6

Quoted 4 lines

package/vsomeip/Config.in new file +4 -0

+       depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
+       depends on BR2_INSTALL_LIBSTDCPP
+       depends on BR2_TOOLCHAIN_HAS_THREADS # boost
+       depends on BR2_PACKAGE_BOOST_ARCH_SUPPORTS

This option doesn't exist, so with dependency, the vsomeip package can never be selected. I'm wondering how you tested it.

package/vsomeip/Config.in line 18

Quoted 12 lines

package/vsomeip/Config.in new file +12 -0

+       select BR2_PACKAGE_BOOST
+       select BR2_PACKAGE_BOOST_SYSTEM
+       select BR2_PACKAGE_BOOST_THREAD
+       select BR2_PACKAGE_BOOST_LOG
+       help
+         The vsomeip stack implements the Scalable service-Oriented
+         MiddlewarE over IP (SOME/IP)) protocol (http://some-ip.com/).
+         The stack consists out of:
+          * a shared library for SOME/IP (`libvsomeip.so`)
+          * a second shared library for SOME/IP's service discovery
+            (`libvsomeip-sd.so`) which is loaded during runtime if
+            the service discovery is enabled.

One blank line needed here.

package/vsomeip/Config.in line 19

Quoted 1 line

package/vsomeip/Config.in new file +1 -0
+         https://github.com/GENIVI/vsomeip

And another one here.

package/vsomeip/Config.in line 21

Quoted 2 lines

package/vsomeip/Config.in new file +2 -0

+comment "vsomeip needs a toolchain w/ C++, threads, gcc >= 4.8"
+       depends on BR2_PACKAGE_BOOST_ARCH_SUPPORTS

Again, this option doesn't exist.

package/vsomeip/Config.in line 22

Quoted 1 line

package/vsomeip/Config.in new file +1 -0

+       depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8

Please split this long line.

package/vsomeip/vsomeip.mk line 5

Quoted 11 lines

package/vsomeip/vsomeip.mk new file +5 -0

new file mode 100644
index 0000000..aebf707
@@ -0,0 +1,13 @@
+################################################################################
+#
+# vsomeip
+#
+################################################################################

Please add one blank line here.

package/vsomeip/vsomeip.mk line 13

Quoted 8 lines

package/vsomeip/vsomeip.mk new file +8 -0

+VSOMEIP_VERSION = 2.10.21
+VSOMEIP_SITE = $(call github,GENIVI,vsomeip,$(VSOMEIP_VERSION))
+VSOMEIP_LICENSE = MPL-2.0
+VSOMEIP_LICENSE_FILES = LICENSE
+
+VSOMEIP_DEPENDENCIES = boost
+
+$(eval $(cmake-package))

I had fixed all the formatting issues, but then stumbled across the build failure, so I gave up. Could you fix those issues, and send an updated version ?

Thanks!

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190102/7f770189/attachment.html>