Skip to contentSkip to conversation

flatbuffers: update to 1.10.0

PATCH In review Adrian Freihofer 2 participants 2 messages Dec 16, 2018 – Feb 10, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 flatbuffers: update to 1.10.0

From: Adrian Freihofer <[email protected]>

This is in fact an update from 1.7.1 to 1.10.0. (The git hash of the 1.9.0 recipe referred flatbuffers release 1.7.1.)

This patch is obsolete, a similar fix has been applied upstream:
- 0001-correct-version-for-so-lib.patch
These two patches have been applied upstream:
- 0001-flatbuffers-Move-EndianSwap-template-to-flatbuffers-.patch
- 0002-use-__builtin_bswap16-when-building-with-clang.patch

---
 .../0001-correct-version-for-so-lib.patch     |  26 ----
 ...-EndianSwap-template-to-flatbuffers-.patch | 113 ------------------
 ...tin_bswap16-when-building-with-clang.patch |  30 -----
 ...buffers_1.9.0.bb => flatbuffers_1.10.0.bb} |  13 +-
 4 files changed, 5 insertions(+), 177 deletions(-)
 delete mode 100644 meta-oe/recipes-devtools/flatbuffers/files/0001-correct-version-for-so-lib.patch
 delete mode 100644 meta-oe/recipes-devtools/flatbuffers/files/0001-flatbuffers-Move-EndianSwap-template-to-flatbuffers-.patch
 delete mode 100644 meta-oe/recipes-devtools/flatbuffers/files/0002-use-__builtin_bswap16-when-building-with-clang.patch
 rename meta-oe/recipes-devtools/flatbuffers/{flatbuffers_1.9.0.bb => flatbuffers_1.10.0.bb} (61%)
meta-oe/recipes-devtools/flatbuffers/files/0001-correct-version-for-so-lib.patch deleted +0 -26
deleted file mode 100644
index a7a42f981..000000000
@@ -1,26 +0,0 @@
-From 8b44dc65d98d50b462843ac9dab6fe3fc25abe36 Mon Sep 17 00:00:00 2001
-From: Pascal Bach <[email protected]>
-Date: Fri, 12 May 2017 13:54:49 +0200
-Subject: [PATCH] correct version for so lib
-
-Upstream-Status: Pending
-
----
- CMakeLists.txt | 1 +
- 1 file changed, 1 insertion(+)
-
-diff --git a/CMakeLists.txt b/CMakeLists.txt
-index 3670afe..f4fcd2c 100644
---- a/CMakeLists.txt
-+++ b/CMakeLists.txt
-@@ -172,6 +172,7 @@ endif()
- if(FLATBUFFERS_BUILD_SHAREDLIB)
-   add_library(flatbuffers_shared SHARED ${FlatBuffers_Library_SRCS})
-   set_target_properties(flatbuffers_shared PROPERTIES OUTPUT_NAME flatbuffers)
-+  set_target_properties(flatbuffers_shared PROPERTIES VERSION "${PV}")
- endif()
- 
- function(compile_flatbuffers_schema_to_cpp SRC_FBS)
--- 
-2.1.4
-
meta-oe/recipes-devtools/flatbuffers/files/0001-flatbuffers-Move-EndianSwap-template-to-flatbuffers-.patch deleted +0 -113

113 lines not on this page · raw message

meta-oe/recipes-devtools/flatbuffers/files/0002-use-__builtin_bswap16-when-building-with-clang.patch deleted +0 -30
deleted file mode 100644
index 460159f27..000000000
@@ -1,30 +0,0 @@
-From 626fe5e043de25e970ebdf061b88c646fa689113 Mon Sep 17 00:00:00 2001
-From: Khem Raj <[email protected]>
-Date: Tue, 19 Sep 2017 10:09:31 -0700
-Subject: [PATCH 2/2] use __builtin_bswap16 when building with clang
-
-clang pretends to be gcc 4.2.0 and therefore the code does
-not use __builtin_bswap16 but tries to synthesize it
-
-Signed-off-by: Khem Raj <[email protected]>
----
-Upstream-Status: Submitted
- include/flatbuffers/base.h | 2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
-
-diff --git a/include/flatbuffers/base.h b/include/flatbuffers/base.h
-index c73fb2d..13e8fac 100644
---- a/include/flatbuffers/base.h
-+++ b/include/flatbuffers/base.h
-@@ -156,7 +156,7 @@ template<typename T> T EndianSwap(T t) {
-     #define FLATBUFFERS_BYTESWAP32 _byteswap_ulong
-     #define FLATBUFFERS_BYTESWAP64 _byteswap_uint64
-   #else
--    #if defined(__GNUC__) && __GNUC__ * 100 + __GNUC_MINOR__ < 408
-+    #if defined(__GNUC__) && __GNUC__ * 100 + __GNUC_MINOR__ < 408 && !defined(__clang__)
-       // __builtin_bswap16 was missing prior to GCC 4.8.
-       #define FLATBUFFERS_BYTESWAP16(x) \
-         static_cast<uint16_t>(__builtin_bswap32(static_cast<uint32_t>(x) << 16))
--- 
-2.14.1
-
meta-oe/recipes-devtools/flatbuffers/flatbuffers_1.10.0.bb renamed from meta-oe/recipes-devtools/flatbuffers/flatbuffers_1.9.0.bb +5 -8
similarity index 61%
rename from meta-oe/recipes-devtools/flatbuffers/flatbuffers_1.9.0.bb
rename to meta-oe/recipes-devtools/flatbuffers/flatbuffers_1.10.0.bb
index a8df44485..452e1e65a 100644
@@ -10,22 +10,19 @@ RDEPENDS_${PN}-dev += "${PN}-compiler"
 
 LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=a873c5645c184d51e0f9b34e1d7cf559"
 
-SRCREV = "25a15950f5a24d7217689739ed8f6dac64912d62"
+SRCREV = "c0698cc33f1e534bb59c455909b88cc2726089af"
 
-SRC_URI = "git://github.com/google/flatbuffers.git \
-           file://0001-correct-version-for-so-lib.patch \
-           file://0001-flatbuffers-Move-EndianSwap-template-to-flatbuffers-.patch \
-           file://0002-use-__builtin_bswap16-when-building-with-clang.patch \
-           "
+SRC_URI = "git://github.com/google/flatbuffers.git"
 
 # Make sure C++11 is used, required for example for GCC 4.9
 CXXFLAGS += "-std=c++11"
 BUILD_CXXFLAGS += "-std=c++11"
 
+# BUILD_TYPE=Release is required, otherwise flatc is not installed
 EXTRA_OECMAKE += "\
-    -DFLATBUFFERS_BUILD_TESTS=OFF \
+    -DCMAKE_BUILD_TYPE=Release \
+    -DFLATBUFFERS_BUILD_TESTS=OFF \    
     -DFLATBUFFERS_BUILD_SHAREDLIB=ON \
-    -DPV=${PV} \
 "
 
 inherit cmake
Signature · 1 line
2.17.1
#1 lore raw

meta-oe/recipes-devtools/flatbuffers/flatbuffers_1.10.0.bb RDEPENDS_${PN}-dev += "${PN}-compiler" · line 24

Quoted 12 lines · Adrian Freihofer

From: Adrian Freihofer <[email protected]>

This is in fact an update from 1.7.1 to 1.10.0. (The git hash of the 1.9.0 recipe referred flatbuffers release 1.7.1.)

meta-oe/recipes-devtools/flatbuffers/flatbuffers_1.10.0.bb renamed from meta-oe/recipes-devtools/flatbuffers/flatbuffers_1.9.0.bb +3 -1
+# BUILD_TYPE=Release is required, otherwise flatc is not installed
 EXTRA_OECMAKE += "\
-    -DFLATBUFFERS_BUILD_TESTS=OFF \
+    -DCMAKE_BUILD_TYPE=Release \
+    -DFLATBUFFERS_BUILD_TESTS=OFF \

I'm trying to DFLATBUFFERS_BUILD_TESTS=ON and I'm facing a flatc: Exec format error

Would you have some advice?

Thanks in advance,
Daiane