IB/qib: Fix an error code in qib_sdma_verbs_send()

PATCH New Dan Carpenter 1 participant 1 message Dec 17, 2018

Subsystems (2)

Kernel janitors InfiniBand

lore

Share & tools

lore

Dan Carpenter

author

2018-12-17 07:05 UTC #0 lore raw

PATCH 1/1 IB/qib: Fix an error code in qib_sdma_verbs_send()

We accidentally return success on this error path.

Fixes f931551bafe1 ("IB/qib: Add new qib driver for QLogic PCIe InfiniBand adapters")

Signed-off-by Dan Carpenter <[email protected]>

---
 drivers/infiniband/hw/qib/qib_sdma.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

drivers/infiniband/hw/qib/qib_sdma.c +3 -1

index 0b6ca424c11d..3d64081c4819 100644
@@ -575,8 +575,10 @@ int qib_sdma_verbs_send(struct qib_pportdata *ppd,
 		dw = (len + 3) >> 2;
 		addr = dma_map_single(&ppd->dd->pcidev->dev, sge->vaddr,
 				      dw << 2, DMA_TO_DEVICE);
-		if (dma_mapping_error(&ppd->dd->pcidev->dev, addr))
+		if (dma_mapping_error(&ppd->dd->pcidev->dev, addr)) {
+			ret = -ENOMEM;
 			goto unmap;
+		}
 		sdmadesc[0] = 0;
 		make_sdma_desc(ppd, sdmadesc, (u64) addr, dw, dwoffset);
 		/* SDmaUseLargeBuf has to be set in every descriptor */

Signature · 1 line

2.17.1