drm/i915: Infoframe precompute/check
Subsystems (3)
v2 cover drm/i915: Infoframe precompute/check
From: Ville Syrjälä <[email protected]>
Remainder of the infoframe precompute/check work. Review comments addressesed, and I added a bunch of FIXMEs for lspcon. Note that the lack of proper implementation for lspcon shouldn't matter since we don't do the precompute/readout/check for DP encoders atm.
Entire series is available here:git://github.com/vsyrjala/linux.git infoframe_precompute_5
Ville Syrjälä (10):
video/hdmi: Add an enum for HDMI packet types drm/i915: Add the missing HDMI gamut metadata packet stuff drm/i915: Return the mask of enabled infoframes from
->inforame_enabled()
drm/i915: Store mask of enabled infoframes in the crtc state drm/i915: Precompute HDMI infoframes
drm/i915: Read out HDMI infoframes
drm/i915/sdvo: Precompute HDMI infoframes drm/i915/sdvo: Read out HDMI infoframes
drm/i915: Check infoframe state in intel_pipe_config_compare() drm/i915: Include infoframes in the crtc state dump
drivers/gpu/drm/i915/i915_reg.h | 8 +- drivers/gpu/drm/i915/intel_ddi.c | 17 +- drivers/gpu/drm/i915/intel_display.c | 75 +++- drivers/gpu/drm/i915/intel_drv.h | 29 +- drivers/gpu/drm/i915/intel_hdmi.c | 516 ++++++++++++++++++++++----- drivers/gpu/drm/i915/intel_lspcon.c | 13 +- drivers/gpu/drm/i915/intel_sdvo.c | 152 +++++++- include/linux/hdmi.h | 15 + 8 files changed, 706 insertions(+), 119 deletions(-)
Signature · 6 lines
2.18.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v2 1/10 video/hdmi: Add an enum for HDMI packet types
From: Ville Syrjälä <[email protected]>
We'll be wanting to send more than just infoframes over HDMI. So add an enum for other packet types.
TODO: Maybe just include the infoframe types in the packet type enum
and get rid of the infoframe type enum?
--- include/linux/hdmi.h | 15 +++++++++++++++ 1 file changed, 15 insertions(+)
include/linux/hdmi.h +15 -0
@@ -27,6 +27,21 @@#include <linux/types.h> #include <linux/device.h> +enum hdmi_packet_type { +HDMI_PACKET_TYPE_NULL =0x00 , +HDMI_PACKET_TYPE_AUDIO_CLOCK_REGEN =0x01 , +HDMI_PACKET_TYPE_AUDIO_SAMPLE =0x02 , +HDMI_PACKET_TYPE_GENERAL_CONTROL =0x03 , +HDMI_PACKET_TYPE_AUDIO_CP =0x04 , +HDMI_PACKET_TYPE_ISRC1 =0x05 , +HDMI_PACKET_TYPE_ISRC2 =0x06 , +HDMI_PACKET_TYPE_ONE_BIT_AUDIO_SAMPLE =0x07 , +HDMI_PACKET_TYPE_DST_AUDIO =0x08 , +HDMI_PACKET_TYPE_HBR_AUDIO_STREAM =0x09 , +HDMI_PACKET_TYPE_GAMUT_METADATA =0x0a , +/* + enum hdmi_infoframe_type */ +}; +enum hdmi_infoframe_type {HDMI_INFOFRAME_TYPE_VENDOR =0x81 ,HDMI_INFOFRAME_TYPE_AVI =0x82 ,
Signature · 6 lines
2.18.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v2 2/10 drm/i915: Add the missing HDMI gamut metadata packet stuff
In reply to Ville SyrjalaFrom: Ville Syrjälä <[email protected]>
We have definitions and low level code for everything except the gamut metadata HDMI packet. Add the missing bits.
--- drivers/gpu/drm/i915/i915_reg.h | 8 +++++--- drivers/gpu/drm/i915/intel_hdmi.c | 12 ++++++++++++ 2 files changed, 17 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/i915_reg.h +5 -3
@@ -4594,13 +4594,14 @@ enum {#define VIDEO_DIP_ENABLE (1 << 31)#define VIDEO_DIP_PORT (port) ((port) << 29)#define VIDEO_DIP_PORT_MASK (3 << 29) -#define VIDEO_DIP_ENABLE_GCP (1 << 25) +#define VIDEO_DIP_ENABLE_GCP (1 << 25)/* ilk+ */ #define VIDEO_DIP_ENABLE_AVI (1 << 21)#define VIDEO_DIP_ENABLE_VENDOR (2 << 21) -#define VIDEO_DIP_ENABLE_GAMUT (4 << 21) +#define VIDEO_DIP_ENABLE_GAMUT (4 << 21)/* ilk+ */ #define VIDEO_DIP_ENABLE_SPD (8 << 21)#define VIDEO_DIP_SELECT_AVI (0 << 19)#define VIDEO_DIP_SELECT_VENDOR (1 << 19) +#define VIDEO_DIP_SELECT_GAMUT (2 << 19)#define VIDEO_DIP_SELECT_SPD (3 << 19)#define VIDEO_DIP_SELECT_MASK (3 << 19)#define VIDEO_DIP_FREQ_ONCE (0 << 16)
@@ -8065,10 +8066,11 @@ enum {#define _ICL_VIDEO_DIP_PPS_ECC_B 0x613D4#define HSW_TVIDEO_DIP_CTL (trans) _MMIO_TRANS2(trans, _HSW_VIDEO_DIP_CTL_A) +#define HSW_TVIDEO_DIP_GCP (trans) _MMIO_TRANS2(trans, _HSW_VIDEO_DIP_GCP_A)#define HSW_TVIDEO_DIP_AVI_DATA (trans, i) _MMIO_TRANS2(trans, _HSW_VIDEO_DIP_AVI_DATA_A + (i) * 4)#define HSW_TVIDEO_DIP_VS_DATA (trans, i) _MMIO_TRANS2(trans, _HSW_VIDEO_DIP_VS_DATA_A + (i) * 4)#define HSW_TVIDEO_DIP_SPD_DATA (trans, i) _MMIO_TRANS2(trans, _HSW_VIDEO_DIP_SPD_DATA_A + (i) * 4) -#define HSW_TVIDEO_DIP_GCP (trans) _MMIO_TRANS2(trans, _HSW_VIDEO_DIP_GCP_A) +#define HSW_TVIDEO_DIP_GMP_DATA (trans, i) _MMIO_TRANS2(trans, _HSW_VIDEO_DIP_GMP_DATA_A + (i) * 4)#define HSW_TVIDEO_DIP_VSC_DATA (trans, i) _MMIO_TRANS2(trans, _HSW_VIDEO_DIP_VSC_DATA_A + (i) * 4)#define ICL_VIDEO_DIP_PPS_DATA (trans, i) _MMIO_TRANS2(trans, _ICL_VIDEO_DIP_PPS_DATA_A + (i) * 4)#define ICL_VIDEO_DIP_PPS_ECC (trans, i) _MMIO_TRANS2(trans, _ICL_VIDEO_DIP_PPS_ECC_A + (i) * 4)
drivers/gpu/drm/i915/intel_hdmi.c +12 -0
@@ -83,6 +83,8 @@ static struct intel_hdmi *intel_attached_hdmi(struct drm_connector *connector)static u32 g4x_infoframe_index (unsigned int type) {switch (type) { +case HDMI_PACKET_TYPE_GAMUT_METADATA : +return VIDEO_DIP_SELECT_GAMUT ;case HDMI_INFOFRAME_TYPE_AVI :return VIDEO_DIP_SELECT_AVI ;case HDMI_INFOFRAME_TYPE_SPD :
@@ -98,6 +100,10 @@ static u32 g4x_infoframe_index(unsigned int type)static u32 g4x_infoframe_enable (unsigned int type) {switch (type) { +case HDMI_PACKET_TYPE_GENERAL_CONTROL : +return VIDEO_DIP_ENABLE_GCP ; +case HDMI_PACKET_TYPE_GAMUT_METADATA : +return VIDEO_DIP_ENABLE_GAMUT ;case HDMI_INFOFRAME_TYPE_AVI :return VIDEO_DIP_ENABLE_AVI ;case HDMI_INFOFRAME_TYPE_SPD :
@@ -113,6 +119,10 @@ static u32 g4x_infoframe_enable(unsigned int type)static u32 hsw_infoframe_enable (unsigned int type) {switch (type) { +case HDMI_PACKET_TYPE_GENERAL_CONTROL : +return VIDEO_DIP_ENABLE_GCP_HSW ; +case HDMI_PACKET_TYPE_GAMUT_METADATA : +return VIDEO_DIP_ENABLE_GMP_HSW ;case DP_SDP_VSC :return VIDEO_DIP_ENABLE_VSC_HSW ;case DP_SDP_PPS :
@@ -136,6 +146,8 @@ hsw_dip_data_reg(struct drm_i915_private *dev_priv, int i) {switch (type) { +case HDMI_PACKET_TYPE_GAMUT_METADATA : +return HSW_TVIDEO_DIP_GMP_DATA (cpu_transcoder, i);case DP_SDP_VSC :return HSW_TVIDEO_DIP_VSC_DATA (cpu_transcoder, i);case DP_SDP_PPS :
Signature · 6 lines
2.18.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v2 3/10 drm/i915: Return the mask of enabled infoframes from ->inforame_enabled()
In reply to Ville SyrjalaFrom: Ville Syrjälä <[email protected]>
We want to start tracking which infoframes are enabled, so let's replace the boolean flag with a bitmask.
We'll abstract the bitmask so that it's not platform dependent. That will allow us to examine the bitmask later in platform independent code.
v2: Don't map VIDEO_DIP_ENABLE to the null packet (Daniel)
Put a FIXME in the lspcon function
--- drivers/gpu/drm/i915/intel_ddi.c | 2 +- drivers/gpu/drm/i915/intel_drv.h | 6 ++- drivers/gpu/drm/i915/intel_hdmi.c | 83 ++++++++++++++++++++--------- drivers/gpu/drm/i915/intel_lspcon.c | 3 +- 4 files changed, 65 insertions(+), 29 deletions(-)
drivers/gpu/drm/i915/intel_ddi.c +1 -1
@@ -3790,7 +3790,7 @@ void intel_ddi_get_config(struct intel_encoder *encoder, pipe_config->has_hdmi_sink = true; intel_dig_port =enc_to_dig_port (&encoder->base); -if (intel_dig_port->infoframe_enabled (encoder, pipe_config)) +if (intel_hdmi_infoframes_enabled (encoder, pipe_config)) pipe_config->has_infoframe = true;if (temp &TRANS_DDI_HDMI_SCRAMBLING )
drivers/gpu/drm/i915/intel_drv.h +4 -2
@@ -1247,7 +1247,7 @@ struct intel_digital_port {bool enable, const struct intel_crtc_state *crtc_state, const struct drm_connector_state *conn_state); -bool (*infoframe_enabled)(struct intel_encoder *encoder, +u32 (*infoframes_enabled)(struct intel_encoder *encoder,const struct intel_crtc_state *pipe_config); };
@@ -1979,6 +1979,8 @@ bool intel_hdmi_handle_sink_scrambling(struct intel_encoder *encoder, bool scrambling);void intel_dp_dual_mode_set_tmds_output (struct intel_hdmi *hdmi,bool enable);void intel_infoframe_init (struct intel_digital_port *intel_dig_port); +u32 intel_hdmi_infoframes_enabled (struct intel_encoder *encoder, +const struct intel_crtc_state *crtc_state);/* intel_lvds.c */ bool intel_lvds_port_enabled(struct drm_i915_private *dev_priv,
@@ -2347,7 +2349,7 @@ void lspcon_set_infoframes(struct intel_encoder *encoder,bool enable, const struct intel_crtc_state *crtc_state, const struct drm_connector_state *conn_state); -bool lspcon_infoframe_enabled (struct intel_encoder *encoder, +u32 lspcon_infoframes_enabled (struct intel_encoder *encoder,const struct intel_crtc_state *pipe_config);void lspcon_ycbcr420_config (struct drm_connector *connector,struct intel_crtc_state *crtc_state);
drivers/gpu/drm/i915/intel_hdmi.c +58 -25
188 lines not on this page · raw message
drivers/gpu/drm/i915/intel_lspcon.c +2 -1
@@ -504,9 +504,10 @@ void lspcon_set_infoframes(struct intel_encoder *encoder, buf, ret); } -bool lspcon_infoframe_enabled (struct intel_encoder *encoder, +u32 lspcon_infoframes_enabled (struct intel_encoder *encoder,const struct intel_crtc_state *pipe_config) { +/* FIXME actually read this from the hw */ return enc_to_intel_lspcon (&encoder->base)->active; }
Signature · 6 lines
2.18.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v2 4/10 drm/i915: Store mask of enabled infoframes in the crtc state
In reply to Ville SyrjalaFrom: Ville Syrjälä <[email protected]>
Store the mask of enabled infoframes in the crtc state. We'll start with just the readout for HDMI encoder, and we'll expand this to compute the bitmask in .compute_config() later. SDVO will also follow later.
--- drivers/gpu/drm/i915/intel_ddi.c | 5 ++++- drivers/gpu/drm/i915/intel_drv.h | 4 ++++ drivers/gpu/drm/i915/intel_hdmi.c | 5 ++++- 3 files changed, 12 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/intel_ddi.c +4 -1
@@ -3790,7 +3790,10 @@ void intel_ddi_get_config(struct intel_encoder *encoder, pipe_config->has_hdmi_sink = true; intel_dig_port =enc_to_dig_port (&encoder->base); -if (intel_hdmi_infoframes_enabled (encoder, pipe_config)) + pipe_config->infoframes.enable |= +intel_hdmi_infoframes_enabled (encoder, pipe_config); + +if (pipe_config->infoframes.enable) pipe_config->has_infoframe = true;if (temp &TRANS_DDI_HDMI_SCRAMBLING )
drivers/gpu/drm/i915/intel_drv.h +4 -0
@@ -931,6 +931,10 @@ struct intel_crtc_state {/* bitmask of planes that will be updated during the commit */ u8 update_planes; +struct { +u32 enable; + } infoframes; +/* HDMI scrambling status */ bool hdmi_scrambling;
drivers/gpu/drm/i915/intel_hdmi.c +4 -1
@@ -1279,7 +1279,10 @@ static void intel_hdmi_get_config(struct intel_encoder *encoder,if (tmp &HDMI_MODE_SELECT_HDMI ) pipe_config->has_hdmi_sink = true; -if (intel_hdmi_infoframes_enabled (encoder, pipe_config)) + pipe_config->infoframes.enable |= +intel_hdmi_infoframes_enabled (encoder, pipe_config); + +if (pipe_config->infoframes.enable) pipe_config->has_infoframe = true;if (tmp &SDVO_AUDIO_ENABLE )
Signature · 6 lines
2.18.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v2 5/10 drm/i915: Precompute HDMI infoframes
In reply to Ville SyrjalaFrom: Ville Syrjälä <[email protected]>
Store the infoframes in the crtc state and precompute them in .compute_config(). While precomputing we'll also fill out the inforames.enable bitmask appropriately.
v2: Drop the null packet stuff (Daniel)
Add a FIXME for lspcon
--- drivers/gpu/drm/i915/intel_drv.h | 5 + drivers/gpu/drm/i915/intel_hdmi.c | 246 ++++++++++++++++++++-------- drivers/gpu/drm/i915/intel_lspcon.c | 2 + 3 files changed, 185 insertions(+), 68 deletions(-)
drivers/gpu/drm/i915/intel_drv.h +5 -0
@@ -933,6 +933,10 @@ struct intel_crtc_state {struct {u32 enable; +u32 gcp; +union hdmi_infoframe avi; +union hdmi_infoframe spd; +union hdmi_infoframe hdmi; } infoframes;/* HDMI scrambling status */
@@ -1985,6 +1989,7 @@ void intel_dp_dual_mode_set_tmds_output(struct intel_hdmi *hdmi, bool enable);void intel_infoframe_init (struct intel_digital_port *intel_dig_port);u32 intel_hdmi_infoframes_enabled (struct intel_encoder *encoder,const struct intel_crtc_state *crtc_state); +u32 intel_hdmi_infoframe_enable (unsigned int type);/* intel_lvds.c */ bool intel_lvds_port_enabled(struct drm_i915_private *dev_priv,
drivers/gpu/drm/i915/intel_hdmi.c +178 -68
363 lines not on this page · raw message
drivers/gpu/drm/i915/intel_lspcon.c +2 -0
@@ -472,6 +472,8 @@ void lspcon_set_infoframes(struct intel_encoder *encoder,return ; } +/* FIXME precompute infoframes */ + ret =drm_hdmi_avi_infoframe_from_display_mode (&frame.avi, mode, is_hdmi2_sink);if (ret <0 ) {
Signature · 6 lines
2.18.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v2 6/10 drm/i915: Read out HDMI infoframes
In reply to Ville SyrjalaFrom: Ville Syrjälä <[email protected]>
Add code to read the infoframes from the video DIP and unpack them into the crtc state.
v2: Make the read funcs return void (Daniel)
Drop the duplicate infoframe enabled checks (Daniel) Add a FIXME for lspcon infoframe readout
--- drivers/gpu/drm/i915/intel_ddi.c | 12 ++ drivers/gpu/drm/i915/intel_drv.h | 14 +++ drivers/gpu/drm/i915/intel_hdmi.c | 172 ++++++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_lspcon.c | 8 ++ 4 files changed, 206 insertions(+)
drivers/gpu/drm/i915/intel_ddi.c +12 -0
@@ -3857,6 +3857,18 @@ void intel_ddi_get_config(struct intel_encoder *encoder,bxt_ddi_phy_get_lane_lat_optim_mask (encoder);intel_ddi_compute_min_voltage_level (dev_priv, pipe_config); + +intel_hdmi_read_gcp_infoframe (encoder, pipe_config); + +intel_read_infoframe (encoder, pipe_config, +HDMI_INFOFRAME_TYPE_AVI , + &pipe_config->infoframes.avi); +intel_read_infoframe (encoder, pipe_config, +HDMI_INFOFRAME_TYPE_SPD , + &pipe_config->infoframes.spd); +intel_read_infoframe (encoder, pipe_config, +HDMI_INFOFRAME_TYPE_VENDOR , + &pipe_config->infoframes.hdmi); } static enum intel_output_type
drivers/gpu/drm/i915/intel_drv.h +14 -0
@@ -1251,6 +1251,10 @@ struct intel_digital_port {const struct intel_crtc_state *crtc_state, unsigned int type, const void *frame, ssize_t len); +void (*read_infoframe)(struct intel_encoder *encoder, +const struct intel_crtc_state *crtc_state, +unsigned int type, +void *frame,ssize_t len); void (*set_infoframes)(struct intel_encoder *encoder, bool enable, const struct intel_crtc_state *crtc_state,
@@ -1990,6 +1994,12 @@ void intel_infoframe_init(struct intel_digital_port *intel_dig_port);u32 intel_hdmi_infoframes_enabled (struct intel_encoder *encoder,const struct intel_crtc_state *crtc_state);u32 intel_hdmi_infoframe_enable (unsigned int type); +void intel_hdmi_read_gcp_infoframe (struct intel_encoder *encoder, +struct intel_crtc_state *crtc_state); +void intel_read_infoframe (struct intel_encoder *encoder, +const struct intel_crtc_state *crtc_state, +enum hdmi_infoframe_type type, +union hdmi_infoframe *frame);/* intel_lvds.c */ bool intel_lvds_port_enabled(struct drm_i915_private *dev_priv,
@@ -2354,6 +2364,10 @@ void lspcon_write_infoframe(struct intel_encoder *encoder,const struct intel_crtc_state *crtc_state, unsigned int type, const void *buf, ssize_t len); +void lspcon_read_infoframe (struct intel_encoder *encoder, +const struct intel_crtc_state *crtc_state, +unsigned int type, +void *frame,ssize_t len); void lspcon_set_infoframes(struct intel_encoder *encoder, bool enable, const struct intel_crtc_state *crtc_state,
drivers/gpu/drm/i915/intel_hdmi.c +172 -0
248 lines not on this page · raw message
drivers/gpu/drm/i915/intel_lspcon.c +8 -0
@@ -452,6 +452,14 @@ void lspcon_write_infoframe(struct intel_encoder *encoder,DRM_DEBUG_DRIVER ("AVI infoframes updated successfully\n" ); } +void lspcon_read_infoframe (struct intel_encoder *encoder, +const struct intel_crtc_state *crtc_state, +unsigned int type, +void *frame,ssize_t len) +{ +/* FIXME implement this */ +} + void lspcon_set_infoframes(struct intel_encoder *encoder, bool enable, const struct intel_crtc_state *crtc_state,
Signature · 6 lines
2.18.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v2 7/10 drm/i915/sdvo: Precompute HDMI infoframes
In reply to Ville SyrjalaFrom: Ville Syrjälä <[email protected]>
As with regular HDMI encoders, let's precompute the infoframes (actually just AVI infoframe for the time being) with SDVO HDMI encoders.
v2: Drop the WARN_ON() from drm_hdmi_avi_infoframe_from_display_mode()
return since that could genuinely fail due to user asking for incompatible aspect ratio
--- drivers/gpu/drm/i915/intel_sdvo.c | 58 +++++++++++++++++++++++-------- 1 file changed, 43 insertions(+), 15 deletions(-)
drivers/gpu/drm/i915/intel_sdvo.c +43 -15
@@ -980,33 +980,57 @@ static bool intel_sdvo_write_infoframe(struct intel_sdvo *intel_sdvo, &tx_rate, 1); } -static bool intel_sdvo_set_avi_infoframe (struct intel_sdvo *intel_sdvo, -const struct intel_crtc_state *pipe_config) +static bool intel_sdvo_compute_avi_infoframe (struct intel_sdvo *intel_sdvo, +struct intel_crtc_state *crtc_state, +struct drm_connector_state *conn_state) { -uint8_t sdvo_data[HDMI_INFOFRAME_SIZE (AVI )]; -union hdmi_infoframe frame; +struct hdmi_avi_infoframe *frame = &crtc_state->infoframes.avi.avi;int ret; -ssize_t len; - ret =drm_hdmi_avi_infoframe_from_display_mode (&frame.avi, - &pipe_config->base.adjusted_mode, +if (!crtc_state->has_hdmi_sink) +return true; + + crtc_state->infoframes.enable |= +intel_hdmi_infoframe_enable (HDMI_INFOFRAME_TYPE_AVI ); + + ret =drm_hdmi_avi_infoframe_from_display_mode (frame, + &crtc_state->base.adjusted_mode, false); -if (ret <0 ) { -DRM_ERROR ("couldn't fill AVI infoframe\n" ); +if (ret)return false; - }if (intel_sdvo->rgb_quant_range_selectable) { -if (pipe_config->limited_color_range) - frame.avi.quantization_range = +if (crtc_state->limited_color_range) + frame->quantization_range =HDMI_QUANTIZATION_RANGE_LIMITED ;else - frame.avi.quantization_range = + frame->quantization_range =HDMI_QUANTIZATION_RANGE_FULL ; } - len =hdmi_infoframe_pack (&frame, sdvo_data,sizeof (sdvo_data)); -if (len <0 ) + ret =hdmi_avi_infoframe_check (frame); +if (WARN_ON (ret)) +return false; + +return true; +} + +static bool intel_sdvo_set_avi_infoframe (struct intel_sdvo *intel_sdvo, +const struct intel_crtc_state *crtc_state) +{ +u8 sdvo_data[HDMI_INFOFRAME_SIZE (AVI )]; +const union hdmi_infoframe *frame = &crtc_state->infoframes.avi; +ssize_t len; + +if ((crtc_state->infoframes.enable & +intel_hdmi_infoframe_enable (HDMI_INFOFRAME_TYPE_AVI )) ==0 ) +return true; + +if (WARN_ON (frame->any.type !=HDMI_INFOFRAME_TYPE_AVI )) +return false; + + len =hdmi_infoframe_pack_only (frame, sdvo_data,sizeof (sdvo_data)); +if (WARN_ON (len <0 ))return false; return intel_sdvo_write_infoframe(intel_sdvo, SDVO_HBUF_INDEX_AVI_IF,
@@ -1194,6 +1218,10 @@ static bool intel_sdvo_compute_config(struct intel_encoder *encoder,if (intel_sdvo_connector->is_hdmi) adjusted_mode->picture_aspect_ratio = conn_state->picture_aspect_ratio; +if (!intel_sdvo_compute_avi_infoframe (intel_sdvo, + pipe_config, conn_state)) +return false; +return true; }
Signature · 6 lines
2.18.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v2 8/10 drm/i915/sdvo: Read out HDMI infoframes
In reply to Ville SyrjalaFrom: Ville Syrjälä <[email protected]>
Read the HDMI infoframes from the hbuf and unpack them into the crtc state.
Well, actually just AVI infoframe for now but let's write the infoframe readout code in a more generic fashion in case we expand this later.
Note that Daniel was sceptical about the benefit if this and also concerned about the potential for crappy sdvo encoders not implementing the hbuf read commands. My (admittedly limited) experience is that such encoders don't implement even the get/set hdmi encoding commands and thus would always be treated as dvi only. Hence I believe this is safe, and also IMO preferable having quirks to deal with missing readout support. The readout support is neatly isolated in the sdvo code whereas the quirk would leak to other parts of the driver (state checker, fastboot, etc.) thus complicating the lives of other people.
--- drivers/gpu/drm/i915/intel_sdvo.c | 94 ++++++++++++++++++++++++++++++- 1 file changed, 91 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/intel_sdvo.c +91 -3
@@ -980,6 +980,58 @@ static bool intel_sdvo_write_infoframe(struct intel_sdvo *intel_sdvo, &tx_rate, 1); } +static ssize_t intel_sdvo_read_infoframe (struct intel_sdvo *intel_sdvo, +unsigned int if_index, +u8 *data,unsigned int length) +{ +u8 set_buf_index[2 ] = { if_index,0 }; +u8 hbuf_size, tx_rate, av_split; +int i; + +if (!intel_sdvo_get_value (intel_sdvo, +SDVO_CMD_GET_HBUF_AV_SPLIT , + &av_split,1 )) +return -ENXIO ; + +if (av_split < if_index) +return 0 ; + +if (!intel_sdvo_get_value (intel_sdvo, +SDVO_CMD_GET_HBUF_TXRATE , + &tx_rate,1 )) +return -ENXIO ; + +if (tx_rate ==SDVO_HBUF_TX_DISABLED ) +return 0 ; + +if (!intel_sdvo_set_value (intel_sdvo, +SDVO_CMD_SET_HBUF_INDEX , + set_buf_index,2 )) +return -ENXIO ; + +if (!intel_sdvo_get_value (intel_sdvo,SDVO_CMD_GET_HBUF_INFO , + &hbuf_size,1 )) +return -ENXIO ; + +/* Buffer size is 0 based, hooray! */ + hbuf_size++; + +DRM_DEBUG_KMS ("reading sdvo hbuf: %i, hbuf_size %i, hbuf_size: %i\n" , + if_index, length, hbuf_size); + + hbuf_size = min_t(unsigned int, length, hbuf_size); + +for (i =0 ; i < hbuf_size; i +=8 ) { +if (!intel_sdvo_write_cmd (intel_sdvo,SDVO_CMD_GET_HBUF_DATA ,NULL ,0 )) +return -ENXIO ; +if (!intel_sdvo_read_response (intel_sdvo, &data[i], + min_t(unsigned int, 8, hbuf_size - i))) +return -ENXIO ; + } + +return hbuf_size; +} +static bool intel_sdvo_compute_avi_infoframe (struct intel_sdvo *intel_sdvo,struct intel_crtc_state *crtc_state,struct drm_connector_state *conn_state)
@@ -1038,6 +1090,40 @@ static bool intel_sdvo_set_avi_infoframe(struct intel_sdvo *intel_sdvo, sdvo_data, sizeof(sdvo_data)); } +static void intel_sdvo_get_avi_infoframe (struct intel_sdvo *intel_sdvo, +struct intel_crtc_state *crtc_state) +{ +u8 sdvo_data[HDMI_INFOFRAME_SIZE (AVI )]; +union hdmi_infoframe *frame = &crtc_state->infoframes.avi; +ssize_t len; +int ret; + +if (!crtc_state->has_hdmi_sink) +return ; + + len =intel_sdvo_read_infoframe (intel_sdvo,SDVO_HBUF_INDEX_AVI_IF , + sdvo_data,sizeof (sdvo_data)); +if (len <0 ) { +DRM_DEBUG_KMS ("failed to read AVI infoframe\n" ); +return ; + }else if (len ==0 ) { +return ; + } + + crtc_state->infoframes.enable |= +intel_hdmi_infoframe_enable (HDMI_INFOFRAME_TYPE_AVI ); + + ret =hdmi_infoframe_unpack (frame, sdvo_data,sizeof (sdvo_data)); +if (ret) { +DRM_DEBUG_KMS ("Failed to unpack AVI infoframe\n" ); +return ; + } + +if (frame->any.type !=HDMI_INFOFRAME_TYPE_AVI ) +DRM_DEBUG_KMS ("Found the wrong infoframe type 0x%x (expected 0x%02x)\n" , + frame->any.type,HDMI_INFOFRAME_TYPE_AVI ); +} +static bool intel_sdvo_set_tv_format (struct intel_sdvo *intel_sdvo,const struct drm_connector_state *conn_state) {
@@ -1535,6 +1621,10 @@ static void intel_sdvo_get_config(struct intel_encoder *encoder, } } +WARN (encoder_pixel_multiplier != pipe_config->pixel_multiplier, +"SDVO pixel multiplier mismatch, port: %i, encoder: %i\n" , + pipe_config->pixel_multiplier, encoder_pixel_multiplier); +if (sdvox &HDMI_COLOR_RANGE_16_235 ) pipe_config->limited_color_range = true;
@@ -1547,9 +1637,7 @@ static void intel_sdvo_get_config(struct intel_encoder *encoder, pipe_config->has_hdmi_sink = true; } -WARN (encoder_pixel_multiplier != pipe_config->pixel_multiplier, -"SDVO pixel multiplier mismatch, port: %i, encoder: %i\n" , - pipe_config->pixel_multiplier, encoder_pixel_multiplier); +intel_sdvo_get_avi_infoframe (intel_sdvo, pipe_config); } static void intel_disable_sdvo(struct intel_encoder *encoder,
Signature · 6 lines
2.18.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v2 9/10 drm/i915: Check infoframe state in intel_pipe_config_compare()
In reply to Ville SyrjalaFrom: Ville Syrjälä <[email protected]>
Check the infoframes and infoframe enable state when comparing two crtc states.
We'll use the infoframe logging functions from video/hdmi.c to show the infoframes as part of the state dump.
TODO: Try to better integrate the infoframe dumps with
drm state dumps
v2: drm_printk() is no more
--- drivers/gpu/drm/i915/intel_display.c | 49 +++++++++++++++++++++++++++- 1 file changed, 48 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_display.c +48 -1
@@ -11622,6 +11622,37 @@ intel_compare_link_m_n(const struct intel_link_m_n *m_n,return false; } +static bool +intel_compare_infoframe (const union hdmi_infoframe *a, +const union hdmi_infoframe *b) +{ +return memcmp (a, b,sizeof (*a)) ==0 ; +} + +static void +pipe_config_infoframe_err (struct drm_i915_private *dev_priv, +bool adjust,const char *name, +const union hdmi_infoframe *a, +const union hdmi_infoframe *b) +{ +if (adjust) { +if ((drm_debug &DRM_UT_KMS ) ==0 ) +return ; + +drm_dbg (DRM_UT_KMS ,"mismatch in %s infoframe" , name); +drm_dbg (DRM_UT_KMS ,"expected:" ); +hdmi_infoframe_log (KERN_DEBUG , dev_priv->drm.dev, a); +drm_dbg (DRM_UT_KMS ,"found" ); +hdmi_infoframe_log (KERN_DEBUG , dev_priv->drm.dev, b); + }else { +drm_err ("mismatch in %s infoframe" , name); +drm_err ("expected:" ); +hdmi_infoframe_log (KERN_ERR , dev_priv->drm.dev, a); +drm_err ("found" ); +hdmi_infoframe_log (KERN_ERR , dev_priv->drm.dev, b); + } +} + static void __printf(3, 4) pipe_config_err(bool adjust, const char *name, const char *format, ...) {
@@ -11783,7 +11814,17 @@ intel_pipe_config_compare(struct drm_i915_private *dev_priv, } \ } while (0) -#define PIPE_CONF_QUIRK (quirk) \ +#define PIPE_CONF_CHECK_INFOFRAME (name) do { \ + if (!intel_compare_infoframe(¤t_config->infoframes.name, \ + &pipe_config->infoframes.name)) { \ + pipe_config_infoframe_err(dev_priv, adjust, __stringify(name), \ + ¤t_config->infoframes.name, \ + &pipe_config->infoframes.name); \ + ret = false; \ + } \ +} while (0) + +#define PIPE_CONF_QUIRK (quirk) \ ((current_config->quirks | pipe_config->quirks) & (quirk))PIPE_CONF_CHECK_I (cpu_transcoder);
@@ -11912,6 +11953,12 @@ intel_pipe_config_compare(struct drm_i915_private *dev_priv,PIPE_CONF_CHECK_I (min_voltage_level); +PIPE_CONF_CHECK_X (infoframes.enable); +PIPE_CONF_CHECK_X (infoframes.gcp); +PIPE_CONF_CHECK_INFOFRAME (avi); +PIPE_CONF_CHECK_INFOFRAME (spd); +PIPE_CONF_CHECK_INFOFRAME (hdmi); +#undef PIPE_CONF_CHECK_X#undef PIPE_CONF_CHECK_I#undef PIPE_CONF_CHECK_BOOL
Signature · 6 lines
2.18.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v2 10/10 drm/i915: Include infoframes in the crtc state dump
In reply to Ville SyrjalaFrom: Ville Syrjälä <[email protected]>
Dump out the infoframes in the normal crtc state dump.
TODO: Try to better integrate the infoframe dumps with
drm state dumps
--- drivers/gpu/drm/i915/intel_display.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+)
drivers/gpu/drm/i915/intel_display.c +26 -0
@@ -11151,6 +11151,16 @@ intel_dump_m_n_config(struct intel_crtc_state *pipe_config, char *id, m_n->link_m, m_n->link_n, m_n->tu); } +static void +intel_dump_infoframe (struct drm_i915_private *dev_priv, +const union hdmi_infoframe *frame) +{ +if ((drm_debug &DRM_UT_KMS ) ==0 ) +return ; + +hdmi_infoframe_log (KERN_DEBUG , dev_priv->drm.dev, frame); +} +#define OUTPUT_TYPE (x) [INTEL_OUTPUT_ ## x] = #xstatic const char *const output_type_str[] = {
@@ -11254,6 +11264,22 @@ static void intel_dump_pipe_config(struct intel_crtc *crtc,DRM_DEBUG_KMS ("audio: %i, infoframes: %i\n" , pipe_config->has_audio, pipe_config->has_infoframe); +DRM_DEBUG_KMS ("infoframes enabled: 0x%x\n" , + pipe_config->infoframes.enable); + +if (pipe_config->infoframes.enable & +intel_hdmi_infoframe_enable (HDMI_PACKET_TYPE_GENERAL_CONTROL )) +DRM_DEBUG_KMS ("GCP: 0x%x\n" , pipe_config->infoframes.gcp); +if (pipe_config->infoframes.enable & +intel_hdmi_infoframe_enable (HDMI_INFOFRAME_TYPE_AVI )) +intel_dump_infoframe (dev_priv, &pipe_config->infoframes.avi); +if (pipe_config->infoframes.enable & +intel_hdmi_infoframe_enable (HDMI_INFOFRAME_TYPE_SPD )) +intel_dump_infoframe (dev_priv, &pipe_config->infoframes.spd); +if (pipe_config->infoframes.enable & +intel_hdmi_infoframe_enable (HDMI_INFOFRAME_TYPE_VENDOR )) +intel_dump_infoframe (dev_priv, &pipe_config->infoframes.hdmi); +DRM_DEBUG_KMS ("requested mode:\n" );drm_mode_debug_printmodeline (&pipe_config->base.mode);DRM_DEBUG_KMS ("adjusted mode:\n" );
Signature · 6 lines
2.18.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.CHECKPATCH: warning for drm/i915: Infoframe precompute/check (rev5)
In reply to Ville Syrjala== Series Details ==
== Series Details ==
Series: drm/i915: Infoframe precompute/check (rev5)
URL : https://patchwork.freedesktop.org/series/49983/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip cfd286f0f4dd video/hdmi: Add an enum for HDMI packet types b564529095d2 drm/i915: Add the missing HDMI gamut metadata packet stuff -:45: WARNING:LONG_LINE: line over 100 characters #45: FILE: drivers/gpu/drm/i915/i915_reg.h:8073: +#define HSW_TVIDEO_DIP_GMP_DATA(trans, i) _MMIO_TRANS2(trans, _HSW_VIDEO_DIP_GMP_DATA_A + (i) * 4)
total: 0 errors, 1 warnings, 0 checks, 64 lines checked0388b3f88670 drm/i915: Return the mask of enabled infoframes from ->inforame_enabled() 21e99b988d4b drm/i915: Store mask of enabled infoframes in the crtc state 1e943761a83b drm/i915: Precompute HDMI infoframes3c9ac5ca0653 drm/i915: Read out HDMI infoframes8eb49e16ada8 drm/i915/sdvo: Precompute HDMI infoframes9ba1218218fc drm/i915/sdvo: Read out HDMI infoframes2178cf732b2f drm/i915: Check infoframe state in intel_pipe_config_compare() -:71: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'name' - possible side-effects? #71: FILE: drivers/gpu/drm/i915/intel_display.c:11817:
+#define PIPE_CONF_CHECK_INFOFRAME(name) do { \
+ if (!intel_compare_infoframe(¤t_config->infoframes.name, \
+ &pipe_config->infoframes.name)) { \
+ pipe_config_infoframe_err(dev_priv, adjust, __stringify(name), \
+ ¤t_config->infoframes.name, \
+ &pipe_config->infoframes.name); \
+ ret = false; \
+ } \
+} while (0)
total: 0 errors, 0 warnings, 1 checks, 67 lines checked 45b13e708452 drm/i915: Include infoframes in the crtc state dump
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.SPARSE: warning for drm/i915: Infoframe precompute/check (rev5)
In reply to Ville Syrjala== Series Details ==
== Series Details ==
Series: drm/i915: Infoframe precompute/check (rev5)
URL : https://patchwork.freedesktop.org/series/49983/
State : warning
== Summary ==
$ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: video/hdmi: Add an enum for HDMI packet types Okay!
Commit: drm/i915: Add the missing HDMI gamut metadata packet stuff Okay!
Commit: drm/i915: Return the mask of enabled infoframes from ->inforame_enabled() Okay!
Commit: drm/i915: Store mask of enabled infoframes in the crtc state Okay!
Commit: drm/i915: Precompute HDMI infoframes
Okay!
Commit: drm/i915: Read out HDMI infoframes
Okay!
Commit: drm/i915/sdvo: Precompute HDMI infoframes
Okay!
Commit: drm/i915/sdvo: Read out HDMI infoframes +drivers/gpu/drm/i915/intel_sdvo.c:1022:21: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_sdvo.c:1022:21: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_sdvo.c:1028:47: warning: expression using sizeof(void)
Commit: drm/i915: Check infoframe state in intel_pipe_config_compare() Okay!
Commit: drm/i915: Include infoframes in the crtc state dump Okay!
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.BAT: failure for drm/i915: Infoframe precompute/check (rev5)
In reply to Ville Syrjala== Series Details ==
== Series Details ==
Series: drm/i915: Infoframe precompute/check (rev5)
URL : https://patchwork.freedesktop.org/series/49983/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_5324 -> Patchwork_11109
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_11109 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_11109, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/49983/revisions/5/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_11109:
### IGT changes ###
#### Possible regressions ####
* igt@pm_rpm@basic-rte:
- fi-bsw-kefka: PASS -> FAIL
#### Warnings ####
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
- fi-ivb-3770: PASS -> SKIP +1
* igt@pm_rpm@basic-pci-d3-state:
- fi-bsw-kefka: PASS -> SKIP
Known issues
------------
Here are the changes found in Patchwork_11109 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live_hangcheck:
- fi-kbl-7560u: PASS -> INCOMPLETE [fdo#108044]
* igt@kms_busy@basic-flip-b:
- fi-gdg-551: PASS -> FAIL [fdo#103182]
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362]
* {igt@runner@aborted}:
- fi-cfl-8109u: NOTRUN -> FAIL [k.org#201919]
#### Possible fixes ####
* igt@i915_module_load@reload:
- fi-blb-e6850: INCOMPLETE [fdo#107718] -> PASS
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: FAIL [fdo#108767] -> PASS
* igt@kms_flip@basic-flip-vs-dpms:
- fi-icl-u3: DMESG-WARN [fdo#108924] / [fdo#109044] -> PASS
- fi-skl-6700hq: DMESG-WARN [fdo#105998] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#105998]: https://bugs.freedesktop.org/show_bug.cgi?id=105998
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108044]: https://bugs.freedesktop.org/show_bug.cgi?id=108044
[fdo#108767]: https://bugs.freedesktop.org/show_bug.cgi?id=108767
[fdo#108924]: https://bugs.freedesktop.org/show_bug.cgi?id=108924
[fdo#109044]: https://bugs.freedesktop.org/show_bug.cgi?id=109044
[k.org#201919]: https://bugzilla.kernel.org/show_bug.cgi?id=201919
Participating hosts (49 -> 45)
------------------------------
Additional (1): fi-cfl-8109u
Missing (5): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-kbl-r
Build changes
-------------
* Linux: CI_DRM_5324 -> Patchwork_11109
CI_DRM_5324: 93009153b9bde1d65ca49bb1729cd1111591144b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4748: 90c76cb9bb47a5a3ebb34ad6b1a557bc02d39713 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_11109: 45b13e70845299f40c5d8f4e04dfa31dfbf52dca @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
45b13e708452 drm/i915: Include infoframes in the crtc state dump 2178cf732b2f drm/i915: Check infoframe state in intel_pipe_config_compare() 9ba1218218fc drm/i915/sdvo: Read out HDMI infoframes8eb49e16ada8 drm/i915/sdvo: Precompute HDMI infoframes3c9ac5ca0653 drm/i915: Read out HDMI infoframes1e943761a83b drm/i915: Precompute HDMI infoframes21e99b988d4b drm/i915: Store mask of enabled infoframes in the crtc state 0388b3f88670 drm/i915: Return the mask of enabled infoframes from ->inforame_enabled() b564529095d2 drm/i915: Add the missing HDMI gamut metadata packet stuff cfd286f0f4dd video/hdmi: Add an enum for HDMI packet types
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_11109/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Hi,
Quoted 9 lines · Ville Syrjala
From: Ville Syrjälä <[email protected]>
Remainder of the infoframe precompute/check work. Review comments addressesed, and I added a bunch of FIXMEs for lspcon. Note that the lack of proper implementation for lspcon shouldn't matter since we don't do the precompute/readout/check for DP encoders atm.
Entire series is available here:
git://github.com/vsyrjala/linux.gitinfoframe_precompute_5
Thank you for getting v2 of this out there.
Regards,
Hans
Quoted 14 lines
Ville Syrjälä (10):
video/hdmi: Add an enum for HDMI packet types drm/i915: Add the missing HDMI gamut metadata packet stuff drm/i915: Return the mask of enabled infoframes from->inforame_enabled()drm/i915: Store mask of enabled infoframes in the crtc state drm/i915: Precompute HDMI infoframes
drm/i915: Read out HDMI infoframes
drm/i915/sdvo: Precompute HDMI infoframes drm/i915/sdvo: Read out HDMI infoframes
drm/i915: Check infoframe state inintel_pipe_config_compare()drm/i915: Include infoframes in the crtc state dump
Quoted 10 lines
drivers/gpu/drm/i915/i915_reg.h | 8 +- drivers/gpu/drm/i915/intel_ddi.c | 17 +- drivers/gpu/drm/i915/intel_display.c | 75 +++- drivers/gpu/drm/i915/intel_drv.h | 29 +- drivers/gpu/drm/i915/intel_hdmi.c | 516 ++++++++++++++++++++++----- drivers/gpu/drm/i915/intel_lspcon.c | 13 +- drivers/gpu/drm/i915/intel_sdvo.c | 152 +++++++- include/linux/hdmi.h | 15 + 8 files changed, 706 insertions(+), 119 deletions(-)
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915: Infoframe precompute/check (rev5)
In reply to Ville Syrjala== Series Details ==
== Series Details ==
Series: drm/i915: Infoframe precompute/check (rev5)
URL : https://patchwork.freedesktop.org/series/49983/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5324 -> Patchwork_11109
====================================================
Summary
-------
**WARNING**
Minor unknown changes coming with Patchwork_11109 need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_11109, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/49983/revisions/5/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_11109:
### IGT changes ###
#### Warnings ####
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
- fi-ivb-3770: PASS -> SKIP +1
* igt@pm_rpm@basic-pci-d3-state:
- fi-bsw-kefka: PASS -> SKIP
Known issues
------------
Here are the changes found in Patchwork_11109 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live_hangcheck:
- fi-kbl-7560u: PASS -> INCOMPLETE [fdo#108044]
* igt@kms_busy@basic-flip-b:
- fi-gdg-551: PASS -> FAIL [fdo#103182]
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362]
* igt@pm_rpm@basic-rte:
- fi-bsw-kefka: PASS -> FAIL [fdo#108800]
* {igt@runner@aborted}:
- fi-cfl-8109u: NOTRUN -> FAIL [k.org#201919]
#### Possible fixes ####
* igt@i915_module_load@reload:
- fi-blb-e6850: INCOMPLETE [fdo#107718] -> PASS
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: FAIL [fdo#108767] -> PASS
* igt@kms_flip@basic-flip-vs-dpms:
- fi-icl-u3: DMESG-WARN [fdo#108924] / [fdo#109044] -> PASS
- fi-skl-6700hq: DMESG-WARN [fdo#105998] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#105998]: https://bugs.freedesktop.org/show_bug.cgi?id=105998
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108044]: https://bugs.freedesktop.org/show_bug.cgi?id=108044
[fdo#108767]: https://bugs.freedesktop.org/show_bug.cgi?id=108767
[fdo#108800]: https://bugs.freedesktop.org/show_bug.cgi?id=108800
[fdo#108924]: https://bugs.freedesktop.org/show_bug.cgi?id=108924
[fdo#109044]: https://bugs.freedesktop.org/show_bug.cgi?id=109044
[k.org#201919]: https://bugzilla.kernel.org/show_bug.cgi?id=201919
Participating hosts (49 -> 45)
------------------------------
Additional (1): fi-cfl-8109u
Missing (5): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-kbl-r
Build changes
-------------
* Linux: CI_DRM_5324 -> Patchwork_11109
CI_DRM_5324: 93009153b9bde1d65ca49bb1729cd1111591144b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4748: 90c76cb9bb47a5a3ebb34ad6b1a557bc02d39713 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_11109: 45b13e70845299f40c5d8f4e04dfa31dfbf52dca @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
45b13e708452 drm/i915: Include infoframes in the crtc state dump 2178cf732b2f drm/i915: Check infoframe state in intel_pipe_config_compare() 9ba1218218fc drm/i915/sdvo: Read out HDMI infoframes8eb49e16ada8 drm/i915/sdvo: Precompute HDMI infoframes3c9ac5ca0653 drm/i915: Read out HDMI infoframes1e943761a83b drm/i915: Precompute HDMI infoframes21e99b988d4b drm/i915: Store mask of enabled infoframes in the crtc state 0388b3f88670 drm/i915: Return the mask of enabled infoframes from ->inforame_enabled() b564529095d2 drm/i915: Add the missing HDMI gamut metadata packet stuff cfd286f0f4dd video/hdmi: Add an enum for HDMI packet types
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_11109/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for drm/i915: Infoframe precompute/check (rev5)
In reply to Ville Syrjala== Series Details ==
== Series Details ==
Series: drm/i915: Infoframe precompute/check (rev5)
URL : https://patchwork.freedesktop.org/series/49983/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5324_full -> Patchwork_11109_full
====================================================
Summary
-------
**WARNING**
Minor unknown changes coming with Patchwork_11109_full need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_11109_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_11109_full:
### IGT changes ###
#### Warnings ####
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
- shard-snb: SKIP -> PASS
* igt@pm_rc6_residency@rc6-accuracy:
- shard-kbl: SKIP -> PASS
Known issues
------------
Here are the changes found in Patchwork_11109_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_schedule@pi-ringfull-vebox:
- shard-skl: NOTRUN -> FAIL [fdo#103158]
* igt@kms_addfb_basic@basic:
- shard-apl: PASS -> INCOMPLETE [fdo#103927]
* igt@kms_available_modes_crc@available_mode_test_crc:
- shard-apl: PASS -> FAIL [fdo#106641]
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
- shard-skl: NOTRUN -> DMESG-WARN [fdo#107956]
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b:
- shard-glk: PASS -> DMESG-WARN [fdo#107956]
* igt@kms_color@pipe-a-legacy-gamma:
- shard-apl: PASS -> FAIL [fdo#104782] / [fdo#108145]
* igt@kms_cursor_crc@cursor-256x256-random:
- shard-glk: PASS -> FAIL [fdo#103232]
* igt@kms_cursor_crc@cursor-256x85-random:
- shard-apl: PASS -> FAIL [fdo#103232] +4
* igt@kms_fbcon_fbt@psr:
- shard-skl: NOTRUN -> FAIL [fdo#107882]
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
- shard-glk: PASS -> FAIL [fdo#105363]
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-skl: PASS -> FAIL [fdo#105363]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
- shard-apl: NOTRUN -> FAIL [fdo#103167]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen:
- shard-glk: PASS -> FAIL [fdo#103167] +4
- shard-apl: PASS -> FAIL [fdo#103167] +3
* igt@kms_frontbuffer_tracking@fbc-stridechange:
- shard-iclb: PASS -> FAIL [fdo#105683] / [fdo#108040]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- shard-skl: PASS -> INCOMPLETE [fdo#104108] / [fdo#107773]
* igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
- shard-skl: NOTRUN -> DMESG-WARN [fdo#106885]
* igt@kms_plane@plane-position-covered-pipe-b-planes:
- shard-glk: PASS -> FAIL [fdo#103166] +3
* igt@kms_plane@plane-position-covered-pipe-c-planes:
- shard-apl: PASS -> FAIL [fdo#103166] +1
* igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
- shard-skl: NOTRUN -> FAIL [fdo#108145] +1
* igt@kms_plane_multiple@atomic-pipe-b-tiling-yf:
- shard-iclb: PASS -> FAIL [fdo#103166]
* igt@kms_plane_scaling@pipe-b-scaler-with-pixel-format:
- shard-iclb: PASS -> DMESG-WARN [fdo#107724] +1
* igt@kms_psr@no_drrs:
- shard-iclb: PASS -> FAIL [fdo#108341]
* igt@kms_setmode@basic:
- shard-skl: NOTRUN -> FAIL [fdo#99912]
- shard-hsw: PASS -> FAIL [fdo#99912]
- shard-kbl: PASS -> FAIL [fdo#99912] * igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend:
- shard-iclb: PASS -> INCOMPLETE [fdo#107713]
* igt@pm_rpm@gem-mmap-cpu:
- shard-iclb: PASS -> INCOMPLETE [fdo#108840]
* igt@pm_rpm@modeset-stress-extra-wait:
- shard-skl: PASS -> INCOMPLETE [fdo#107807]
* igt@pm_rpm@pm-caching:
- shard-skl: NOTRUN -> INCOMPLETE [fdo#107807]
* igt@pm_rpm@system-suspend:
- shard-skl: PASS -> INCOMPLETE [fdo#104108] / [fdo#107807]
* igt@pm_rpm@universal-planes:
- shard-iclb: PASS -> DMESG-WARN [fdo#108654] / [fdo#108756]
#### Possible fixes ####
* igt@gem_eio@in-flight-suspend:
- shard-skl: INCOMPLETE [fdo#104108] / [fdo#107773] -> PASS
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b:
- shard-apl: DMESG-WARN [fdo#107956] -> PASS
* igt@kms_cursor_crc@cursor-128x128-onscreen:
- shard-apl: FAIL [fdo#103232] -> PASS +1
* igt@kms_cursor_crc@cursor-128x42-onscreen:
- shard-skl: FAIL [fdo#103232] -> PASS +1
* igt@kms_cursor_crc@cursor-256x256-suspend:
- shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS
* igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size:
- shard-iclb: FAIL [fdo#103355] -> PASS
* igt@kms_draw_crc@draw-method-xrgb8888-mmap-cpu-untiled:
- shard-skl: FAIL [fdo#108472] -> PASS
* igt@kms_flip@plain-flip-fb-recreate:
- shard-apl: INCOMPLETE [fdo#103927] -> PASS
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-blt:
- shard-glk: FAIL [fdo#103167] -> PASS +1
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-mmap-wc:
- shard-iclb: FAIL [fdo#103167] -> PASS +5
* igt@kms_frontbuffer_tracking@fbcpsr-stridechange:
- shard-iclb: FAIL [fdo#105683] -> PASS
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-c:
- shard-apl: DMESG-WARN [fdo#103558] / [fdo#105602] -> PASS +20
* igt@kms_pipe_crc_basic@read-crc-pipe-c:
- shard-skl: FAIL [fdo#107362] -> PASS
* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-glk: FAIL [fdo#108145] -> PASS
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: FAIL [fdo#107815] -> PASS
* igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
- shard-glk: FAIL [fdo#103166] -> PASS +2
* igt@kms_plane_multiple@atomic-pipe-b-tiling-yf:
- shard-apl: DMESG-FAIL [fdo#103166] / [fdo#103558] / [fdo#105602] -> PASS
* igt@kms_plane_multiple@atomic-pipe-c-tiling-x:
- shard-iclb: FAIL [fdo#103166] -> PASS +2
* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-iclb: DMESG-FAIL [fdo#107724] -> PASS
* igt@pm_rpm@basic-rte:
- shard-iclb: DMESG-WARN [fdo#108654] -> PASS
* igt@pm_rpm@modeset-lpsp-stress:
- shard-skl: INCOMPLETE [fdo#107807] -> PASS
- shard-iclb: DMESG-WARN [fdo#107724] -> PASS +1
#### Warnings ####
* igt@i915_selftest@live_contexts:
- shard-iclb: DMESG-FAIL [fdo#108569] -> INCOMPLETE [fdo#108315]
* igt@i915_suspend@shrink:
- shard-skl: INCOMPLETE [fdo#106886] -> DMESG-WARN [fdo#108784]
- shard-glk: DMESG-WARN [fdo#108784] -> INCOMPLETE [fdo#103359] / [fdo#106886] / [k.org#198133]
* {igt@runner@aborted}:
- shard-iclb: FAIL [fdo#108654] / [fdo#108756] -> ( 2 FAIL ) [fdo#108654] / [fdo#108756] / [fdo#108866]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103158]: https://bugs.freedesktop.org/show_bug.cgi?id=103158
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#105683]: https://bugs.freedesktop.org/show_bug.cgi?id=105683
[fdo#106641]: https://bugs.freedesktop.org/show_bug.cgi?id=106641
[fdo#106885]: https://bugs.freedesktop.org/show_bug.cgi?id=106885
[fdo#106886]: https://bugs.freedesktop.org/show_bug.cgi?id=106886
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#107773]: https://bugs.freedesktop.org/show_bug.cgi?id=107773
[fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
[fdo#107815]: https://bugs.freedesktop.org/show_bug.cgi?id=107815
[fdo#107882]: https://bugs.freedesktop.org/show_bug.cgi?id=107882
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108040]: https://bugs.freedesktop.org/show_bug.cgi?id=108040
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108315]: https://bugs.freedesktop.org/show_bug.cgi?id=108315
[fdo#108341]: https://bugs.freedesktop.org/show_bug.cgi?id=108341
[fdo#108472]: https://bugs.freedesktop.org/show_bug.cgi?id=108472
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#108654]: https://bugs.freedesktop.org/show_bug.cgi?id=108654
[fdo#108756]: https://bugs.freedesktop.org/show_bug.cgi?id=108756
[fdo#108784]: https://bugs.freedesktop.org/show_bug.cgi?id=108784
[fdo#108840]: https://bugs.freedesktop.org/show_bug.cgi?id=108840
[fdo#108866]: https://bugs.freedesktop.org/show_bug.cgi?id=108866
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (7 -> 7)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_5324 -> Patchwork_11109
CI_DRM_5324: 93009153b9bde1d65ca49bb1729cd1111591144b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4748: 90c76cb9bb47a5a3ebb34ad6b1a557bc02d39713 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_11109: 45b13e70845299f40c5d8f4e04dfa31dfbf52dca @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_11109/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx