Skip to contentSkip to conversation

gtk3: enable wayland banckend

PATCH In review Jed 3 participants 4 messages Dec 17, 2018

lore
Share & tools
lore

Jed

author
#0 lore raw

PATCH 1/1 gtk3: enable wayland banckend

It is disabled by default, and required for things like mutter to be able to run under Wayland.

---
 meta/recipes-gnome/gtk+/gtk+3.inc | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-gnome/gtk+/gtk+3.inc +1 -0
index 6331a4323c..83967ccb7e 100644
@@ -35,6 +35,7 @@ EXTRA_OECONF += " \
                  --enable-modules \
                  --disable-cups \
                  --disable-colord \
+                 --enable-wayland-backend \
                  ${@bb.utils.contains("DISTRO_FEATURES", "x11", "", "--disable-gtk-doc", d)} \
                  "
 
Signature · 1 line
2.11.0
#1 lore raw
Quoted 17 lines · Jed

It is disabled by default, and required for things like mutter to be able to run under Wayland.

---
meta/recipes-gnome/gtk+/gtk+3.inc | 1 +

1 file changed, 1 insertion(+)
meta/recipes-gnome/gtk+/gtk+3.inc +0 -0
index 6331a4323c..83967ccb7e 100644

meta/recipes-gnome/gtk+/gtk+3.inc EXTRA_OECONF += " \ · line 38

Quoted 4 lines
meta/recipes-gnome/gtk+/gtk+3.inc +1 -0
@@ -35,6 +35,7 @@ EXTRA_OECONF += " \
                 --enable-modules \
                 --disable-cups \
                 --disable-colord \
+                 --enable-wayland-backend \

Wouldn’t it be better to check that DISTRO_FEATURES contains wayland and then enable it?

Quoted 11 lines
meta/recipes-gnome/gtk+/gtk+3.inc +0 -0
                 ${@bb.utils.contains("DISTRO_FEATURES", "x11", "", "--disable-gtk-doc", d)} \
                 "
 
Signature · 7 lines
2.11.0

-- 
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
#2 lore raw
In reply to Jed
Quoted 2 lines · Jed

It is disabled by default, and required for things like mutter to be able to run under Wayland.

From the recipe:

PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'opengl wayland x11', d)} \
${@bb.utils.contains('DISTRO_FEATURES', 'opengl x11', 'glx', '', d)}"

PACKAGECONFIG[wayland] = "--enable-wayland-backend,--disable-wayland-backend,wayland wayland-protocols libxkbcommon virtual/mesa wayland-native"

It's enabled if the 'wayland' DISTRO_FEATURE is enabled.

Ross

#3 lore raw

My bad, sorry.
For some reason things started working after I added that option (I already had the DISTRO_FEATURE), but it must have been something else. Thank you for reviewing.

Jed

Quoted 18 lines · Ross
Quoted 2 lines · Jed

It is disabled by default, and required for things like mutter to be able to run under Wayland.

From the recipe:

PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'opengl wayland x11', d)} \
${@bb.utils.contains('DISTRO_FEATURES', 'opengl x11', 'glx', '', d)}"

PACKAGECONFIG[wayland] = "--enable-wayland-backend,--disable-wayland-backend,wayland wayland-protocols libxkbcommon virtual/mesa wayland-native"

It's enabled if the 'wayland' DISTRO_FEATURE is enabled.

Ross