Skip to contentSkip to conversation

kexec-tools-klibc: fix build for mipsel

PATCH In review Andrea Adami 2 participants 5 messages Dec 17, 2018

lore
Share & tools
lore

Andrea Adami

author
#0 lore raw

PATCH 1/1 kexec-tools-klibc: fix build for mipsel

Fix:
printf.c:2:10: fatal error: limits.h: No such file or directory | #include <limits.h>

Signed-off-by Andrea Adami <[email protected]>
---
 meta-initramfs/recipes-kernel/kexec/kexec-tools-klibc_git.bb | 1 +
 1 file changed, 1 insertion(+)
meta-initramfs/recipes-kernel/kexec/kexec-tools-klibc_git.bb +1 -0
index e7553244d..872d79b93 100644
@@ -66,6 +66,7 @@ CFLAGS_x86-64_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/i
 CFLAGS_arm_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits32"
 CFLAGS_aarch64_append = "${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits64"
 CFLAGS_mips_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits32"
+CFLAGS_mipsel_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits32"
 CFLAGS_mips64_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits64"
 CFLAGS_powerpc_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits32"
Signature · 1 line
2.17.1
#1 lore raw
Quoted 15 lines · Andrea Adami

Fix:
printf.c:2:10: fatal error: limits.h: No such file or directory | #include <limits.h>

Signed-off-by Andrea Adami <[email protected]>
---
 meta-initramfs/recipes-kernel/kexec/kexec-tools-klibc_git.bb | 1 +
 1 file changed, 1 insertion(+)
meta-initramfs/recipes-kernel/kexec/kexec-tools-klibc_git.bb +0 -0
index e7553244d..872d79b93 100644

meta-initramfs/recipes-kernel/kexec/kexec-tools-klibc_git.bb CFLAGS_x86-64_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/i · line 70

Quoted 5 lines
meta-initramfs/recipes-kernel/kexec/kexec-tools-klibc_git.bb +1 -0
@@ -66,6 +66,7 @@ CFLAGS_x86-64_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/i
 CFLAGS_arm_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits32"
 CFLAGS_aarch64_append = "${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits64"
 CFLAGS_mips_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits32"
+CFLAGS_mipsel_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits32"
 CFLAGS_mips64_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits64"

I wonder if we just use use "mipsarch" override here once for all mips kinds.

Quoted 10 lines
meta-initramfs/recipes-kernel/kexec/kexec-tools-klibc_git.bb +0 -1
 CFLAGS_powerpc_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits32"
 
--

2.17.1

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

author
#2 lore raw
Quoted 12 lines · Khem Raj
Quoted 10 lines · Andrea Adami

Fix:
printf.c:2:10: fatal error: limits.h: No such file or directory | #include <limits.h>

Signed-off-by Andrea Adami <[email protected]>
---
 meta-initramfs/recipes-kernel/kexec/kexec-tools-klibc_git.bb | 1 +
 1 file changed, 1 insertion(+)
Quoted 16 lines

meta-initramfs/recipes-kernel/kexec/kexec-tools-klibc_git.bb CFLAGS_x86-64_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/i · line 70

Quoted 10 lines
meta-initramfs/recipes-kernel/kexec/kexec-tools-klibc_git.bb +1 -0
index e7553244d..872d79b93 100644
@@ -66,6 +66,7 @@ CFLAGS_x86-64_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/i
 CFLAGS_arm_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits32"
 CFLAGS_aarch64_append = "${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits64"
 CFLAGS_mips_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits32"
+CFLAGS_mipsel_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits32"
 CFLAGS_mips64_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits64"

I wonder if we just use use "mipsarch" override here once for all mips kinds.

Quoted 2 lines
meta-initramfs/recipes-kernel/kexec/kexec-tools-klibc_git.bb +0 -0
 CFLAGS_powerpc_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits32"

I am also wondering how to do that in another way. Maybe a patch to adjust the included headers?

Cheers
Andrea

Quoted 8 lines
Quoted 8 lines

--
2.17.1

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

author
#3 lore raw
Quoted 14 lines · Andrea Adami
Quoted 12 lines · Khem Raj
Quoted 10 lines · Andrea Adami

Fix:
printf.c:2:10: fatal error: limits.h: No such file or directory | #include <limits.h>

Signed-off-by Andrea Adami <[email protected]>
---
 meta-initramfs/recipes-kernel/kexec/kexec-tools-klibc_git.bb | 1 +
 1 file changed, 1 insertion(+)
Quoted 13 lines
Quoted 5 lines
Quoted 5 lines
meta-initramfs/recipes-kernel/kexec/kexec-tools-klibc_git.bb +0 -0
index e7553244d..872d79b93 100644
@@ -66,6 +66,7 @@ CFLAGS_x86-64_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/i
Quoted 8 lines

meta-initramfs/recipes-kernel/kexec/kexec-tools-klibc_git.bb CFLAGS_x86-64_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/i · line 70

Quoted 5 lines
meta-initramfs/recipes-kernel/kexec/kexec-tools-klibc_git.bb +1 -0
 CFLAGS_arm_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits32"
 CFLAGS_aarch64_append = "${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits64"
 CFLAGS_mips_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits32"
+CFLAGS_mipsel_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits32"
 CFLAGS_mips64_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits64"

I wonder if we just use use "mipsarch" override here once for all mips kinds.

Note that there are different bitsizes...
Please merge this, we'll think how to refactor this later. Cheers

Andrea
P.S. Unfortunately my poor 3.13.5 bcm-tainted drivers do not survive to kexec. Will retry with a recent bmips for bcm7425

Quoted 17 lines
Quoted 3 lines

meta-initramfs/recipes-kernel/kexec/kexec-tools-klibc_git.bb CFLAGS_x86-64_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/i · line 72

Quoted 3 lines
meta-initramfs/recipes-kernel/kexec/kexec-tools-klibc_git.bb +0 -0
 CFLAGS_powerpc_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits32"

I am also wondering how to do that in another way. Maybe a patch to adjust the included headers?

Cheers
Andrea

Quoted 8 lines
Quoted 8 lines

--
2.17.1

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

author
#4 lore raw
Quoted 30 lines · Andrea Adami
Quoted 14 lines · Andrea Adami
Quoted 12 lines · Khem Raj
Quoted 10 lines · Andrea Adami

Fix:
printf.c:2:10: fatal error: limits.h: No such file or directory | #include <limits.h>

Signed-off-by Andrea Adami <[email protected]>
---
 meta-initramfs/recipes-kernel/kexec/kexec-tools-klibc_git.bb | 1 +
 1 file changed, 1 insertion(+)
Quoted 13 lines
Quoted 5 lines
Quoted 5 lines
meta-initramfs/recipes-kernel/kexec/kexec-tools-klibc_git.bb +0 -0
index e7553244d..872d79b93 100644
@@ -66,6 +66,7 @@ CFLAGS_x86-64_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/i
Quoted 8 lines

meta-initramfs/recipes-kernel/kexec/kexec-tools-klibc_git.bb CFLAGS_x86-64_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/i · line 70

Quoted 5 lines
meta-initramfs/recipes-kernel/kexec/kexec-tools-klibc_git.bb +1 -0
 CFLAGS_arm_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits32"
 CFLAGS_aarch64_append = "${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits64"
 CFLAGS_mips_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits32"
+CFLAGS_mipsel_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits32"
 CFLAGS_mips64_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits64"

I wonder if we just use use "mipsarch" override here once for all mips kinds.

Quoted 4 lines

Note that there are different bitsizes...
Please merge this, we'll think how to refactor this later. Cheers

ehm.. sorry for the noise, my git repo exploded... This patch is already merged in master-next: archived as not-applicable (anymore).

Cheers
Andrea

Quoted 22 lines

Andrea
P.S. Unfortunately my poor 3.13.5 bcm-tainted drivers do not survive to kexec. Will retry with a recent bmips for bcm7425

Quoted 17 lines
Quoted 3 lines

meta-initramfs/recipes-kernel/kexec/kexec-tools-klibc_git.bb CFLAGS_x86-64_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/i · line 72

Quoted 3 lines
meta-initramfs/recipes-kernel/kexec/kexec-tools-klibc_git.bb +0 -0
 CFLAGS_powerpc_append = " ${COMMON_CFLAGS} -I${STAGING_DIR_HOST}${libdir}/klibc/include/bits32"

I am also wondering how to do that in another way. Maybe a patch to adjust the included headers?

Cheers
Andrea

Quoted 8 lines
Quoted 8 lines

--
2.17.1

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel