Skip to contentSkip to conversation

Rename ax25-ae350 defconfig

PATCH Superseded Andes 3 participants 9 messages Dec 18, 2018

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Andes

author
#0 lore raw

v3 cover Rename ax25-ae350 defconfig

From: Rick Chen <[email protected]>

Remove cpu name from the defconfig naming.
Because other cpus maybe run on AE350 platform.
So only use platfrom name in defconfig naming
will be better.

Changes since v2:
- Fix travis failure case 6.51 Checkfor configs without MAINTAINERS entry.
https://travis-ci.org/rickchen36/u-boot-riscv/builds/468881778
So add this two patchs:
MAINTAINERS: Sync for ax25-ae350 rename
doc: README.ae350: Sync for ax25-ae350 rename

Changes since v1:
- Use git mv and git format-patch -M to show delta when rename.

Rick Chen (3):
riscv: configs: Rename ax25-ae350 defconfig
MAINTAINERS: Sync for ax25-ae350 rename
doc: README.ae350: Sync for ax25-ae350 rename

 board/AndesTech/ax25-ae350/MAINTAINERS |  5 ++---
 configs/a25-ae350_32_defconfig         | 36 ---------------------------------
 configs/ae350_rv32_defconfig           | 36 +++++++++++++++++++++++++++++++++
 configs/ae350_rv64_defconfig           | 37 ++++++++++++++++++++++++++++++++++
 configs/ax25-ae350_64_defconfig        | 37 ----------------------------------
 doc/README.ae350                       |  2 +-
 6 files changed, 76 insertions(+), 77 deletions(-)
 delete mode 100644 configs/a25-ae350_32_defconfig
 create mode 100644 configs/ae350_rv32_defconfig
 create mode 100644 configs/ae350_rv64_defconfig
 delete mode 100644 configs/ax25-ae350_64_defconfig
Signature · 1 line
2.7.4
author
#1 lore raw

PATCH v3 1/3 riscv: configs: Rename ax25-ae350 defconfig

From: Rick Chen <[email protected]>

Remove cpu name from the defconfig naming.
Because other cpus maybe run on AE350 platform.
So only use platfrom name in defconfig naming
will be better.

---
 configs/a25-ae350_32_defconfig  | 36 ------------------------------------
 configs/ae350_rv32_defconfig    | 36 ++++++++++++++++++++++++++++++++++++
 configs/ae350_rv64_defconfig    | 37 +++++++++++++++++++++++++++++++++++++
 configs/ax25-ae350_64_defconfig | 37 -------------------------------------
 4 files changed, 73 insertions(+), 73 deletions(-)
 delete mode 100644 configs/a25-ae350_32_defconfig
 create mode 100644 configs/ae350_rv32_defconfig
 create mode 100644 configs/ae350_rv64_defconfig
 delete mode 100644 configs/ax25-ae350_64_defconfig
configs/a25-ae350_32_defconfig deleted +0 -36
deleted file mode 100644
index 5837b48..0000000
@@ -1,36 +0,0 @@
-CONFIG_RISCV=y
-CONFIG_SYS_TEXT_BASE=0x00000000
-CONFIG_TARGET_AX25_AE350=y
-CONFIG_DISTRO_DEFAULTS=y
-CONFIG_NR_DRAM_BANKS=2
-CONFIG_FIT=y
-CONFIG_BOOTDELAY=3
-CONFIG_BOARD_EARLY_INIT_F=y
-CONFIG_SYS_PROMPT="RISC-V # "
-CONFIG_CMD_IMLS=y
-CONFIG_CMD_MMC=y
-CONFIG_CMD_SF=y
-CONFIG_CMD_SF_TEST=y
-# CONFIG_CMD_SETEXPR is not set
-CONFIG_BOOTP_PREFER_SERVERIP=y
-CONFIG_CMD_CACHE=y
-CONFIG_OF_BOARD=y
-CONFIG_DEFAULT_DEVICE_TREE="ae350_32"
-CONFIG_ENV_IS_IN_SPI_FLASH=y
-CONFIG_NET_RANDOM_ETHADDR=y
-CONFIG_MMC=y
-CONFIG_FTSDC010=y
-CONFIG_FTSDC010_SDIO=y
-CONFIG_MTD_NOR_FLASH=y
-CONFIG_FLASH_CFI_DRIVER=y
-CONFIG_CFI_FLASH=y
-CONFIG_SYS_FLASH_USE_BUFFER_WRITE=y
-CONFIG_SYS_FLASH_CFI=y
-CONFIG_SPI_FLASH=y
-CONFIG_SPI_FLASH_MACRONIX=y
-CONFIG_FTMAC100=y
-CONFIG_BAUDRATE=38400
-CONFIG_SYS_NS16550=y
-CONFIG_SPI=y
-CONFIG_ATCSPI200_SPI=y
-CONFIG_ATCPIT100_TIMER=y
configs/ae350_rv32_defconfig new file +36 -0
new file mode 100644
index 0000000..5837b48
@@ -0,0 +1,36 @@
+CONFIG_RISCV=y
+CONFIG_SYS_TEXT_BASE=0x00000000
+CONFIG_TARGET_AX25_AE350=y
+CONFIG_DISTRO_DEFAULTS=y
+CONFIG_NR_DRAM_BANKS=2
+CONFIG_FIT=y
+CONFIG_BOOTDELAY=3
+CONFIG_BOARD_EARLY_INIT_F=y
+CONFIG_SYS_PROMPT="RISC-V # "
+CONFIG_CMD_IMLS=y
+CONFIG_CMD_MMC=y
+CONFIG_CMD_SF=y
+CONFIG_CMD_SF_TEST=y
+# CONFIG_CMD_SETEXPR is not set
+CONFIG_BOOTP_PREFER_SERVERIP=y
+CONFIG_CMD_CACHE=y
+CONFIG_OF_BOARD=y
+CONFIG_DEFAULT_DEVICE_TREE="ae350_32"
+CONFIG_ENV_IS_IN_SPI_FLASH=y
+CONFIG_NET_RANDOM_ETHADDR=y
+CONFIG_MMC=y
+CONFIG_FTSDC010=y
+CONFIG_FTSDC010_SDIO=y
+CONFIG_MTD_NOR_FLASH=y
+CONFIG_FLASH_CFI_DRIVER=y
+CONFIG_CFI_FLASH=y
+CONFIG_SYS_FLASH_USE_BUFFER_WRITE=y
+CONFIG_SYS_FLASH_CFI=y
+CONFIG_SPI_FLASH=y
+CONFIG_SPI_FLASH_MACRONIX=y
+CONFIG_FTMAC100=y
+CONFIG_BAUDRATE=38400
+CONFIG_SYS_NS16550=y
+CONFIG_SPI=y
+CONFIG_ATCSPI200_SPI=y
+CONFIG_ATCPIT100_TIMER=y
configs/ae350_rv64_defconfig new file +37 -0
new file mode 100644
index 0000000..b250d3f
@@ -0,0 +1,37 @@
+CONFIG_RISCV=y
+CONFIG_SYS_TEXT_BASE=0x00000000
+CONFIG_TARGET_AX25_AE350=y
+CONFIG_ARCH_RV64I=y
+CONFIG_DISTRO_DEFAULTS=y
+CONFIG_NR_DRAM_BANKS=2
+CONFIG_FIT=y
+CONFIG_BOOTDELAY=3
+CONFIG_BOARD_EARLY_INIT_F=y
+CONFIG_SYS_PROMPT="RISC-V # "
+CONFIG_CMD_IMLS=y
+CONFIG_CMD_MMC=y
+CONFIG_CMD_SF=y
+CONFIG_CMD_SF_TEST=y
+# CONFIG_CMD_SETEXPR is not set
+CONFIG_BOOTP_PREFER_SERVERIP=y
+CONFIG_CMD_CACHE=y
+CONFIG_OF_BOARD=y
+CONFIG_DEFAULT_DEVICE_TREE="ae350_64"
+CONFIG_ENV_IS_IN_SPI_FLASH=y
+CONFIG_NET_RANDOM_ETHADDR=y
+CONFIG_MMC=y
+CONFIG_FTSDC010=y
+CONFIG_FTSDC010_SDIO=y
+CONFIG_MTD_NOR_FLASH=y
+CONFIG_FLASH_CFI_DRIVER=y
+CONFIG_CFI_FLASH=y
+CONFIG_SYS_FLASH_USE_BUFFER_WRITE=y
+CONFIG_SYS_FLASH_CFI=y
+CONFIG_SPI_FLASH=y
+CONFIG_SPI_FLASH_MACRONIX=y
+CONFIG_FTMAC100=y
+CONFIG_BAUDRATE=38400
+CONFIG_SYS_NS16550=y
+CONFIG_SPI=y
+CONFIG_ATCSPI200_SPI=y
+CONFIG_ATCPIT100_TIMER=y
configs/ax25-ae350_64_defconfig deleted +0 -37
deleted file mode 100644
index b250d3f..0000000
@@ -1,37 +0,0 @@
-CONFIG_RISCV=y
-CONFIG_SYS_TEXT_BASE=0x00000000
-CONFIG_TARGET_AX25_AE350=y
-CONFIG_ARCH_RV64I=y
-CONFIG_DISTRO_DEFAULTS=y
-CONFIG_NR_DRAM_BANKS=2
-CONFIG_FIT=y
-CONFIG_BOOTDELAY=3
-CONFIG_BOARD_EARLY_INIT_F=y
-CONFIG_SYS_PROMPT="RISC-V # "
-CONFIG_CMD_IMLS=y
-CONFIG_CMD_MMC=y
-CONFIG_CMD_SF=y
-CONFIG_CMD_SF_TEST=y
-# CONFIG_CMD_SETEXPR is not set
-CONFIG_BOOTP_PREFER_SERVERIP=y
-CONFIG_CMD_CACHE=y
-CONFIG_OF_BOARD=y
-CONFIG_DEFAULT_DEVICE_TREE="ae350_64"
-CONFIG_ENV_IS_IN_SPI_FLASH=y
-CONFIG_NET_RANDOM_ETHADDR=y
-CONFIG_MMC=y
-CONFIG_FTSDC010=y
-CONFIG_FTSDC010_SDIO=y
-CONFIG_MTD_NOR_FLASH=y
-CONFIG_FLASH_CFI_DRIVER=y
-CONFIG_CFI_FLASH=y
-CONFIG_SYS_FLASH_USE_BUFFER_WRITE=y
-CONFIG_SYS_FLASH_CFI=y
-CONFIG_SPI_FLASH=y
-CONFIG_SPI_FLASH_MACRONIX=y
-CONFIG_FTMAC100=y
-CONFIG_BAUDRATE=38400
-CONFIG_SYS_NS16550=y
-CONFIG_SPI=y
-CONFIG_ATCSPI200_SPI=y
-CONFIG_ATCPIT100_TIMER=y
Signature · 1 line
2.7.4
author
#2 lore raw

PATCH v3 2/3 MAINTAINERS: Sync for ax25-ae350 rename

In reply to Andes

From: Rick Chen <[email protected]>

Rename
a25-ae350_32_defconfig as ae350_rv32_defconfig
ax25-ae350_64_defconfig as ae350_rv64_defconfig

Cc Greentime Hu <[email protected]>
---
 board/AndesTech/ax25-ae350/MAINTAINERS | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
board/AndesTech/ax25-ae350/MAINTAINERS +2 -3
index d87446e..b0a99e4 100644
@@ -3,6 +3,5 @@ M:	Rick Chen <[email protected]>
 S:	Maintained
 F:	board/AndesTech/ax25-ae350/
 F:	include/configs/ax25-ae350.h
-F:	configs/a25-ae350_32_defconfig
-F:	configs/ax25-ae350_64_defconfig
-F:	configs/ax25-ae350_defconfig
+F:	configs/ae350_rv32_defconfig
+F:	configs/ae350_rv64_defconfig
Signature · 1 line
2.7.4
#3 lore raw

PATCH v3 2/3 MAINTAINERS: Sync for ax25-ae350 rename

Hi Rick,

Quoted 7 lines · Andes

From: Rick Chen <[email protected]>

Rename
a25-ae350_32_defconfig as ae350_rv32_defconfig
ax25-ae350_64_defconfig as ae350_rv64_defconfig

Quoted 6 lines
Cc Greentime Hu <[email protected]>
---
 board/AndesTech/ax25-ae350/MAINTAINERS | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

This patch should be squashed into patch 1 in this series, as it causes buildman warnings and should be in one single patch.

Regards,
Bin

#4 lore raw

PATCH v3 2/3 MAINTAINERS: Sync for ax25-ae350 rename

Hi Bin

Bin Meng <[email protected]> 於 2018年12月18日 週二 上午10:12寫道:

Quoted 18 lines

Hi Rick,

Quoted 7 lines · Andes

From: Rick Chen <[email protected]>

Rename
a25-ae350_32_defconfig as ae350_rv32_defconfig
ax25-ae350_64_defconfig as ae350_rv64_defconfig

Quoted 6 lines
Cc Greentime Hu <[email protected]>
---
 board/AndesTech/ax25-ae350/MAINTAINERS | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
Quoted 3 lines

This patch should be squashed into patch 1 in this series, as it causes buildman warnings and should be in one single patch.

Do you mean I shall re-send [PATCH v3 2/3] MAINTAINERS: Sync for ax25-ae350 rename,
as a single patch, right ?

Rick

Quoted 2 lines

Regards,
Bin

#5 lore raw

PATCH v3 2/3 MAINTAINERS: Sync for ax25-ae350 rename

Hi Rick,

Quoted 22 lines · Rick Chen

Hi Bin

Bin Meng <[email protected]> 於 2018年12月18日 週二 上午10:12寫道:

Quoted 18 lines

Hi Rick,

Quoted 13 lines · Andes

From: Rick Chen <[email protected]>

Rename
a25-ae350_32_defconfig as ae350_rv32_defconfig
ax25-ae350_64_defconfig as ae350_rv64_defconfig

Cc Greentime Hu <[email protected]>
---
 board/AndesTech/ax25-ae350/MAINTAINERS | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
Quoted 7 lines
Quoted 3 lines

This patch should be squashed into patch 1 in this series, as it causes buildman warnings and should be in one single patch.

Do you mean I shall re-send [PATCH v3 2/3] MAINTAINERS: Sync for ax25-ae350 rename,
as a single patch, right ?

I mean this patch should be squashed into patch

[U-Boot,v3,1/3] riscv: configs: Rename ax25-ae350 defconfig

So in v4, you should only have:

[U-Boot,v4,1/2] riscv: configs: Rename ax25-ae350 defconfig [U-Boot,v4,2/2] doc: README.ae350: Sync for ax25-ae350 rename

Regards,
Bin

#6 lore raw

PATCH v3 2/3 MAINTAINERS: Sync for ax25-ae350 rename

Hi Bin

Bin Meng <[email protected]> 於 2018年12月18日 週二 上午10:50寫道:

Quoted 34 lines

Hi Rick,

Quoted 22 lines · Rick Chen

Hi Bin

Bin Meng <[email protected]> 於 2018年12月18日 週二 上午10:12寫道:

Quoted 18 lines

Hi Rick,

Quoted 13 lines · Andes

From: Rick Chen <[email protected]>

Rename
a25-ae350_32_defconfig as ae350_rv32_defconfig
ax25-ae350_64_defconfig as ae350_rv64_defconfig

Cc Greentime Hu <[email protected]>
---
 board/AndesTech/ax25-ae350/MAINTAINERS | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
Quoted 7 lines
Quoted 3 lines

This patch should be squashed into patch 1 in this series, as it causes buildman warnings and should be in one single patch.

Do you mean I shall re-send [PATCH v3 2/3] MAINTAINERS: Sync for ax25-ae350 rename,
as a single patch, right ?

Quoted 9 lines

I mean this patch should be squashed into patch

[U-Boot,v3,1/3] riscv: configs: Rename ax25-ae350 defconfig

So in v4, you should only have:

[U-Boot,v4,1/2] riscv: configs: Rename ax25-ae350 defconfig [U-Boot,v4,2/2] doc: README.ae350: Sync for ax25-ae350 rename

OK

Thanks
Rick

Quoted 2 lines

Regards,
Bin

author
#7 lore raw

PATCH v3 3/3 doc: README.ae350: Sync for ax25-ae350 rename

In reply to Andes

From: Rick Chen <[email protected]>

Rename
ax25-ae350 as ae350_rv[32|64] for 32 or 64 bit.

Cc Greentime Hu <[email protected]>
---
 doc/README.ae350 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
doc/README.ae350 +1 -1
index fe75b80..189a6b7 100644
@@ -25,7 +25,7 @@ Build and boot steps
 
 build:
 1. Prepare the toolchains and make sure the $PATH to toolchains is correct.
-2. Use `make ax25-ae350_defconfig` in u-boot root to build the image.
+2. Use `make ae350_rv[32|64]_defconfig` in u-boot root to build the image for 32 or 64 bit.
 
 Verification
 ====================
Signature · 1 line
2.7.4