Skip to contentSkip to conversation

trace-cmd: fix deletion of histogram triggers

PATCH Applied Tzvetomir Stoyanov 2 participants 2 messages Dec 18, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 trace-cmd: fix deletion of histogram triggers

This patch fixes the clear_trigger() function to delete configured histograms. Unlike other triggers, histograms must be deleted specifying the whole trigger string.

---
 tracecmd/trace-record.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tracecmd/trace-record.c +1 -1
index a9bcd8d..37a2d1d 100644
@@ -1680,7 +1680,7 @@ static void clear_trigger(const char *file)
 	 * to the file for each trigger.
 	 */
 	do {
-		len = find_trigger(file, trigger+1, BUFSIZ-1, 1);
+		len = find_trigger(file, trigger+1, BUFSIZ-1, 3);
 		if (len)
 			write_trigger(file, trigger);
 	} while (len);
Signature · 1 line
2.19.2
#1 lore raw
Quoted 5 lines · On Tue, 18 Dec 2018 12:39:28 +0200 Tzvetomir Stoyanov <[email protected]>…

This patch fixes the clear_trigger() function to delete configured histograms. Unlike other triggers, histograms must be deleted specifying the whole trigger string.

Applied. Thanks Tzvetomir!

-- Steve

Quoted 17 lines
---
 tracecmd/trace-record.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tracecmd/trace-record.c +1 -1
index a9bcd8d..37a2d1d 100644
@@ -1680,7 +1680,7 @@ static void clear_trigger(const char *file)
 	 * to the file for each trigger.
 	 */
 	do {
-		len = find_trigger(file, trigger+1, BUFSIZ-1, 1);
+		len = find_trigger(file, trigger+1, BUFSIZ-1, 3);
 		if (len)
 			write_trigger(file, trigger);
 	} while (len);