Skip to contentSkip to conversation

regulator: mcp16502: Fix missing n_voltages setting

PATCH In review Axel Lin 2 participants 2 messages Dec 19, 2018

Subsystems (2)
Voltage and current regulator framework Microchip MCP16502 PMIC driver
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 regulator: mcp16502: Fix missing n_voltages setting

The n_voltages setting is not set, fix it.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/regulator/mcp16502.c | 1 +
 1 file changed, 1 insertion(+)
drivers/regulator/mcp16502.c +1 -0
index 25d7b433fafd..ec5b6836a20c 100644
@@ -90,6 +90,7 @@ static unsigned int mcp16502_of_map_mode(unsigned int mode)
 		.ops			= &(_ops),			\
 		.type			= REGULATOR_VOLTAGE,		\
 		.owner			= THIS_MODULE,			\
+		.n_voltages		= MCP16502_VSEL + 1,		\
 		.linear_ranges		= _ranges,			\
 		.n_linear_ranges	= ARRAY_SIZE(_ranges),		\
 		.of_match		= of_match_ptr(_name),		\
Signature · 1 line
2.17.1
#1 lore raw

Hi Axel,

Thank you for the patch!

However, there are not MCP16502_VSEL + 1 voltages, but VDD_HIGH_SEL - VDD_LOW_SEL + 1 (=51).

Best regards,
Andrei

Quoted 19 lines · Axel Lin

The n_voltages setting is not set, fix it.

Signed-off-by Axel Lin <[email protected]>
---
  drivers/regulator/mcp16502.c | 1 +
  1 file changed, 1 insertion(+)
drivers/regulator/mcp16502.c +1 -0
index 25d7b433fafd..ec5b6836a20c 100644
@@ -90,6 +90,7 @@ static unsigned int mcp16502_of_map_mode(unsigned int mode)
  		.ops			= &(_ops),			\
  		.type			= REGULATOR_VOLTAGE,		\
  		.owner			= THIS_MODULE,			\
+		.n_voltages		= MCP16502_VSEL + 1,		\
  		.linear_ranges		= _ranges,			\
  		.n_linear_ranges	= ARRAY_SIZE(_ranges),		\
  		.of_match		= of_match_ptr(_name),		\