Skip to contentSkip to conversation

Request for stable backport: stmmac: Use correct values in TQS/RQS fields

DISCUSSION Niklas Cassel 2 participants 3 messages Dec 19, 2018 – Jan 29, 2019

Subsystems (3)
Networking Network drivers Stable branch
lore
Share & tools
lore

Niklas Cassel

author
#0 lore raw

Hello David,

I can observe a netdev watchdog timeout on kernel 4.14.78 when using stmmac with multiple tx queues.

Backporting the following commit:

commit 52a76235d0c4dd259cd0df503afed4757c04ba1d

Author: Jose Abreu <[email protected]>
Date:   Fri Oct 13 10:58:36 2017 +0100

net: stmmac: Use correct values in TQS/RQS fields

Currently we are using all the available fifo size in RQS and TQS fields. This will not work correctly in multi-queues IP's because total fifo size must be splitted to the enabled queues.

Correct this by computing the available fifo size per queue and setting the right value in TQS and RQS fields.

Signed-off-by Jose Abreu <[email protected]>
Cc David S. Miller <[email protected]>
Cc Joao Pinto <[email protected]>
Cc Giuseppe Cavallaro <[email protected]>
Cc Alexandre Torgue <[email protected]>
Signed-off-by David S. Miller <[email protected]>

resolves the issue.

The fix was first included in v4.15

$ git tag --contains 52a76235d0c4dd259cd0df503afed4757c04ba1d
v4.15
v4.15-rc1
v4.15-rc2

Could you please queue it up for 4.14 stable?

Kind regards,
Niklas

author
#1 lore raw

Adding stable since I see Greg's Sign-off-by on recent backports to this driver.

Quoted 41 lines · Niklas Cassel

Hello David,

I can observe a netdev watchdog timeout on kernel 4.14.78 when using stmmac with multiple tx queues.

Backporting the following commit:

commit 52a76235d0c4dd259cd0df503afed4757c04ba1d

Author: Jose Abreu <[email protected]>
Date:   Fri Oct 13 10:58:36 2017 +0100

net: stmmac: Use correct values in TQS/RQS fields

Currently we are using all the available fifo size in RQS and TQS fields. This will not work correctly in multi-queues IP's because total fifo size must be splitted to the enabled queues.

Correct this by computing the available fifo size per queue and setting the right value in TQS and RQS fields.

Signed-off-by Jose Abreu <[email protected]>
Cc David S. Miller <[email protected]>
Cc Joao Pinto <[email protected]>
Cc Giuseppe Cavallaro <[email protected]>
Cc Alexandre Torgue <[email protected]>
Signed-off-by David S. Miller <[email protected]>

resolves the issue.

The fix was first included in v4.15

$ git tag --contains 52a76235d0c4dd259cd0df503afed4757c04ba1d
v4.15
v4.15-rc1
v4.15-rc2

Could you please queue it up for 4.14 stable?

Kind regards,
Niklas

#2 lore raw
Quoted 4 lines · Niklas Cassel

Adding stable since I see Greg's Sign-off-by on recent backports to this driver.

Quoted 38 lines
Quoted 37 lines · Niklas Cassel

Hello David,

I can observe a netdev watchdog timeout on kernel 4.14.78 when using stmmac with multiple tx queues.

Backporting the following commit:

commit 52a76235d0c4dd259cd0df503afed4757c04ba1d

Author: Jose Abreu <[email protected]>
Date:   Fri Oct 13 10:58:36 2017 +0100

net: stmmac: Use correct values in TQS/RQS fields

Currently we are using all the available fifo size in RQS and TQS fields. This will not work correctly in multi-queues IP's because total fifo size must be splitted to the enabled queues.

Correct this by computing the available fifo size per queue and setting the right value in TQS and RQS fields.

Signed-off-by Jose Abreu <[email protected]>
Cc David S. Miller <[email protected]>
Cc Joao Pinto <[email protected]>
Cc Giuseppe Cavallaro <[email protected]>
Cc Alexandre Torgue <[email protected]>
Signed-off-by David S. Miller <[email protected]>

resolves the issue.

The fix was first included in v4.15

$ git tag --contains 52a76235d0c4dd259cd0df503afed4757c04ba1d
v4.15
v4.15-rc1
v4.15-rc2

Could you please queue it up for 4.14 stable?

Netdev doesn't care about 4.14 anymore, so I'll just take it, thanks.

greg k-h