drm: i915: Delete base.id prints
Subsystems (2)
PATCH 4/7 drm: i915: Delete base.id prints
This patch removes base.id prints from drm_display_mode objects in i915 files. It removes dependency from drm_mode_object.
--- drivers/gpu/drm/i915/i915_debugfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/i915_debugfs.c +2 -2
@@ -2948,8 +2948,8 @@ static void intel_seq_print_mode(struct seq_file *m, int tabs,for (i =0 ; i < tabs; i++)seq_putc (m,'\t' ); - seq_printf(m, "id %d:\"%s\" freq %d clock %d hdisp %d hss %d hse %d htot %d vdisp %d vss %d vse %d vtot %d type 0x%x flags 0x%x\n", - mode->base.id, mode->name, + seq_printf(m, "name:\"%s\" freq %d clock %d hdisp %d hss %d hse %d htot %d vdisp %d vss %d vse %d vtot %d type 0x%x flags 0x%x\n", + mode->name, mode->vrefresh, mode->clock, mode->hdisplay, mode->hsync_start, mode->hsync_end, mode->htotal,
Signature · 6 lines
2.17.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 2 lines · Shayenne Moura
This patch removes base.id prints from
drm_display_modeobjects in i915 files. It removes dependency fromdrm_mode_object.
As said, this could expand on the *why*. With that fixed,
as well as acked for merging via drm-misc.
Quoted 21 lines
Signed-off-by Shayenne Moura <[email protected]>--- drivers/gpu/drm/i915/i915_debugfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/i915_debugfs.c +2
-2@@ -2948,8 +2948,8 @@ static void intel_seq_print_mode(struct seq_file *m, int tabs,for (i =0 ; i < tabs; i++)seq_putc (m,'\t' ); - seq_printf(m, "id %d:\"%s\" freq %d clock %d hdisp %d hss %d hse %d htot %d vdisp %d vss %d vse %d vtot %d type 0x%x flags 0x%x\n", - mode->base.id, mode->name, + seq_printf(m, "name:\"%s\" freq %d clock %d hdisp %d hss %d hse %d htot %d vdisp %d vss %d vse %d vtot %d type 0x%x flags 0x%x\n", + mode->name, mode->vrefresh, mode->clock, mode->hdisplay, mode->hsync_start, mode->hsync_end, mode->htotal,
Signature · 5 lines
Jani Nikula, Intel Open Source Graphics Center _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 4 lines · Shayenne Moura
This patch removes base.id prints from
drm_display_modeobjects in i915 files. It removes dependency fromdrm_mode_object.Signed-off-by Shayenne Moura <[email protected]>
Again I think better to switch to DRM_MODE_FMT/ARG. -Daniel
Quoted 26 lines
--- drivers/gpu/drm/i915/i915_debugfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/i915_debugfs.c +2
-2@@ -2948,8 +2948,8 @@ static void intel_seq_print_mode(struct seq_file *m, int tabs,for (i =0 ; i < tabs; i++)seq_putc (m,'\t' ); - seq_printf(m, "id %d:\"%s\" freq %d clock %d hdisp %d hss %d hse %d htot %d vdisp %d vss %d vse %d vtot %d type 0x%x flags 0x%x\n", - mode->base.id, mode->name, + seq_printf(m, "name:\"%s\" freq %d clock %d hdisp %d hss %d hse %d htot %d vdisp %d vss %d vse %d vtot %d type 0x%x flags 0x%x\n", + mode->name, mode->vrefresh, mode->clock, mode->hdisplay, mode->hsync_start, mode->hsync_end, mode->htotal,Signature · 6 lines
2.17.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 9 lines · Daniel Vetter
Quoted 4 lines · Shayenne Moura
This patch removes base.id prints from
drm_display_modeobjects in i915 files. It removes dependency fromdrm_mode_object.Signed-off-by Shayenne Moura <[email protected]>Again I think better to switch to DRM_MODE_FMT/ARG. -Daniel
This one has a different print style. Is it okay to change to DRM_MODE_FMT?
Best,
Shayenne
Quoted 31 lines
Quoted 26 lines
--- drivers/gpu/drm/i915/i915_debugfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/i915_debugfs.c +2
-2@@ -2948,8 +2948,8 @@ static void intel_seq_print_mode(struct seq_file *m, int tabs,for (i =0 ; i < tabs; i++)seq_putc (m,'\t' ); - seq_printf(m, "id %d:\"%s\" freq %d clock %d hdisp %d hss %d hse %d htot %d vdisp %d vss %d vse %d vtot %d type 0x%x flags 0x%x\n", - mode->base.id, mode->name, + seq_printf(m, "name:\"%s\" freq %d clock %d hdisp %d hss %d hse %d htot %d vdisp %d vss %d vse %d vtot %d type 0x%x flags 0x%x\n", + mode->name, mode->vrefresh, mode->clock, mode->hdisplay, mode->hsync_start, mode->hsync_end, mode->htotal,Signature · 6 lines
2.17.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-develSignature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
Quoted 6 lines · Shayenne Moura
Quoted 4 lines · Daniel Vetter
Quoted 3 lines · Shayenne Moura
This patch removes base.id prints from
drm_display_modeobjects in i915 files. It removes dependency fromdrm_mode_object.
Quoted 7 lines
Quoted 5 lines
Quoted 1 line
Signed-off-by Shayenne Moura <[email protected]>Again I think better to switch to DRM_MODE_FMT/ARG. -Daniel
This one has a different print style. Is it okay to change to
DRM_MODE_FMT?
Yeah, standardizing sounds good, just mention in the commit message if something has changed. This is all debug information, so no issue if we change the output format slightly.
-Daniel
Quoted 38 lines
Best,
ShayenneQuoted 22 lines
Quoted 22 lines
--- drivers/gpu/drm/i915/i915_debugfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/i915_debugfs.c +2
-3@@ -2948,8 +2948,8 @@ static void intel_seq_print_mode(struct seq_file *m, int tabs,for (i =0 ; i < tabs; i++)seq_putc (m,'\t' ); - seq_printf(m, "id %d:\"%s\" freq %d clock %d hdisp %d hss %d hse %d htot %d vdisp %d vss %d vse %d vtot %d type 0x%x flags 0x%x\n", - mode->base.id, mode->name, + seq_printf(m, "name:\"%s\" freq %d clock %d hdisp %d hss %d hse %d htot %d vdisp %d vss %d vse %d vtot %d type 0x%x flags 0x%x\n", + mode->name, mode->vrefresh, mode->clock, mode->hdisplay, mode->hsync_start, mode->hsync_end, mode->htotal, --2.17.1
Quoted 9 lines
Quoted 4 lines
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel