Skip to contentSkip to conversation

ui/cocoa: Include less of the generated modular QAPI headers

PATCH Applied Markus Armbruster 4 participants 4 messages Dec 20, 2018 – Jan 8, 2019

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ui/cocoa: Include less of the generated modular QAPI headers

Avoids pointless recompilation. Missed in commit 112ed241f5d.

---
 ui/cocoa.m | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
ui/cocoa.m +2 -1
index ecf12bfc2e..ddc058e76e 100644
@@ -32,7 +32,8 @@
 #include "ui/input.h"
 #include "sysemu/sysemu.h"
 #include "qapi/error.h"
-#include "qapi/qapi-commands.h"
+#include "qapi/qapi-commands-block.h"
+#include "qapi/qapi-commands-misc.h"
 #include "sysemu/blockdev.h"
 #include "qemu-version.h"
 #include <Carbon/Carbon.h>
Signature · 1 line
2.17.2
Reviewed-by Tested-by on v2 1/1
#1 lore raw
Quoted 3 lines · Markus Armbruster

Avoids pointless recompilation. Missed in commit 112ed241f5d.

Quoted 19 lines
---
 ui/cocoa.m | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
ui/cocoa.m +2 -1
index ecf12bfc2e..ddc058e76e 100644
@@ -32,7 +32,8 @@
 #include "ui/input.h"
 #include "sysemu/sysemu.h"
 #include "qapi/error.h"
-#include "qapi/qapi-commands.h"
+#include "qapi/qapi-commands-block.h"
+#include "qapi/qapi-commands-misc.h"
 #include "sysemu/blockdev.h"
 #include "qemu-version.h"
 #include <Carbon/Carbon.h>
#3 lore raw
In reply to Markus Armbruster
Quoted 13 lines · Markus Armbruster

Avoids pointless recompilation. Missed in commit 112ed241f5d.

---
 ui/cocoa.m | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
ui/cocoa.m +0 -0
index ecf12bfc2e..ddc058e76e 100644

ui/cocoa.m

Quoted 10 lines
ui/cocoa.m +2 -2
@@ -32,7 +32,8 @@
 #include "ui/input.h"
 #include "sysemu/sysemu.h"
 #include "qapi/error.h"
-#include "qapi/qapi-commands.h"
+#include "qapi/qapi-commands-block.h"
+#include "qapi/qapi-commands-misc.h"
 #include "sysemu/blockdev.h"
 #include "qemu-version.h"
 #include <Carbon/Carbon.h>
--

Applied, thanks.

-- PMM