lib/fb: Remove unused variables

PATCH In review Petri Latvala 3 participants 4 messages Dec 20, 2018 – Dec 21, 2018 Library code

Share & tools

Petri Latvala

author

2018-12-20 12:15 UTC #0 lore raw

PATCH 1/1 lib/fb: Remove unused variables

../lib/igt_fb.c: In function ‘convert_rgb24_to_yuv444’:
../lib/igt_fb.c:1720:16: warning: unused variable ‘v’ [-Wunused-variable]

    float y, u, v;
          ^
../lib/igt_fb.c:1720:13: warning: unused variable ‘u’ [-Wunused-variable]
    float y, u, v;
             ^
../lib/igt_fb.c:1720:10: warning: unused variable ‘y’ [-Wunused-variable]
    float y, u, v;
                ^

Signed-off-by Petri Latvala <[email protected]>

Cc Stanislav Lisovskiy <[email protected]>

Cc Maarten Lankhorst <[email protected]>

---
 lib/igt_fb.c | 1 -
 1 file changed, 1 deletion(-)

lib/igt_fb.c +0 -1

index 57264844..2f555c95 100644
@@ -1717,7 +1717,6 @@ static void convert_rgb24_to_yuv444(struct fb_convert *cvt)
 		for (j = 0; j < cvt->dst.fb->width; j++) {
 			struct igt_vec4 rgb;
 			struct igt_vec4 yuv;
-			float y, u, v;
 
 			read_rgb(&rgb, &rgb24[i * rgb24_stride + j * 4]);

Signature · 6 lines

2.19.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Lisovskiy, Stanislav

Reviewed-by on v1 1/1

2018-12-20 12:22 UTC #1 lore raw

Quoted 33 lines · Petri Latvala

../lib/igt_fb.c: In function ‘convert_rgb24_to_yuv444’:
../lib/igt_fb.c:1720:16: warning: unused variable ‘v’ [-Wunused- variable]

    float y, u, v;
          ^
../lib/igt_fb.c:1720:13: warning: unused variable ‘u’ [-Wunused-
variable]
    float y, u, v;
             ^
../lib/igt_fb.c:1720:10: warning: unused variable ‘y’ [-Wunused-
variable]
    float y, u, v;
                ^

Signed-off-by Petri Latvala <[email protected]>

Cc Stanislav Lisovskiy <[email protected]>

Cc Maarten Lankhorst <[email protected]>

---
 lib/igt_fb.c | 1 -
 1 file changed, 1 deletion(-)

lib/igt_fb.c +0 -1

index 57264844..2f555c95 100644
@@ -1717,7 +1717,6 @@ static void convert_rgb24_to_yuv444(struct
 fb_convert *cvt)
 		for (j = 0; j < cvt->dst.fb->width; j++) {
 			struct igt_vec4 rgb;
 			struct igt_vec4 yuv;
-			float y, u, v;
 
 			read_rgb(&rgb, &rgb24[i * rgb24_stride + j *

Quoted 2 lines

4]);

Thanks for spotting.

Reviewed-by Stanislav Lisovskiy <[email protected]>

Signature · 7 lines

Best Regards,

Lisovskiy Stanislav
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Patchwork

2018-12-20 12:59 UTC #2 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for lib/fb: Remove unused variables

In reply to Petri Latvala

== Series Details ==

Series: lib/fb: Remove unused variables
URL : https://patchwork.freedesktop.org/series/54337/
State : success

== Summary ==

CI Bug Log - changes from IGT_4752 -> IGTPW_2173
====================================================

Summary
-------

**WARNING**

Minor unknown changes coming with IGTPW_2173 need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_2173, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/54337/revisions/1/mbox/

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_2173:

### IGT changes ###

#### Warnings ####

* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-c:
- fi-kbl-7567u: PASS -> SKIP +33

* igt@pm_rpm@basic-pci-d3-state:
- fi-byt-j1900: SKIP -> PASS

Known issues
------------

Here are the changes found in IGTPW_2173 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_ctx_create@basic-files:
- fi-bsw-kefka: PASS -> FAIL [fdo#108656]

* {igt@runner@aborted}:
- fi-icl-u3: NOTRUN -> FAIL [fdo#108315]

#### Possible fixes ####

* igt@gem_ctx_create@basic-files:
- fi-bsw-n3050: FAIL [fdo#108656] -> PASS

* igt@i915_selftest@live_hangcheck:
- fi-skl-iommu: INCOMPLETE [fdo#108602] / [fdo#108744] -> PASS

* igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS

* igt@pm_rpm@basic-rte:
- fi-byt-j1900: FAIL [fdo#108800] -> PASS

#### Warnings ####

* igt@i915_selftest@live_contexts:
- fi-icl-u3: DMESG-FAIL [fdo#108569] -> INCOMPLETE [fdo#108315]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

Participating hosts (50 -> 44)
------------------------------

Missing (6): fi-kbl-soraka fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-icl-y

Build changes
-------------

* IGT: IGT_4752 -> IGTPW_2173

CI_DRM_5335: d1bb3d7e01b06108d5f326706a1cb5d305a847c7 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2173: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2173/
IGT_4752: 321fe77d32fef32ef820f53924045fe6ef0cf6ed @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2173/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Patchwork

2018-12-21 11:45 UTC #3 lore raw

[igt-dev] ✓ Fi.CI.IGT: success for lib/fb: Remove unused variables

In reply to Petri Latvala

== Series Details ==

Series: lib/fb: Remove unused variables
URL : https://patchwork.freedesktop.org/series/54337/
State : success

== Summary ==

CI Bug Log - changes from IGT_4752_full -> IGTPW_2173_full
====================================================

Summary
-------

**WARNING**

Minor unknown changes coming with IGTPW_2173_full need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_2173_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/54337/revisions/1/mbox/

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_2173_full:

### IGT changes ###

#### Warnings ####

* igt@pm_rc6_residency@rc6-accuracy:
- shard-snb: SKIP -> PASS

Known issues
------------

Here are the changes found in IGTPW_2173_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@kms_available_modes_crc@available_mode_test_crc:
- shard-apl: PASS -> FAIL [fdo#106641]

* igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
- shard-kbl: PASS -> FAIL [fdo#107725] / [fdo#108145]

* igt@kms_cursor_crc@cursor-128x128-random:
- shard-apl: PASS -> FAIL [fdo#103232] +5

* igt@kms_cursor_crc@cursor-128x42-onscreen:
- shard-glk: PASS -> FAIL [fdo#103232] +6
- shard-kbl: NOTRUN -> FAIL [fdo#103232]

* igt@kms_cursor_crc@cursor-64x21-sliding:
- shard-kbl: PASS -> FAIL [fdo#103232]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
- shard-apl: PASS -> FAIL [fdo#103167] +3

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
- shard-kbl: PASS -> FAIL [fdo#103167] +2

* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-cpu:
- shard-glk: PASS -> FAIL [fdo#103167] +10

* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-mmap-gtt:
- shard-snb: SKIP -> INCOMPLETE [fdo#105411] / [fdo#107469]

* igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
- shard-glk: PASS -> FAIL [fdo#108948]

* igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
- shard-glk: PASS -> FAIL [fdo#108145] +1

* igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
- shard-apl: PASS -> FAIL [fdo#103166] +2
- shard-kbl: PASS -> FAIL [fdo#103166]

* igt@kms_plane_multiple@atomic-pipe-c-tiling-x:
- shard-glk: PASS -> FAIL [fdo#103166] +3

* igt@kms_setmode@basic:
- shard-glk: PASS -> FAIL [fdo#99912]

* igt@perf_pmu@rc6-runtime-pm:
- shard-apl: PASS -> FAIL [fdo#105010]

#### Possible fixes ####

* igt@gem_exec_fence@basic-await-default:
- shard-hsw: FAIL [fdo#108888] -> PASS

* igt@gem_exec_fence@basic-busy-default:
- shard-snb: INCOMPLETE [fdo#105411] -> PASS

* igt@gem_softpin@noreloc-s3:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS

* igt@kms_color@pipe-c-ctm-max:
- shard-apl: FAIL [fdo#108147] -> PASS

* igt@kms_cursor_crc@cursor-256x256-onscreen:
- shard-glk: FAIL [fdo#103232] -> PASS +1

* igt@kms_cursor_crc@cursor-256x85-sliding:
- shard-apl: FAIL [fdo#103232] -> PASS +1

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
- shard-apl: FAIL [fdo#103167] -> PASS +1

* igt@kms_frontbuffer_tracking@fbc-1p-rte:
- shard-apl: FAIL [fdo#103167] / [fdo#105682] -> PASS

* igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
- shard-apl: FAIL [fdo#108948] -> PASS

* igt@kms_plane@pixel-format-pipe-c-planes-source-clamping:
- shard-glk: FAIL [fdo#108948] -> PASS

* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
- shard-glk: FAIL [fdo#108145] -> PASS +1

* igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
- shard-glk: FAIL [fdo#103166] -> PASS +3
- shard-kbl: FAIL [fdo#103166] -> PASS

* igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
- shard-apl: FAIL [fdo#103166] -> PASS +1

* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-kbl: DMESG-FAIL [fdo#108950] -> PASS
- shard-glk: DMESG-FAIL [fdo#105763] / [fdo#106538] -> PASS

* igt@kms_setmode@basic:
- shard-kbl: FAIL [fdo#99912] -> PASS

Participating hosts (7 -> 5)
------------------------------

Missing (2): shard-skl shard-iclb

Build changes
-------------

* IGT: IGT_4752 -> IGTPW_2173

== Logs ==