drm/debugfs_crc: Degrade ERROR when overflowing to INFO

PATCH In review Maarten Lankhorst 3 participants 5 messages Dec 20, 2018 – Dec 27, 2018

Subsystems (2)

DRM drivers DRM misc

lore

Share & tools

lore

Maarten Lankhorst

author maintainer

2018-12-20 15:17 UTC #0 lore raw

PATCH 1/1 drm/debugfs_crc: Degrade ERROR when overflowing to INFO

Signed-off-by Maarten Lankhorst <[email protected]>

---
 drivers/gpu/drm/drm_debugfs_crc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/gpu/drm/drm_debugfs_crc.c +1 -1

index 00e743153e94..80f473ce5c67 100644
@@ -408,7 +408,7 @@ int drm_crtc_add_crc_entry(struct drm_crtc *crtc, bool has_frame,
 		spin_unlock(&crc->lock);
 
 		if (!was_overflow)
-			DRM_ERROR("Overflow of CRC buffer, userspace reads too slow.\n");
+			DRM_INFO("Overflow of CRC buffer, userspace reads too slow.\n");
 
 		return -ENOBUFS;
 	}

Signature · 6 lines

2.19.2

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Patchwork

2018-12-20 16:15 UTC #1 lore raw

✗ Fi.CI.CHECKPATCH: warning for drm/debugfs_crc: Degrade ERROR when overflowing to INFO

== Series Details ==

Series: drm/debugfs_crc: Degrade ERROR when overflowing to INFO
URL : https://patchwork.freedesktop.org/series/54364/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
ae751d55dd4f drm/debugfs_crc: Degrade ERROR when overflowing to INFO
-:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

total: 0 errors, 1 warnings, 0 checks, 8 lines checked

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Patchwork

2018-12-20 16:36 UTC #2 lore raw

✓ Fi.CI.BAT: success for drm/debugfs_crc: Degrade ERROR when overflowing to INFO

In reply to Maarten Lankhorst

== Series Details ==

Series: drm/debugfs_crc: Degrade ERROR when overflowing to INFO
URL : https://patchwork.freedesktop.org/series/54364/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5336 -> Patchwork_11140
====================================================

Summary
-------

**WARNING**

Minor unknown changes coming with Patchwork_11140 need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_11140, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/54364/revisions/1/mbox/

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_11140:

### IGT changes ###

#### Warnings ####

* igt@kms_busy@basic-flip-a:
- fi-kbl-7567u: SKIP -> PASS +2

Known issues
------------

Here are the changes found in Patchwork_11140 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: PASS -> FAIL [fdo#108767]

#### Possible fixes ####

* igt@gem_ctx_create@basic-files:
- fi-bsw-kefka: INCOMPLETE [fdo#105876] / [fdo#108714] -> PASS

* igt@gem_exec_suspend@basic-s4-devices:
- fi-blb-e6850: INCOMPLETE [fdo#107718] -> PASS

* igt@gem_mmap_gtt@basic-small-copy-xy:
- fi-glk-dsi: INCOMPLETE [fdo#103359] / [k.org#198133] -> PASS

* igt@prime_vgem@basic-fence-flip:
- fi-gdg-551: FAIL [fdo#103182] -> PASS

[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#105876]: https://bugs.freedesktop.org/show_bug.cgi?id=105876
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108714]: https://bugs.freedesktop.org/show_bug.cgi?id=108714
[fdo#108767]: https://bugs.freedesktop.org/show_bug.cgi?id=108767
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133

Participating hosts (49 -> 43)
------------------------------

Additional (1): fi-skl-6700hq
Missing (7): fi-kbl-soraka fi-hsw-4770r fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-icl-y

Build changes
-------------

* Linux: CI_DRM_5336 -> Patchwork_11140

CI_DRM_5336: 9fd194c1f8bd36cb623d842f5ed52b2ca2c83d18 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4752: 321fe77d32fef32ef820f53924045fe6ef0cf6ed @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_11140: ae751d55dd4feddc27f1dded781e5225f203c35e @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

ae751d55dd4f drm/debugfs_crc: Degrade ERROR when overflowing to INFO

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_11140/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Patchwork

2018-12-21 15:25 UTC #3 lore raw

✓ Fi.CI.IGT: success for drm/debugfs_crc: Degrade ERROR when overflowing to INFO

In reply to Maarten Lankhorst

== Series Details ==

Series: drm/debugfs_crc: Degrade ERROR when overflowing to INFO
URL : https://patchwork.freedesktop.org/series/54364/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5336_full -> Patchwork_11140_full
====================================================

Summary
-------

**WARNING**

Minor unknown changes coming with Patchwork_11140_full need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_11140_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_11140_full:

### IGT changes ###

#### Warnings ####

* igt@pm_rc6_residency@rc6-accuracy:
- shard-snb: SKIP -> PASS

Known issues
------------

Here are the changes found in Patchwork_11140_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_schedule@pi-ringfull-blt:
- shard-skl: NOTRUN -> FAIL [fdo#103158]

* igt@gem_exec_whisper@normal:
- shard-skl: PASS -> TIMEOUT [fdo#108592]

* igt@gem_ppgtt@blt-vs-render-ctxn:
- shard-skl: PASS -> TIMEOUT [fdo#108039]

* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-c:
- shard-skl: NOTRUN -> DMESG-WARN [fdo#107956] +1

* igt@kms_busy@extended-pageflip-hang-newfb-render-c:
- shard-glk: PASS -> DMESG-WARN [fdo#107956]

* igt@kms_chv_cursor_fail@pipe-c-64x64-right-edge:
- shard-skl: NOTRUN -> FAIL [fdo#104671] +2

* igt@kms_color@pipe-c-ctm-max:
- shard-apl: PASS -> FAIL [fdo#108147]

* igt@kms_cursor_crc@cursor-128x42-onscreen:
- shard-skl: NOTRUN -> FAIL [fdo#103232] +3

* igt@kms_cursor_crc@cursor-256x256-sliding:
- shard-iclb: NOTRUN -> FAIL [fdo#103232] +2

* igt@kms_cursor_crc@cursor-256x85-sliding:
- shard-apl: PASS -> FAIL [fdo#103232]

* igt@kms_cursor_crc@cursor-64x64-suspend:
- shard-skl: NOTRUN -> INCOMPLETE [fdo#104108]

* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
- shard-glk: PASS -> FAIL [fdo#104873]

* igt@kms_draw_crc@draw-method-rgb565-render-xtiled:
- shard-iclb: PASS -> WARN [fdo#108336] +5

* igt@kms_flip@plain-flip-fb-recreate:
- shard-skl: PASS -> FAIL [fdo#100368]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-gtt:
- shard-apl: PASS -> FAIL [fdo#103167] +1

* igt@kms_frontbuffer_tracking@fbc-stridechange:
- shard-iclb: PASS -> FAIL [fdo#103167] +2

* igt@kms_frontbuffer_tracking@fbc-tilingchange:
- shard-iclb: PASS -> DMESG-FAIL [fdo#107724] +7

* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-blt:
- shard-iclb: PASS -> DMESG-WARN [fdo#107724] / [fdo#108336] +17

* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-iclb: PASS -> DMESG-FAIL [fdo#103166] / [fdo#107724]

* igt@kms_plane_alpha_blend@pipe-a-alpha-basic:
- shard-skl: NOTRUN -> FAIL [fdo#107815] / [fdo#108145]

* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
- shard-skl: NOTRUN -> FAIL [fdo#108145] +1

* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: NOTRUN -> FAIL [fdo#107815]

* igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
- shard-iclb: PASS -> FAIL [fdo#103166]

* igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
- shard-glk: PASS -> FAIL [fdo#103166] +2

* igt@kms_psr@sprite_mmap_cpu:
- shard-iclb: PASS -> DMESG-WARN [fdo#107724] +46

* igt@kms_setmode@basic:
- shard-kbl: PASS -> FAIL [fdo#99912]

* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-skl: NOTRUN -> INCOMPLETE [fdo#104108] / [fdo#107773]

* igt@pm_rpm@i2c:
- shard-iclb: PASS -> FAIL [fdo#104097]

#### Possible fixes ####

* igt@gem_exec_fence@basic-busy-default:
- shard-snb: INCOMPLETE [fdo#105411] -> PASS

* igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels:
- shard-iclb: DMESG-WARN [fdo#107724] -> PASS +4

* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-a:
- shard-skl: DMESG-WARN [fdo#107956] -> PASS

* igt@kms_cursor_crc@cursor-128x128-suspend:
- shard-skl: INCOMPLETE [fdo#104108] -> PASS

* igt@kms_cursor_crc@cursor-128x42-offscreen:
- shard-glk: INCOMPLETE [fdo#103359] / [k.org#198133] -> PASS

* igt@kms_cursor_crc@cursor-64x64-offscreen:
- shard-skl: FAIL [fdo#103232] -> PASS

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-wc:
- shard-apl: FAIL [fdo#103167] -> PASS

* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
- shard-glk: FAIL [fdo#103167] -> PASS +1

* igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw:
- shard-iclb: DMESG-FAIL [fdo#107724] -> PASS +3

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-pwrite:
- shard-iclb: FAIL [fdo#103167] -> PASS +1

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
- shard-skl: INCOMPLETE [fdo#104108] / [fdo#107773] -> PASS

* igt@kms_plane@pixel-format-pipe-b-planes:
- shard-skl: DMESG-WARN [fdo#106885] -> PASS +2

* igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
- shard-apl: DMESG-WARN [fdo#103558] / [fdo#105602] -> PASS +12

* igt@kms_plane@plane-position-covered-pipe-c-planes:
- shard-apl: FAIL [fdo#103166] -> PASS +2

* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: FAIL [fdo#107815] -> PASS

* igt@kms_plane_multiple@atomic-pipe-c-tiling-x:
- shard-iclb: FAIL [fdo#103166] -> PASS

* igt@kms_rotation_crc@bad-tiling:
- shard-iclb: DMESG-WARN [fdo#107724] / [fdo#108336] -> PASS +3

* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-kbl: DMESG-WARN [fdo#105604] -> PASS

* igt@kms_setmode@basic:
- shard-apl: FAIL [fdo#99912] -> PASS

* igt@pm_rpm@gem-evict-pwrite:
- shard-skl: INCOMPLETE [fdo#107807] -> PASS +1

* igt@pm_rpm@legacy-planes:
- shard-iclb: DMESG-WARN [fdo#108654] -> PASS

* igt@pm_rpm@sysfs-read:
- shard-iclb: INCOMPLETE [fdo#107713] / [fdo#108840] -> PASS

* igt@pm_rpm@system-suspend-execbuf:
- shard-skl: INCOMPLETE [fdo#104108] / [fdo#107773] / [fdo#107807] -> PASS

#### Warnings ####

* igt@i915_selftest@live_contexts:
- shard-iclb: INCOMPLETE [fdo#108315] -> DMESG-FAIL [fdo#108569]

* igt@i915_suspend@shrink:
- shard-snb: INCOMPLETE [fdo#105411] / [fdo#106886] -> DMESG-WARN [fdo#108784]

* igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
- shard-iclb: FAIL [fdo#107725] -> DMESG-WARN [fdo#107724] / [fdo#108336]

* igt@kms_cursor_crc@cursor-128x128-sliding:
- shard-iclb: FAIL [fdo#103232] -> DMESG-WARN [fdo#107724] / [fdo#108336]

* igt@kms_cursor_crc@cursor-256x256-suspend:
- shard-iclb: FAIL [fdo#103232] -> INCOMPLETE [fdo#107713]

* igt@pm_backlight@fade_with_suspend:
- shard-iclb: FAIL [fdo#107847] -> INCOMPLETE [fdo#107713] / [fdo#107820]

Participating hosts (7 -> 7)
------------------------------

No changes in participating hosts

Build changes
-------------

* Linux: CI_DRM_5336 -> Patchwork_11140

== Logs ==

Jani Nikula

2018-12-27 08:05 UTC #4 lore raw

In reply to Maarten Lankhorst

On Thu, 20 Dec 2018, Maarten Lankhorst <[email protected]> wrote:

Insert commit message explaining why here. ;)

BR,
Jani.

Quoted 18 lines

Signed-off-by Maarten Lankhorst <[email protected]>

---
 drivers/gpu/drm/drm_debugfs_crc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/gpu/drm/drm_debugfs_crc.c +1 -1

index 00e743153e94..80f473ce5c67 100644
@@ -408,7 +408,7 @@ int drm_crtc_add_crc_entry(struct drm_crtc *crtc, bool has_frame,
 		spin_unlock(&crc->lock);
 
 		if (!was_overflow)
-			DRM_ERROR("Overflow of CRC buffer, userspace reads too slow.\n");
+			DRM_INFO("Overflow of CRC buffer, userspace reads too slow.\n");
 
 		return -ENOBUFS;
 	}

Signature · 5 lines

Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx