arm64: dts: meson: libretech-cc: emmc update
Subsystems (2)
Jerome Brunet
reviewercover arm64: dts: meson: libretech-cc: emmc update
This patchset provides a couple of update for the eMMC on the libretech-cc It should remove some error message for those who don't have an eMMC module and improve the performance for those who do have one.
Jerome Brunet (2):
arm64: dts: meson: libretech-cc: set eMMC as removable
arm64: dts: meson: libretech-cc: switch eMMC to 1.8v
.../boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
Signature · 1 line
2.19.2
Jerome Brunet
reviewerPATCH 1/2 arm64: dts: meson: libretech-cc: set eMMC as removable
The eMMC on this board is add-on module which is not mandatory. Removing 'non-removable' property should prevent some errors when booting a board w/o an eMMC module present.
--- arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts | 1 - 1 file changed, 1 deletion(-)
arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts +0 -1
@@ -256,7 +256,6 @@ cap-mmc-highspeed; mmc-ddr-3_3v; max-frequency = <50000000>; - non-removable; disable-wp; mmc-pwrseq = <&emmc_pwrseq>;
Signature · 1 line
2.19.2
Jerome Brunet
reviewerPATCH 2/2 arm64: dts: meson: libretech-cc: switch eMMC to 1.8v
In reply to Jerome BrunetWhile some 3.3v eMMC 4.0 are available from libretech, the default option for the aml-s905x-cc seems to 1.8v 5.0 modules.
--- .../boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts +5 -4
@@ -118,8 +118,8 @@ vddio_boot: regulator-vddio_boot { compatible = "regulator-fixed"; regulator-name = "VDDIO_BOOT"; - regulator-min-microvolt = <3300000>; - regulator-max-microvolt = <3300000>; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; }; };
@@ -254,8 +254,9 @@ bus-width = <8>; cap-mmc-highspeed; - mmc-ddr-3_3v; - max-frequency = <50000000>; + mmc-ddr-1_8v; + mmc-hs200-1_8v; + max-frequency = <200000000>; disable-wp; mmc-pwrseq = <&emmc_pwrseq>;
Signature · 1 line
2.19.2
Martin Blumenstingl
reviewerRe: [PATCH 2/2] arm64: dts: meson: libretech-cc: switch eMMC to 1.8v
Hi Jerome,
Quoted 3 lines · Jerome Brunet
While some 3.3v eMMC 4.0 are available from libretech, the default option for the aml-s905x-cc seems to 1.8v 5.0 modules.
nit-pick:
can you please state which module (storage size) you used for testing? you probably still remember that we had some confusion on Odroid-C2 which eMMC module works and which doesn't, so let's be explicit here
Quoted 10 lines
Signed-off-by Jerome Brunet <[email protected]>--- .../boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts +0
-0
arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts line 122
Quoted 7 lines
arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts +2
-2@@ -118,8 +118,8 @@ vddio_boot: regulator-vddio_boot { compatible = "regulator-fixed"; regulator-name = "VDDIO_BOOT"; - regulator-min-microvolt = <3300000>; - regulator-max-microvolt = <3300000>; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>;
is there a 3.3V -> 1.8V regulator on the eMMC module?
I'm not sure about the schematics but it seems to be that the board itself supplies only 3.3V to the eMMC connector, so I'm not sure where 1.8V come from in this case
can you please add a comment to the .dts about this?
Regards
Martin
Jerome Brunet
reviewerRe: [PATCH 2/2] arm64: dts: meson: libretech-cc: switch eMMC to 1.8v
Quoted 24 lines · Martin Blumenstingl
Hi Jerome,
Quoted 2 lines · Jerome Brunet
While some 3.3v eMMC 4.0 are available from libretech, the default option for the aml-s905x-cc seems to 1.8v 5.0 modules.
nit-pick:
can you please state which module (storage size) you used for testing? you probably still remember that we had some confusion on Odroid-C2 which eMMC module works and which doesn't, so let's be explicit hereQuoted 14 lines
Signed-off-by Jerome Brunet <[email protected]>--- .../boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts +0
-0@@ -118,8 +118,8 @@ vddio_boot: regulator-vddio_boot { compatible = "regulator-fixed"; regulator-name = "VDDIO_BOOT";
Quoted 8 lines
arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts line 122
Quoted 4 lines
arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts +2
-2- regulator-min-microvolt = <3300000>; - regulator-max-microvolt = <3300000>; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>;is there a 3.3V -> 1.8V regulator on the eMMC module?
I'm not sure about the schematics but it seems to be that the board itself supplies only 3.3V to the eMMC connector, so I'm not sure where 1.8V come from in this case
The module is indeed fed by 3.3v only but it has embedded LDOs add will feed back the supply of the BOOT gpio bank.
I tried the following modules:
* 8 GB samsung - v1.0-170420
* 32 GB toshiba - v1.0-170421
I think you can't get them here [0].
In theory, these 4.x modules [1] could also work. They don't have the LDOs and are directly feeding back the 3.3v to the BOOT bank. Since the modules are advertised as being compatible with the Allwinner boards only, and not the AML ones, it should not be the default option.
[0] :
https://www.loverpi.com/collections/libre-computer-project/products/libre-computer-board-emmc-5-x-module?variant=4173557729
[1] :
https://www.loverpi.com/collections/libre-computer-project/products/libre-computer-board-emmc-4-x-module?variant=761282232333
Quoted 1 line
can you please add a comment to the .dts about this?
Sure
Quoted 4 lines
Regards
Martin
Kevin Hilman
maintainerRe: [PATCH 2/2] arm64: dts: meson: libretech-cc: switch eMMC to 1.8v
Quoted 48 lines · Jerome Brunet
Quoted 24 lines · Martin Blumenstingl
Hi Jerome,
Quoted 2 lines · Jerome Brunet
While some 3.3v eMMC 4.0 are available from libretech, the default option for the aml-s905x-cc seems to 1.8v 5.0 modules.
nit-pick:
can you please state which module (storage size) you used for testing? you probably still remember that we had some confusion on Odroid-C2 which eMMC module works and which doesn't, so let's be explicit hereQuoted 14 lines
Signed-off-by Jerome Brunet <[email protected]>--- .../boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts +0
-0@@ -118,8 +118,8 @@ vddio_boot: regulator-vddio_boot { compatible = "regulator-fixed"; regulator-name = "VDDIO_BOOT";Quoted 8 lines
arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts line 122
Quoted 4 lines
arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts +2
-2- regulator-min-microvolt = <3300000>; - regulator-max-microvolt = <3300000>; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>;is there a 3.3V -> 1.8V regulator on the eMMC module?
I'm not sure about the schematics but it seems to be that the board itself supplies only 3.3V to the eMMC connector, so I'm not sure where 1.8V come from in this caseThe module is indeed fed by 3.3v only but it has embedded LDOs add will feed back the supply of the BOOT gpio bank.
I tried the following modules:
* 8 GB samsung - v1.0-170420
* 32 GB toshiba - v1.0-170421I think you can't get them here [0].
In theory, these 4.x modules [1] could also work. They don't have the LDOs and are directly feeding back the 3.3v to the BOOT bank. Since the modules are advertised as being compatible with the Allwinner boards only, and not the AML ones, it should not be the default option.
Quoted 9 lines
[0] :
https://www.loverpi.com/collections/libre-computer-project/products/libre-computer-board-emmc-5-x-module?variant=4173557729
[1] :
https://www.loverpi.com/collections/libre-computer-project/products/libre-computer-board-emmc-4-x-module?variant=761282232333Quoted 1 line
can you please add a comment to the .dts about this?
Sure
OK, I'll wait for a v2 of this series.
Kevin