rts5208: fix a missing check of ms read
PATCH 1/1 rts5208: fix a missing check of ms read
When ms_read_extra_data fails, the data read in "extra" buffer is just incorrect and thus should be used. However, "extra" is used in multiple places no matter ms_read_extra_data() fails or not. The fix checks the status of ms_read_extra_data() and returns with an error code upon its failure.
Signed-off-by Kangjie Lu <[email protected]>
--- drivers/staging/rts5208/ms.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/staging/rts5208/ms.c +3 -1
@@ -1676,7 +1676,9 @@ static int ms_copy_page(struct rtsx_chip *chip, u16 old_blk, u16 new_blk,return STATUS_FAIL ; } -ms_read_extra_data (chip, old_blk, i, extra,MS_EXTRA_SIZE ); + retval =ms_read_extra_data (chip, old_blk, i, extra,MS_EXTRA_SIZE ); +if (retval !=STATUS_SUCCESS ) +return STATUS_FAIL ; retval =ms_set_rw_reg_addr (chip, OverwriteFlag,MS_EXTRA_SIZE , SystemParm,6 );
Signature · 1 line
2.17.1
Quoted 7 lines · Kangjie Lu
When
ms_read_extra_datafails, the data read in "extra" buffer is just incorrect and thus should be used. However, "extra" is used in multiple places no matterms_read_extra_data()fails or not. The fix checks the status ofms_read_extra_data()and returns with an error code upon its failure.Signed-off-by Kangjie Lu <[email protected]>
Looks good.
Reviewed-by Dan Carpenter <[email protected]>
regards,
dan carpenter