Skip to contentSkip to conversation

devtools: fix wrong headline lowercase for arm

PATCH Superseded Gavin Hu 4 participants 5 messages Dec 20, 2018 – Jan 10, 2019

lore
Share & tools
lore

Gavin Hu

author
#0 lore raw

PATCH v2 1/1 devtools: fix wrong headline lowercase for arm

Change to the new wording according to Arm corp:
https://mails.dpdk.org/archives/dev/2018-October/115174.html
otherwise, "Wrong headline lowercase" may be falsely reported.

Fixes f146ada21d1e ("scripts: add more git log checks")
---
 devtools/check-git-log.sh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
devtools/check-git-log.sh +3 -3
index 85d67fb9a..15f15e18b 100755
@@ -90,9 +90,9 @@ bad=$(echo "$headlines" | grep -E --color=always \
 	-e ':.*\<[hsf]w\>' \
 	-e ':.*\<l[234]\>' \
 	-e ':.*\<api\>' \
-	-e ':.*\<arm\>' \
-	-e ':.*\<armv7\>' \
-	-e ':.*\<armv8\>' \
+	-e ':.*\<ARM\>' \
+	-e ':.*\<(Armv7|ARMv7|ArmV7|armV7|ARMV7)\>' \
+	-e ':.*\<(Armv8|ARMv8|ArmV8|armV8|ARMV8)\>' \
 	-e ':.*\<crc\>' \
 	-e ':.*\<dma\>' \
 	-e ':.*\<eeprom\>' \
Signature · 1 line
2.11.0
#1 lore raw
Quoted 18 lines

Change to the new wording according to Arm corp:
https://mails.dpdk.org/archives/dev/2018-October/115174.html
otherwise, "Wrong headline lowercase" may be falsely reported.

Fixes f146ada21d1e ("scripts: add more git log checks")
---
 devtools/check-git-log.sh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
devtools/check-git-log.sh index renamed from devtools/check-git-log.sh +0 -0

85d67fb9a..15f15e18b 100755

devtools/check-git-log.sh bad=$(echo "$headlines" | grep -E --color=always \ · line 95

Quoted 9 lines
devtools/check-git-log.sh +3 -3
@@ -90,9 +90,9 @@ bad=$(echo "$headlines" | grep -E --color=always \
 	-e ':.*\<[hsf]w\>' \
 	-e ':.*\<l[234]\>' \
 	-e ':.*\<api\>' \
-	-e ':.*\<arm\>' \
-	-e ':.*\<armv7\>' \
-	-e ':.*\<armv8\>' \
+	-e ':.*\<ARM\>' \
+	-e ':.*\<(Armv7|ARMv7|ArmV7|armV7|ARMV7)\>' \
+	-e ':.*\<(Armv8|ARMv8|ArmV8|armV8|ARMV8)\>' \

Can you add aarch64/aarch32/arm64/arm32 related permutations?

Quoted 5 lines
devtools/check-git-log.sh +0 -1
 	-e ':.*\<crc\>' \
 	-e ':.*\<dma\>' \
 	-e ':.*\<eeprom\>' \
--

2.11.0

author
#2 lore raw

PATCH v3 1/1 devtools: fix wrong headline lowercase for arm

In reply to Gavin Hu

Change to the new wording according to Arm corp:
https://mails.dpdk.org/archives/dev/2018-October/115174.html
otherwise, "Wrong headline lowercase" may be falsely reported.

Fixes f146ada21d1e ("scripts: add more git log checks")
---
 devtools/check-git-log.sh | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
devtools/check-git-log.sh +4 -3
index 85d67fb9a..d39064f9d 100755
@@ -90,9 +90,10 @@ bad=$(echo "$headlines" | grep -E --color=always \
 	-e ':.*\<[hsf]w\>' \
 	-e ':.*\<l[234]\>' \
 	-e ':.*\<api\>' \
-	-e ':.*\<arm\>' \
-	-e ':.*\<armv7\>' \
-	-e ':.*\<armv8\>' \
+	-e ':.*\<ARM\>' \
+	-e ':.*\<(Aarch64|AArch64|AARCH64|Aarch32|AArch32|AARCH32)\>' \
+	-e ':.*\<(Armv7|ARMv7|ArmV7|armV7|ARMV7)\>' \
+	-e ':.*\<(Armv8|ARMv8|ArmV8|armV8|ARMV8)\>' \
 	-e ':.*\<crc\>' \
 	-e ':.*\<dma\>' \
 	-e ':.*\<eeprom\>' \
Signature · 1 line
2.11.0
Acked-by on v3 1/1
#3 lore raw
Quoted 8 lines · Gavin Hu

External Email

-------------------------------------------------------------------
---
Change to the new wording according to Arm corp:
https://mails.dpdk.org/archives/dev/2018-October/115174.html
otherwise, "Wrong headline lowercase" may be falsely reported.

Quoted 4 lines
Fixes f146ada21d1e ("scripts: add more git log checks")

Looks good to me.

Quoted 22 lines
---
 devtools/check-git-log.sh | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
devtools/check-git-log.sh +4 -3
index 85d67fb9a..d39064f9d 100755
@@ -90,9 +90,10 @@ bad=$(echo "$headlines" | grep -E --color=always \
 	-e ':.*\<[hsf]w\>' \
 	-e ':.*\<l[234]\>' \
 	-e ':.*\<api\>' \
-	-e ':.*\<arm\>' \
-	-e ':.*\<armv7\>' \
-	-e ':.*\<armv8\>' \
+	-e ':.*\<ARM\>' \
+	-e ':.*\<(Aarch64|AArch64|AARCH64|Aarch32|AArch32|AARCH32)\>' \
+	-e ':.*\<(Armv7|ARMv7|ArmV7|armV7|ARMV7)\>' \
+	-e ':.*\<(Armv8|ARMv8|ArmV8|armV8|ARMV8)\>' \
 	-e ':.*\<crc\>' \
 	-e ':.*\<dma\>' \
 	-e ':.*\<eeprom\>' \
#4 lore raw

27/12/2018 13:34, Jerin Jacob Kollanukkaran:

Quoted 5 lines · Gavin Hu
Quoted 4 lines

Change to the new wording according to Arm corp:
https://mails.dpdk.org/archives/dev/2018-October/115174.html
otherwise, "Wrong headline lowercase" may be falsely reported.

Quoted 8 lines
Quoted 4 lines
Fixes f146ada21d1e ("scripts: add more git log checks")

Looks good to me.

Applied, thanks