libaio: Extend to native

PATCH In review Peter Kjellerstedt 2 participants 6 messages Dec 22, 2018 – Feb 25, 2019 Arm/Amlogic Meson SoC support

lore

Share & tools

lore

Peter Kjellerstedt

author

2018-12-22 22:13 UTC #0 lore raw

PATCH 1/2 libaio: Extend to native

From: Peter Kjellerstedt <[email protected]>

lvm2 currently requires libaio. So building lvm2-native will result in the following error.

ERROR: Required build target 'lvm2-native' has no buildable providers. Missing or unbuildable dependency chain was: ['lvm2-native', 'libaio-native']

Extend libaio to native to fix this issue.

Signed-off-by Peter Kjellerstedt <[email protected]>

Signed-off-by Richard Purdie <[email protected]>

---

This is a backport from master.

 meta/recipes-extended/libaio/libaio_0.3.111.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

meta/recipes-extended/libaio/libaio_0.3.111.bb +1 -1

index 04b50b61ec..8e1cd349a0 100644
@@ -20,4 +20,4 @@ do_install () {
     oe_runmake install DESTDIR=${D}
 }
 
-BBCLASSEXTEND = "nativesdk"
+BBCLASSEXTEND = "native nativesdk"

Signature · 1 line

2.12.0

Peter Kjellerstedt

author

2018-12-22 22:13 UTC #1 lore raw

PATCH 2/2 meson: Correct use of the _append operator

From: Peter Kjellerstedt <[email protected]>

The value to SRC_URI_append_class-native was not prefixed with a space. This was not noticed as the SRC_URI before applying the _append contains trailing spaces. However, if one, e.g., has a .bbappend and adds to the SRC_URI using SRC_URI += "file://foo.patch", then there no longer is any trailing space and the _append concatenates the two URIs together, leading to a build failue.

Signed-off-by Peter Kjellerstedt <[email protected]>

Signed-off-by Richard Purdie <[email protected]>

---

This is a backport from master.

 meta/recipes-devtools/meson/meson.inc | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

meta/recipes-devtools/meson/meson.inc +4 -3

index b7fb3e698a..40b29d5802 100644
@@ -15,9 +15,10 @@ SRC_URI = "https://github.com/mesonbuild/meson/releases/download/${PV}/meson-${P
 SRC_URI[sha256sum] = "92d8afd921751261e36151643464efd3394162f69efbe8cd53e0a66b1cf395eb"
 SRC_URI[md5sum] = "31bda3519d8c0eb3438267268a78085e"
 
-SRC_URI_append_class-native = "file://0002-Make-CPU-family-warnings-fatal.patch \
-                               file://0001-Support-building-allarch-recipes-again.patch \
-                               "
+SRC_URI_append_class-native = " \
+    file://0002-Make-CPU-family-warnings-fatal.patch \
+    file://0001-Support-building-allarch-recipes-again.patch \
+"
 
 UPSTREAM_CHECK_URI = "https://github.com/mesonbuild/meson/releases"

Signature · 1 line

2.12.0

akuster808

2018-12-23 16:48 UTC #2 lore raw

Re: [thud][PATCH 2/2] meson: Correct use of the _append operator

Quoted 11 lines · Peter Kjellerstedt

From: Peter Kjellerstedt <[email protected]>
The value to SRC_URI_append_class-native was not prefixed with a space. This was not noticed as the SRC_URI before applying the _append contains trailing spaces. However, if one, e.g., has a .bbappend and adds to the SRC_URI using SRC_URI += "file://foo.patch", then there no longer is any trailing space and the _append concatenates the two URIs together, leading to a build failue.
Signed-off-by Peter Kjellerstedt <[email protected]>
Signed-off-by Richard Purdie <[email protected]>

This is stagged in stable/thud-nmut.

thanks.

Quoted 25 lines

---

This is a backport from master.

 meta/recipes-devtools/meson/meson.inc | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

meta/recipes-devtools/meson/meson.inc +4 -3

index b7fb3e698a..40b29d5802 100644
@@ -15,9 +15,10 @@ SRC_URI = "https://github.com/mesonbuild/meson/releases/download/${PV}/meson-${P
 SRC_URI[sha256sum] = "92d8afd921751261e36151643464efd3394162f69efbe8cd53e0a66b1cf395eb"
 SRC_URI[md5sum] = "31bda3519d8c0eb3438267268a78085e"
 
-SRC_URI_append_class-native = "file://0002-Make-CPU-family-warnings-fatal.patch \
-                               file://0001-Support-building-allarch-recipes-again.patch \
-                               "
+SRC_URI_append_class-native = " \
+    file://0002-Make-CPU-family-warnings-fatal.patch \
+    file://0001-Support-building-allarch-recipes-again.patch \
+"
 
 UPSTREAM_CHECK_URI = "https://github.com/mesonbuild/meson/releases"

Peter Kjellerstedt

author

2019-02-22 11:00 UTC #3 lore raw

In reply to Peter Kjellerstedt

*ping*

//Peter

Quoted 37 lines

-----Original Message-----
From: [email protected] <[email protected]> On Behalf Of Peter Kjellerstedt
Sent: den 22 december 2018 23:13
To: [email protected]
Subject: [OE-core] [thud][PATCH 1/2] libaio: Extend to native
From: Peter Kjellerstedt <[email protected]>
lvm2 currently requires libaio. So building lvm2-native will result in the following error.
ERROR: Required build target 'lvm2-native' has no buildable providers. Missing or unbuildable dependency chain was: ['lvm2-native', 'libaio-native']
Extend libaio to native to fix this issue.
Signed-off-by Peter Kjellerstedt <[email protected]>
Signed-off-by Richard Purdie <[email protected]>
---
This is a backport from master.
 meta/recipes-extended/libaio/libaio_0.3.111.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-extended/libaio/libaio_0.3.111.bb +1 -2
index 04b50b61ec..8e1cd349a0 100644
@@ -20,4 +20,4 @@ do_install () {
     oe_runmake install DESTDIR=${D}
 }
 
-BBCLASSEXTEND = "nativesdk"
+BBCLASSEXTEND = "native nativesdk"
--
2.12.0

akuster808

2019-02-22 15:20 UTC #4 lore raw

Quoted 3 lines · Peter Kjellerstedt

*ping*
//Peter

you mean this?
http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/meta/recipes-extended/libaio?h=thud&id=40350b46d5c053b4336cc128922f44ce80e7da9a

Quoted 38 lines

Quoted 38 lines
-----Original Message-----
From: [email protected] <[email protected]> On Behalf Of Peter Kjellerstedt
Sent: den 22 december 2018 23:13
To: [email protected]
Subject: [OE-core] [thud][PATCH 1/2] libaio: Extend to native
From: Peter Kjellerstedt <[email protected]>
lvm2 currently requires libaio. So building lvm2-native will result in the following error.
ERROR: Required build target 'lvm2-native' has no buildable providers. Missing or unbuildable dependency chain was: ['lvm2-native', 'libaio-native']
Extend libaio to native to fix this issue.
Signed-off-by Peter Kjellerstedt <[email protected]>
Signed-off-by Richard Purdie <[email protected]>
---
This is a backport from master.
 meta/recipes-extended/libaio/libaio_0.3.111.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-extended/libaio/libaio_0.3.111.bb +1 -2
index 04b50b61ec..8e1cd349a0 100644
@@ -20,4 +20,4 @@ do_install () {
     oe_runmake install DESTDIR=${D}
 }
 
-BBCLASSEXTEND = "nativesdk"
+BBCLASSEXTEND = "native nativesdk"
--
2.12.0

Peter Kjellerstedt

author

2019-02-25 11:38 UTC #5 lore raw

Quoted 7 lines

-----Original Message-----
From: akuster808 <[email protected]>
Sent: den 22 februari 2019 16:21
To: Peter Kjellerstedt <[email protected]>
Cc: [email protected]
Subject: Re: [OE-core] [thud][PATCH 1/2] libaio: Extend to native

Quoted 8 lines

Quoted 3 lines · Peter Kjellerstedt
*ping*
//Peter
you mean this?
http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/meta/recipes-
extended/libaio?h=thud&id=40350b46d5c053b4336cc128922f44ce80e7da9a

No. That one extended the recipe to nativesdk, my patch extends it for native as well.

This is the one I want:

https://patchwork.openembedded.org/patch/157392/

//Peter

Quoted 43 lines

Quoted 2 lines
Quoted 2 lines
-----Original Message-----
From: [email protected]
<[email protected]> On Behalf Of Peter Kjellerstedt
Quoted 7 lines
Quoted 7 lines
Sent: den 22 december 2018 23:13
To: [email protected]
Subject: [OE-core] [thud][PATCH 1/2] libaio: Extend to native
From: Peter Kjellerstedt <[email protected]>
lvm2 currently requires libaio. So building lvm2-native will result
in
Quoted 3 lines
Quoted 3 lines
the following error.
ERROR: Required build target 'lvm2-native' has no buildable
providers.
Quoted 1 line
Quoted 1 line
Missing or unbuildable dependency chain was: ['lvm2-native',
'libaio-native']
Quoted 7 lines
Quoted 7 lines
Extend libaio to native to fix this issue.
Signed-off-by Peter Kjellerstedt <[email protected]>
Signed-off-by Richard Purdie <[email protected]>
---
Quoted 6 lines
Review
Quoted 6 lines
This is a backport from master.
 meta/recipes-extended/libaio/libaio_0.3.111.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0
b/meta/recipes-extended/libaio/libaio_0.3.111.bb
Quoted 11 lines
Quoted 11 lines
index 04b50b61ec..8e1cd349a0 100644
meta/recipes-extended/libaio/libaio_0.3.111.bb +1 -2
@@ -20,4 +20,4 @@ do_install () {
     oe_runmake install DESTDIR=${D}
 }
 
-BBCLASSEXTEND = "nativesdk"
+BBCLASSEXTEND = "native nativesdk"
--
2.12.0