usb: chipidea: fix static checker warning for NULL pointer

PATCH New Peter Chen 1 participant 1 message Dec 24, 2018

Subsystems (3)

USB Arm i.MX and Layerscape Chipidea USB high speed dual role controller

lore

Share & tools

lore

Peter Chen

author

2018-12-24 01:18 UTC #0 lore raw

PATCH 1/1 usb: chipidea: fix static checker warning for NULL pointer

During the static checker, "data->usbmisc_data" may be NULL. Fix it by this pointer judgement before using.

Reported-by Dan Carpenter <[email protected]>

Signed-off-by Peter Chen <[email protected]>

---
 drivers/usb/chipidea/ci_hdrc_imx.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

drivers/usb/chipidea/ci_hdrc_imx.c +2 -1

index e81de9ca8729..9b45aa422e69 100644
@@ -316,7 +316,8 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev)
 	if (IS_ERR(data->usbmisc_data))
 		return PTR_ERR(data->usbmisc_data);
 
-	if (of_usb_get_phy_mode(dev->of_node) == USBPHY_INTERFACE_MODE_HSIC) {
+	if ((of_usb_get_phy_mode(dev->of_node) == USBPHY_INTERFACE_MODE_HSIC)
+		&& data->usbmisc_data) {
 		pdata.flags |= CI_HDRC_IMX_IS_HSIC;
 		data->usbmisc_data->hsic = 1;
 		data->pinctrl = devm_pinctrl_get(dev);