perfmon: use ARRAY_SIZE() macro
PATCH 1/1 perfmon: use ARRAY_SIZE() macro
Use ARRAY_SIZE instead of dividing sizeof array with sizeof an element or, as in this particular case, sizeof the structure name.
This issue was detected with the help of Coccinelle.
Signed-off-by Gustavo A. R. Silva <[email protected]>
--- arch/ia64/kernel/perfmon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/ia64/kernel/perfmon.c +1 -1
@@ -4644,7 +4644,7 @@ static pfm_cmd_desc_t pfm_cmd_tab[]={/* 32 */ PFM_CMD (pfm_write_ibrs,PFM_CMD_PCLRWS ,PFM_CMD_ARG_MANY , pfarg_dbreg_t,NULL ), /* 33 */PFM_CMD(pfm_write_dbrs, PFM_CMD_PCLRWS, PFM_CMD_ARG_MANY, pfarg_dbreg_t, NULL) }; -#define PFM_CMD_COUNT (sizeof(pfm_cmd_tab)/sizeof(pfm_cmd_desc_t)) +#define PFM_CMD_COUNT ARRAY_SIZE(pfm_cmd_tab)static int pfm_check_task_state (pfm_context_t *ctx,int cmd,unsigned long flags)
Signature · 1 line
2.20.1
Hi,
Friendly ping:
Who can take this, please?
Thanks
--
Gustavo
Quoted 24 lines · Gustavo A. R. Silva
Use
ARRAY_SIZEinstead of dividing sizeof array with sizeof an element or, as in this particular case, sizeof the structure name.This issue was detected with the help of Coccinelle.
Signed-off-by Gustavo A. R. Silva <[email protected]>--- arch/ia64/kernel/perfmon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/ia64/kernel/perfmon.c +1
-1@@ -4644,7 +4644,7 @@ static pfm_cmd_desc_t pfm_cmd_tab[]={/* 32 */ PFM_CMD (pfm_write_ibrs,PFM_CMD_PCLRWS ,PFM_CMD_ARG_MANY , pfarg_dbreg_t,NULL ), /* 33 */PFM_CMD(pfm_write_dbrs, PFM_CMD_PCLRWS, PFM_CMD_ARG_MANY, pfarg_dbreg_t, NULL) }; -#define PFM_CMD_COUNT (sizeof(pfm_cmd_tab)/sizeof(pfm_cmd_desc_t)) +#define PFM_CMD_COUNT ARRAY_SIZE(pfm_cmd_tab)static int pfm_check_task_state (pfm_context_t *ctx,int cmd,unsigned long flags)