qcom-scm: Include <linux/err.h> header

Since commit e6f6d63ed14c ("drm/msm: add headless gpu device for imx5") the DRM_MSM symbol can be selected by SOC_IMX5 causing the following error when building imx_v6_v7_defconfig:

In file included from ../drivers/gpu/drm/msm/adreno/a5xx_gpu.c:17:0:
../include/linux/qcom_scm.h: In function 'qcom_scm_set_cold_boot_addr':
../include/linux/qcom_scm.h:73:10: error: 'ENODEV' undeclared (first use in this function)
return -ENODEV;

Include the <linux/err.h> header file to fix this problem.

Reported-by kernelci.org bot <[email protected]>

Fixes e6f6d63ed14c ("drm/msm: add headless gpu device for imx5")

Signed-off-by Fabio Estevam <[email protected]>

---
 include/linux/qcom_scm.h | 1 +
 1 file changed, 1 insertion(+)

include/linux/qcom_scm.h +1 -0

index 06996ad4f2bc..ce5a476fd733 100644
@@ -13,6 +13,7 @@
 #ifndef __QCOM_SCM_H
 #define __QCOM_SCM_H
 
+#include <linux/err.h>
 #include <linux/types.h>
 #include <linux/cpumask.h>
 

Signature · 1 line

2.17.1

Quoted 11 lines · Fabio Estevam

Since commit e6f6d63ed14c ("drm/msm: add headless gpu device for imx5") the DRM_MSM symbol can be selected by SOC_IMX5 causing the following error when building imx_v6_v7_defconfig:

In file included from ../drivers/gpu/drm/msm/adreno/a5xx_gpu.c:17:0:
../include/linux/qcom_scm.h: In function 'qcom_scm_set_cold_boot_addr':
../include/linux/qcom_scm.h:73:10: error: 'ENODEV' undeclared (first use in this function)
return -ENODEV;

Include the <linux/err.h> header file to fix this problem.

Reviewed-by Bjorn Andersson <[email protected]>

Andy, please pick up for inclusion in -rc

Fabio, please use get_maintainers, so your patches hits the appropriate mailing lists (linux-arm-msm@ in this case)

Regards,
Bjorn

Quoted 15 lines

Reported-by kernelci.org bot <[email protected]>

Fixes e6f6d63ed14c ("drm/msm: add headless gpu device for imx5")

Signed-off-by Fabio Estevam <[email protected]>

---
  include/linux/qcom_scm.h | 1 +
  1 file changed, 1 insertion(+)

include/linux/qcom_scm.h +0 -0

index 06996ad4f2bc..ce5a476fd733 100644
@@ -13,6 +13,7 @@
  #ifndef __QCOM_SCM_H
  #define __QCOM_SCM_H
 

Quoted 7 lines

include/linux/qcom_scm.h +1 -0

+#include <linux/err.h>
  #include <linux/types.h>
  #include <linux/cpumask.h>
 

Signature · 1 line

2.17.1

FYI, I already had a patch fixing this error (it is in linux-next: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/include/linux/qcom_scm.h).
This one is probably better though.

Quoted 31 lines · Fabio Estevam

Quoted 5 lines

Since commit e6f6d63ed14c ("drm/msm: add headless gpu device for imx5") the DRM_MSM symbol can be selected by SOC_IMX5 causing the following error when building imx_v6_v7_defconfig:

Quoted 7 lines

In file included from ../drivers/gpu/drm/msm/adreno/a5xx_gpu.c:17:0:
../include/linux/qcom_scm.h: In function 'qcom_scm_set_cold_boot_addr':
../include/linux/qcom_scm.h:73:10: error: 'ENODEV' undeclared (first use in this function)
return -ENODEV;

Include the <linux/err.h> header file to fix this problem.

Reviewed-by Bjorn Andersson <[email protected]>

Andy, please pick up for inclusion in -rc

Fabio, please use get_maintainers, so your patches hits the appropriate mailing lists (linux-arm-msm@ in this case)

Regards,
Bjorn

Quoted 7 lines

Reported-by kernelci.org bot <[email protected]>

Fixes e6f6d63ed14c ("drm/msm: add headless gpu device for imx5")

Signed-off-by Fabio Estevam <[email protected]>

---
  include/linux/qcom_scm.h | 1 +
  1 file changed, 1 insertion(+)

Quoted 5 lines

Quoted 5 lines

include/linux/qcom_scm.h +0 -0

index 06996ad4f2bc..ce5a476fd733 100644
@@ -13,6 +13,7 @@

Quoted 8 lines

Quoted 8 lines

include/linux/qcom_scm.h +1 -0

  #ifndef __QCOM_SCM_H
  #define __QCOM_SCM_H
+#include <linux/err.h>
  #include <linux/types.h>
  #include <linux/cpumask.h>

Signature · 1 line

2.17.1

Quoted 9 lines · Fabio Estevam

Since commit e6f6d63ed14c ("drm/msm: add headless gpu device for imx5") the DRM_MSM symbol can be selected by SOC_IMX5 causing the following error when building imx_v6_v7_defconfig:

In file included from ../drivers/gpu/drm/msm/adreno/a5xx_gpu.c:17:0:
../include/linux/qcom_scm.h: In function 'qcom_scm_set_cold_boot_addr':
../include/linux/qcom_scm.h:73:10: error: 'ENODEV' undeclared (first use in this function)
return -ENODEV;

Quoted 2 lines

Include the <linux/err.h> header file to fix this problem.

Reviewed-by Bjorn Andersson <[email protected]>

Andy, please pick up for inclusion in -rc

Fabio, please use get_maintainers, so your patches hits the appropriate mailing lists (linux-arm-msm@ in this case)

By the way, I just ran get_maintainers in this patch and linux-arm-msm is not listed.

Hi Bjorn,

Quoted 2 lines · Fabio Estevam

By the way, I just ran get_maintainers in this patch and linux-arm-msm is not listed.

Would you like to me to submit a patch like this to fix this problem?

Quoted 1 line

Andy, please pick up for inclusion in -rc

Yes, it would be really nice if we could get this fix into 4.20-rc1 so that imx_v6_v7_defconfig could be built.

Hi Bjorn,

On Fri, Dec 28, 2018 at 5:31 PM Bjorn Andersson
<[email protected]> wrote:

Quoted 2 lines

Fabio, please use get_maintainers, so your patches hits the appropriate mailing lists (linux-arm-msm@ in this case)

By the way, I just ran get_maintainers in this patch and linux-arm-msm is not listed.

Sorry about that, I forgot that the header file is not covered by the MAINTAINERS file.

Your second patch looks good, but I'm hoping we can merge the upcoming v3 of Amit's patch right after the merge window. It fixes this and a lot of other pieces where we would like to include linux-arm-msm@:

https://lore.kernel.org/lkml/d153a86748f99526e7790bfc4ef8781a2016fd51.1545126964.git.amit.kucheria@linaro.org/

Hi Bjorn,

Quoted 8 lines · Bjorn Andersson

Sorry about that, I forgot that the header file is not covered by the MAINTAINERS file.

Your second patch looks good, but I'm hoping we can merge the upcoming v3 of Amit's patch right after the merge window. It fixes this and a lot of other pieces where we would like to include linux-arm-msm@:

https://lore.kernel.org/lkml/d153a86748f99526e7790bfc4ef8781a2016fd51.1545126964.git.amit.kucheria@linaro.org/

Amit's patch adds the following entry:

+F: include/linux/*/qcom*

but it does not catch include/linux/qcom_scm.h

It also needs

+F: include/linux/qcom*

in order to catch include/linux/qcom-geni-se.h and include/linux/qcom_scm.h

I can add that entry after Amit's patch gets applied.

Quoted 22 lines · Fabio Estevam

Hi Bjorn,

Quoted 8 lines · Bjorn Andersson

Sorry about that, I forgot that the header file is not covered by the MAINTAINERS file.

Your second patch looks good, but I'm hoping we can merge the upcoming v3 of Amit's patch right after the merge window. It fixes this and a lot of other pieces where we would like to include linux-arm-msm@:

https://lore.kernel.org/lkml/d153a86748f99526e7790bfc4ef8781a2016fd51.1545126964.git.amit.kucheria@linaro.org/

Amit's patch adds the following entry:

+F: include/linux/*/qcom*

but it does not catch include/linux/qcom_scm.h

It also needs

Quoted 5 lines

+F: include/linux/qcom*

in order to catch include/linux/qcom-geni-se.h and include/linux/qcom_scm.h

I can add that entry after Amit's patch gets applied.

Or I can add it to Amit's. I'll ping him to make sure that's ok.

Quoted 24 lines · Andy Gross

Quoted 22 lines · Fabio Estevam

Hi Bjorn,

Quoted 8 lines · Bjorn Andersson

Sorry about that, I forgot that the header file is not covered by the MAINTAINERS file.

Your second patch looks good, but I'm hoping we can merge the upcoming v3 of Amit's patch right after the merge window. It fixes this and a lot of other pieces where we would like to include linux-arm-msm@:

https://lore.kernel.org/lkml/d153a86748f99526e7790bfc4ef8781a2016fd51.1545126964.git.amit.kucheria@linaro.org/

Amit's patch adds the following entry:

+F: include/linux/*/qcom*

but it does not catch include/linux/qcom_scm.h

It also needs

Quoted 8 lines

Quoted 5 lines

+F: include/linux/qcom*

in order to catch include/linux/qcom-geni-se.h and include/linux/qcom_scm.h

I can add that entry after Amit's patch gets applied.

Or I can add it to Amit's. I'll ping him to make sure that's ok.

I'd forgotten about this patch! Just sent out v3 which is still missing "F: include/linux/qcom*".

Let me know if you want me to send out v4 with this added.

Regards,
Amit

Perhaps I am confused but it appears that this patch has already landed upstream and got included in 5.0-rc2:

Hi Chris,

Quoted 1 line · Chris Healy

Quoted 2 lines

Perhaps I am confused but it appears that this patch has already landed upstream and got included in 5.0-rc2:

The patch that Amit is referring is the following entry in MAINTAINERS file:

+F: include/linux/qcom*

so that the proper lists can be put on Cc on future changes of this file.

Since commit e6f6d63ed14c ("drm/msm: add headless gpu device for imx5") the DRM_MSM symbol can be selected by SOC_IMX5 causing the following error when building imx_v6_v7_defconfig:

In file included from ../drivers/gpu/drm/msm/adreno/a5xx_gpu.c:17:0:
../include/linux/qcom_scm.h: In function 'qcom_scm_set_cold_boot_addr':
../include/linux/qcom_scm.h:73:10: error: 'ENODEV' undeclared (first use in this function)
return -ENODEV;

Include the <linux/err.h> header file to fix this problem.

Reported-by kernelci.org bot <[email protected]>

Fixes e6f6d63ed14c ("drm/msm: add headless gpu device for imx5")

Signed-off-by Fabio Estevam <[email protected]>

Reviewed-by Bjorn Andersson <[email protected]>

---
 include/linux/qcom_scm.h | 1 +
 1 file changed, 1 insertion(+)

include/linux/qcom_scm.h +1 -0

index 06996ad4f2bc..ce5a476fd733 100644
@@ -13,6 +13,7 @@
 #ifndef __QCOM_SCM_H
 #define __QCOM_SCM_H
 
+#include <linux/err.h>
 #include <linux/types.h>
 #include <linux/cpumask.h>