Skip to contentSkip to conversation

clk: qoriq: fix refcount leak in clockgen_init()

PATCH Applied Yangtao Li 2 participants 2 messages Dec 26, 2018 – Dec 28, 2018 Common clk

lore
Share & tools
lore

Yangtao Li

author
#0 lore raw

PATCH 1/1 clk: qoriq: fix refcount leak in clockgen_init()

The of_find_compatible_node() returns a node pointer with refcount incremented, but there is the lack of use of the of_node_put() when done. Add the missing of_node_put() to release the refcount.

---
 drivers/clk/clk-qoriq.c | 1 +
 1 file changed, 1 insertion(+)
drivers/clk/clk-qoriq.c +1 -0
index 4c30b6e799ed..97a0029a1cca 100644
@@ -1389,6 +1389,7 @@ static void __init clockgen_init(struct device_node *np)
 				pr_err("%s: Couldn't map %pOF regs\n", __func__,
 				       guts);
 			}
+			of_node_put(guts);
 		}
 
 	}
Signature · 1 line
2.17.0
maintainer Applied
#1 lore raw

Quoting Yangtao Li (2018-12-26 05:14:42)

Quoted 6 lines

The of_find_compatible_node() returns a node pointer with refcount incremented, but there is the lack of use of the of_node_put() when done. Add the missing of_node_put() to release the refcount.

---

Applied to clk-next