Skip to contentSkip to conversation

clk: samsung: exynos4: fix refcount leak in exynos4_get_xom()

PATCH Applied Yangtao Li 2 participants 2 messages Dec 26, 2018 – Dec 28, 2018

Subsystems (3)
lore
Share & tools
lore

Yangtao Li

author
#0 lore raw

PATCH 1/1 clk: samsung: exynos4: fix refcount leak in exynos4_get_xom()

The of_find_compatible_node() returns a node pointer with refcount incremented, but there is the lack of use of the of_node_put() when done. Add the missing of_node_put() to release the refcount.

---
 drivers/clk/samsung/clk-exynos4.c | 1 +
 1 file changed, 1 insertion(+)
drivers/clk/samsung/clk-exynos4.c +1 -0
index 59d4d46667ce..54066e6508d3 100644
@@ -1028,6 +1028,7 @@ static unsigned long __init exynos4_get_xom(void)
 			xom = readl(chipid_base + 8);
 
 		iounmap(chipid_base);
+		of_node_put(np);
 	}
 
 	return xom;
Signature · 1 line
2.17.0
maintainer Applied
#1 lore raw

Quoting Yangtao Li (2018-12-26 05:32:15)

Quoted 6 lines

The of_find_compatible_node() returns a node pointer with refcount incremented, but there is the lack of use of the of_node_put() when done. Add the missing of_node_put() to release the refcount.

---

Applied to clk-next