Skip to contentSkip to conversation

clk: vf610: fix refcount leak in vf610_clocks_init()

PATCH Applied Yangtao Li 2 participants 2 messages Dec 26, 2018 – Dec 28, 2018

Subsystems (3)
lore
Share & tools
lore

Yangtao Li

author
#0 lore raw

PATCH 1/1 clk: vf610: fix refcount leak in vf610_clocks_init()

The of_find_compatible_node() returns a node pointer with refcount incremented, but there is the lack of use of the of_node_put() when done. Add the missing of_node_put() to release the refcount.

---
 drivers/clk/imx/clk-vf610.c | 1 +
 1 file changed, 1 insertion(+)
drivers/clk/imx/clk-vf610.c +1 -0
index 6dae54325a91..a334667c450a 100644
@@ -203,6 +203,7 @@ static void __init vf610_clocks_init(struct device_node *ccm_node)
 	np = of_find_compatible_node(NULL, NULL, "fsl,vf610-anatop");
 	anatop_base = of_iomap(np, 0);
 	BUG_ON(!anatop_base);
+	of_node_put(np);
 
 	np = ccm_node;
 	ccm_base = of_iomap(np, 0);
Signature · 1 line
2.17.0
maintainer Applied
#1 lore raw

Quoting Yangtao Li (2018-12-26 05:59:36)

Quoted 6 lines

The of_find_compatible_node() returns a node pointer with refcount incremented, but there is the lack of use of the of_node_put() when done. Add the missing of_node_put() to release the refcount.

---

Applied to clk-next