Skip to contentSkip to conversation

ext4/034: adjust commit which fixes the problem tested by ext4/034

PATCH In review Theodore Ts'o 2 participants 3 messages Dec 26, 2018 – Dec 29, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ext4/034: adjust commit which fixes the problem tested by ext4/034

Also add a requirment that fallocate and fiemap is supported. (Fallocate isn't the case when we are emulating ext3, for example.)

---
 tests/ext4/034 | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
tests/ext4/034 +3 -1
index 5c34d0d9..f9e4bfaf 100755
@@ -8,7 +8,7 @@
 # "-o dioread_nolock,nodelalloc" is used.
 #
 # The bug was fixed by commit
-# "Ext4: fix ENOSPC when both quota and dioread_nolock are enabled"
+# "ext4: make sure enough credits are reserved for dioread_nolock writes"
 #
 seq=`basename $0`
 seqres=$RESULT_DIR/$seq
@@ -41,6 +41,8 @@ _supported_os Linux
 _require_scratch
 _require_quota
 _require_nobody
+_require_xfs_io_command "falloc"
+_require_xfs_io_command "fiemap"
 _require_xfs_io_command "syncfs"
 
 echo "Format and mount"
Signature · 1 line
2.19.1
#1 lore raw
Quoted 5 lines · Theodore Ts'o

Also add a requirment that fallocate and fiemap is supported. (Fallocate isn't the case when we are emulating ext3, for example.)

Patch looks good, but I assume you meant to send it to [email protected] not [email protected] :)

Thanks,
Eryu

Quoted 29 lines
---
 tests/ext4/034 | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
tests/ext4/034 +3 -1
index 5c34d0d9..f9e4bfaf 100755
@@ -8,7 +8,7 @@
 # "-o dioread_nolock,nodelalloc" is used.
 #
 # The bug was fixed by commit
-# "Ext4: fix ENOSPC when both quota and dioread_nolock are enabled"
+# "ext4: make sure enough credits are reserved for dioread_nolock writes"
 #
 seq=`basename $0`
 seqres=$RESULT_DIR/$seq
@@ -41,6 +41,8 @@ _supported_os Linux
 _require_scratch
 _require_quota
 _require_nobody
+_require_xfs_io_command "falloc"
+_require_xfs_io_command "fiemap"
 _require_xfs_io_command "syncfs"
 
 echo "Format and mount"
Signature · 1 line
2.19.1