Skip to contentSkip to conversation

omap3: igep00x0: Remove unmaintained IGEP0032 defconfig

PATCH New Enric Balletbo i Serra 2 participants 11 messages Dec 27, 2018 – Jan 16, 2019 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH 1/5 omap3: igep00x0: Remove unmaintained IGEP0032 defconfig

The IGEP0032 board was never officially pushed upstream and actually I don't have access to this hardware, unless someone with the hardware wants to start working on this doesn't makes sense have this defconfig here. So remove it.

---
 board/isee/igep00x0/MAINTAINERS |  1 -
 configs/igep0032_defconfig      | 52 ---------------------------------
 2 files changed, 53 deletions(-)
 delete mode 100644 configs/igep0032_defconfig
board/isee/igep00x0/MAINTAINERS +0 -1
index d75d400eed..a07c9f49a8 100644
@@ -4,4 +4,3 @@ S:	Maintained
 F:	board/isee/igep00x0/
 F:	include/configs/omap3_igep00x0.h
 F:	configs/igep00x0_defconfig
-F:	configs/igep0032_defconfig
configs/igep0032_defconfig deleted +0 -52

52 lines not on this page · raw message

Signature · 1 line
2.19.2
#1 lore raw

PATCH 2/5 omap3: igep00x0: Remove USB support due DM_USB deadline

The USB support for this board was never really tested, in fact, the presence of these options are more a copy & paste error from the Beagleboard than a feature that really was used. As doesn't work, remove for now. If someone at some point want to add this support he'll need to migrate the board to use CONFIG_DM_USB instead.

---
 configs/igep00x0_defconfig       |  4 ----
 include/configs/omap3_igep00x0.h | 10 ----------
 2 files changed, 14 deletions(-)
configs/igep00x0_defconfig +0 -4
index f2989e34e1..ba32609eab 100644
@@ -42,10 +42,6 @@ CONFIG_SMC911X_32_BIT=y
 CONFIG_CONS_INDEX=3
 CONFIG_SPI=y
 CONFIG_OMAP3_SPI=y
-CONFIG_USB=y
-CONFIG_USB_MUSB_UDC=y
-CONFIG_USB_OMAP3=y
-CONFIG_TWL4030_USB=y
 CONFIG_FAT_WRITE=y
 CONFIG_UBIFS_SILENCE_MSG=y
 CONFIG_BCH=y
include/configs/omap3_igep00x0.h +0 -10
index b9d6569752..7f3809d447 100644
@@ -36,16 +36,6 @@
 #define GPIO_IGEP00X0_BOARD_DETECTION		28
 #define GPIO_IGEP00X0_REVISION_DETECTION	129
 
-/* USB device configuration */
-#define CONFIG_USB_DEVICE		1
-#define CONFIG_USB_TTY			1
-
-/* Change these to suit your needs */
-#define CONFIG_USBD_VENDORID		0x0451
-#define CONFIG_USBD_PRODUCTID		0x5678
-#define CONFIG_USBD_MANUFACTURER	"Texas Instruments"
-#define CONFIG_USBD_PRODUCT_NAME	"IGEP"
-
 #ifndef CONFIG_SPL_BUILD
 
 /* Environment */
Signature · 1 line
2.19.2
#2 lore raw

PATCH 2/5 omap3: igep00x0: Remove USB support due DM_USB deadline

Quoted 7 lines · Enric Balletbo i Serra

The USB support for this board was never really tested, in fact, the presence of these options are more a copy & paste error from the Beagleboard than a feature that really was used. As doesn't work, remove for now. If someone at some point want to add this support he'll need to migrate the board to use CONFIG_DM_USB instead.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190115/c3150e7e/attachment.sig>
#3 lore raw

PATCH 3/5 omap3: igep00x0: Switch to using TI_COMMON_CMD_OPTION

In reply to Enric Balletbo i Serra

Enable TI_COMMON_CMD_OPTIONS and remove similar options from the defconfig.

---
 board/isee/igep00x0/Kconfig | 2 ++
 configs/igep00x0_defconfig  | 7 +------
 2 files changed, 3 insertions(+), 6 deletions(-)
board/isee/igep00x0/Kconfig +2 -0
index aa46882b05..597d6d92cf 100644
@@ -9,4 +9,6 @@ config SYS_VENDOR
 config SYS_CONFIG_NAME
 	default "omap3_igep00x0"
 
+source "board/ti/common/Kconfig"
+
 endif
configs/igep00x0_defconfig +1 -6
index ba32609eab..2c2da1e385 100644
@@ -1,5 +1,6 @@
 CONFIG_ARM=y
 CONFIG_ARCH_OMAP2PLUS=y
+CONFIG_TI_COMMON_CMD_OPTIONS=y
 CONFIG_TARGET_OMAP3_IGEP00X0=y
 CONFIG_SPL=y
 CONFIG_DISTRO_DEFAULTS=y
@@ -16,17 +17,11 @@ CONFIG_SPL_MTD_SUPPORT=y
 CONFIG_SPL_ONENAND_SUPPORT=y
 CONFIG_SPL_OS_BOOT=y
 CONFIG_CMD_SPL=y
-CONFIG_CMD_ASKENV=y
 # CONFIG_CMD_FLASH is not set
-CONFIG_CMD_GPIO=y
-CONFIG_CMD_I2C=y
-CONFIG_CMD_MMC=y
 CONFIG_CMD_NAND=y
 CONFIG_CMD_ONENAND=y
-CONFIG_CMD_SPI=y
 # CONFIG_CMD_SETEXPR is not set
 CONFIG_CMD_CACHE=y
-CONFIG_CMD_EXT4_WRITE=y
 CONFIG_CMD_MTDPARTS=y
 CONFIG_CMD_UBI=y
 # CONFIG_CMD_UBIFS is not set
Signature · 1 line
2.19.2
#4 lore raw

PATCH 3/5 omap3: igep00x0: Switch to using TI_COMMON_CMD_OPTION

Quoted 4 lines · Enric Balletbo i Serra

Enable TI_COMMON_CMD_OPTIONS and remove similar options from the defconfig.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190115/2be04521/attachment.sig>
#5 lore raw

PATCH 4/5 omap3: igep00x0: Switch to simple malloc in SPL

In reply to Enric Balletbo i Serra

To save more space, switch to simple malloc here.

---
 configs/igep00x0_defconfig | 1 +
 1 file changed, 1 insertion(+)
configs/igep00x0_defconfig +1 -0
index 2c2da1e385..b806f23fa5 100644
@@ -3,6 +3,7 @@ CONFIG_ARCH_OMAP2PLUS=y
 CONFIG_TI_COMMON_CMD_OPTIONS=y
 CONFIG_TARGET_OMAP3_IGEP00X0=y
 CONFIG_SPL=y
+CONFIG_SPL_SYS_MALLOC_SIMPLE=y
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_NR_DRAM_BANKS=2
 CONFIG_OF_BOARD_SETUP=y
Signature · 1 line
2.19.2
#6 lore raw

PATCH 4/5 omap3: igep00x0: Switch to simple malloc in SPL

Quoted 3 lines · Enric Balletbo i Serra

To save more space, switch to simple malloc here.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190115/56eba672/attachment.sig>
#7 lore raw

PATCH 5/5 omap3: igep00x0: Add Device Tree Support and DM_MMC driver

In reply to Enric Balletbo i Serra

This adds device tree for OMAP3 IGEP based boards and the DM_MMC driver.

---
 arch/arm/dts/Makefile                   |   3 +
 arch/arm/dts/omap3-igep.dtsi            | 250 ++++++++++++++++++++++
 arch/arm/dts/omap3-igep0020-common.dtsi | 264 ++++++++++++++++++++++++
 arch/arm/dts/omap3-igep0020-u-boot.dtsi |  24 +++
 arch/arm/dts/omap3-igep0020.dts         |  50 +++++
 configs/igep00x0_defconfig              |   3 +
 6 files changed, 594 insertions(+)
 create mode 100644 arch/arm/dts/omap3-igep.dtsi
 create mode 100644 arch/arm/dts/omap3-igep0020-common.dtsi
 create mode 100644 arch/arm/dts/omap3-igep0020-u-boot.dtsi
 create mode 100644 arch/arm/dts/omap3-igep0020.dts
arch/arm/dts/Makefile +3 -0
index dc6f6b233a..f5ec1c96c7 100644
@@ -520,6 +520,9 @@ dtb-$(CONFIG_TARGET_OMAP3_BEAGLE) += \
 	omap3-beagle-xm.dtb \
 	omap3-beagle.dtb
 
+dtb-$(CONFIG_TARGET_OMAP3_IGEP00X0) += \
+	omap3-igep0020.dtb
+
 dtb-$(CONFIG_TARGET_SAMA5D2_PTC_EK) += \
 	at91-sama5d2_ptc_ek.dtb
 
arch/arm/dts/omap3-igep.dtsi new file +250 -0

250 lines not on this page · raw message

arch/arm/dts/omap3-igep0020-common.dtsi new file +264 -0

264 lines not on this page · raw message

arch/arm/dts/omap3-igep0020-u-boot.dtsi new file +24 -0
new file mode 100644
index 0000000000..41beaf0900
@@ -0,0 +1,24 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * U-Boot additions
+ *
+ * (C) Copyright 2017 Derald D. Woods <[email protected]>
+ */
+
+/ {
+	chosen {
+		stdout-path = &uart3;
+	};
+};
+
+&uart1 {
+	reg-shift = <2>;
+};
+
+&uart2 {
+	reg-shift = <2>;
+};
+
+&uart3 {
+	reg-shift = <2>;
+};
arch/arm/dts/omap3-igep0020.dts new file +50 -0

50 lines not on this page · raw message

configs/igep00x0_defconfig +3 -0
index b806f23fa5..efd8519d14 100644
@@ -27,6 +27,9 @@ CONFIG_CMD_MTDPARTS=y
 CONFIG_CMD_UBI=y
 # CONFIG_CMD_UBIFS is not set
 CONFIG_NET_RANDOM_ETHADDR=y
+CONFIG_DEFAULT_DEVICE_TREE="omap3-igep0020"
+CONFIG_OF_CONTROL=y
+CONFIG_DM_MMC=y
 CONFIG_MMC_OMAP_HS=y
 CONFIG_NAND=y
 CONFIG_SYS_NAND_BUSWIDTH_16BIT=y
Signature · 1 line
2.19.2
#8 lore raw

PATCH 5/5 omap3: igep00x0: Add Device Tree Support and DM_MMC driver

Quoted 3 lines · Enric Balletbo i Serra

This adds device tree for OMAP3 IGEP based boards and the DM_MMC driver.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181227/e46e27b5/attachment.sig>
#9 lore raw

PATCH 5/5 omap3: igep00x0: Add Device Tree Support and DM_MMC driver

In reply to Enric Balletbo i Serra
Quoted 4 lines · Enric Balletbo i Serra

This adds device tree for OMAP3 IGEP based boards and the DM_MMC driver.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190115/17f49227/attachment.sig>
#10 lore raw

PATCH 1/5 omap3: igep00x0: Remove unmaintained IGEP0032 defconfig

In reply to Enric Balletbo i Serra
Quoted 6 lines · Enric Balletbo i Serra

The IGEP0032 board was never officially pushed upstream and actually I don't have access to this hardware, unless someone with the hardware wants to start working on this doesn't makes sense have this defconfig here. So remove it.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190115/a0c8fcb8/attachment.sig>