Skip to contentSkip to conversation

imx8mq_evk_defconfig: Move file system options to Kconfig

PATCH Superseded Fabio Estevam 3 participants 4 messages Dec 27, 2018 – Dec 29, 2018 Arm i.MX and Layerscape

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 imx8mq_evk_defconfig: Move file system options to Kconfig

Chris Spencer reports that when enabling ext4 read support without also enabling write support the following error is seen:

fs/fs.c:198:12: error: 'ext4_write_file' undeclared here (not in a function); did you mean 'ext4_read_file'?
.write = ext4_write_file,

            ^~~~~~~~~~~~~~~

Fix this problem by moving these options to Kconfig.

---
 configs/imx8mq_evk_defconfig | 5 +++++
 include/configs/imx8mq_evk.h | 6 ------
 2 files changed, 5 insertions(+), 6 deletions(-)
configs/imx8mq_evk_defconfig +5 -0
index f216d46a8f..b473fcd61b 100644
@@ -15,6 +15,11 @@ CONFIG_SPL_LOAD_FIT=y
 CONFIG_SPL=y
 CONFIG_SPL_BOARD_INIT=y
 CONFIG_HUSH_PARSER=y
+CONFIG_DOS_PARTITION=y
+CONFIG_CMD_EXT2=y
+CONFIG_CMD_EXT4=y
+CONFIG_CMD_EXT4_WRITE=y
+CONFIG_CMD_FAT=
 CONFIG_CMD_GPIO=y
 CONFIG_CMD_I2C=y
 CONFIG_CMD_CACHE=y
include/configs/imx8mq_evk.h +0 -6
index 35f81152f2..f0430224cb 100644
@@ -226,12 +226,6 @@
 #define CONFIG_SYS_FSL_USDHC_NUM	2
 #define CONFIG_SYS_FSL_ESDHC_ADDR       0
 
-#define CONFIG_DOS_PARTITION
-#define CONFIG_CMD_EXT2
-#define CONFIG_CMD_EXT4
-#define CONFIG_CMD_EXT4_WRITE
-#define CONFIG_CMD_FAT
-
 #define CONFIG_SUPPORT_EMMC_BOOT	/* eMMC specific */
 #define CONFIG_SYS_MMC_IMG_LOAD_PART	1
 
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 imx8mq_evk_defconfig: Move file system options to Kconfig

Quoted 11 lines

-----Original Message-----
From: Fabio Estevam [mailto:festevam at gmail.com]
Sent: 2018年12月28日 3:14
To: sbabic at denx.de
Cc: dl-uboot-imx <[email protected]>; u-boot at lists.denx.de; spencercw at gmail.com; Fabio Estevam <[email protected]>
Subject: [PATCH] imx8mq_evk_defconfig: Move file system options to Kconfig

Chris Spencer reports that when enabling ext4 read support without also enabling write support the following error is seen:

Quoted 8 lines

fs/fs.c:198:12: error: 'ext4_write_file' undeclared here (not in a function); did you mean 'ext4_read_file'?
.write = ext4_write_file,

            ^~~~~~~~~~~~~~~

Fix this problem by moving these options to Kconfig.

Quoted 38 lines
---
 configs/imx8mq_evk_defconfig | 5 +++++
 include/configs/imx8mq_evk.h | 6 ------
 2 files changed, 5 insertions(+), 6 deletions(-)
configs/imx8mq_evk_defconfig +0 -0
index f216d46a8f..b473fcd61b 100644
@@ -15,6 +15,11 @@ CONFIG_SPL_LOAD_FIT=y  CONFIG_SPL=y

CONFIG_SPL_BOARD_INIT=y CONFIG_HUSH_PARSER=y

configs/imx8mq_evk_defconfig +5 -0
+CONFIG_DOS_PARTITION=y
+CONFIG_CMD_EXT2=y
+CONFIG_CMD_EXT4=y
+CONFIG_CMD_EXT4_WRITE=y
+CONFIG_CMD_FAT=
 CONFIG_CMD_GPIO=y
 CONFIG_CMD_I2C=y
 CONFIG_CMD_CACHE=y
include/configs/imx8mq_evk.h +0 -7
index 35f81152f2..f0430224cb 100644
@@ -226,12 +226,6 @@
 #define CONFIG_SYS_FSL_USDHC_NUM	2
 #define CONFIG_SYS_FSL_ESDHC_ADDR       0
 
-#define CONFIG_DOS_PARTITION
-#define CONFIG_CMD_EXT2
-#define CONFIG_CMD_EXT4
-#define CONFIG_CMD_EXT4_WRITE
-#define CONFIG_CMD_FAT
-
 #define CONFIG_SUPPORT_EMMC_BOOT	/* eMMC specific */
 #define CONFIG_SYS_MMC_IMG_LOAD_PART	1
 
--

2.17.1

#2 lore raw

PATCH 1/1 imx8mq_evk_defconfig: Move file system options to Kconfig

Hi Fabio,

Joris Offouga

Quoted 27 lines · Peng Fan
Quoted 11 lines

-----Original Message-----
From: Fabio Estevam [mailto:festevam at gmail.com]
Sent: 2018年12月28日 3:14
To: sbabic at denx.de
Cc: dl-uboot-imx <[email protected]>; u-boot at lists.denx.de; spencercw at gmail.com; Fabio Estevam <[email protected]>
Subject: [PATCH] imx8mq_evk_defconfig: Move file system options to Kconfig

Chris Spencer reports that when enabling ext4 read support without also enabling write support the following error is seen:

Quoted 8 lines

fs/fs.c:198:12: error: 'ext4_write_file' undeclared here (not in a function); did you mean 'ext4_read_file'?
.write = ext4_write_file,

           ^~~~~~~~~~~~~~~

Fix this problem by moving these options to Kconfig.

Quoted 5 lines

---
configs/imx8mq_evk_defconfig | 5 +++++
include/configs/imx8mq_evk.h | 6 ------

2 files changed, 5 insertions(+), 6 deletions(-)
Quoted 11 lines

configs/imx8mq_evk_defconfig CONFIG_SPL_LOAD_FIT=y · line 22

Quoted 11 lines
configs/imx8mq_evk_defconfig +0 -0
index f216d46a8f..b473fcd61b 100644
@@ -15,6 +15,11 @@ CONFIG_SPL_LOAD_FIT=y  CONFIG_SPL=y

CONFIG_SPL_BOARD_INIT=y CONFIG_HUSH_PARSER=y

configs/imx8mq_evk_defconfig +5 -0
+CONFIG_DOS_PARTITION=y
+CONFIG_CMD_EXT2=y
+CONFIG_CMD_EXT4=y
+CONFIG_CMD_EXT4_WRITE=y
+CONFIG_CMD_FAT=

You forgot "y" to this line, correct this in CONFIG_CMD_FAT=y

Quoted 27 lines
Quoted 21 lines

CONFIG_CMD_GPIO=y
CONFIG_CMD_I2C=y
CONFIG_CMD_CACHE=y

include/configs/imx8mq_evk.h +0 -7
index 35f81152f2..f0430224cb 100644
@@ -226,12 +226,6 @@
 #define CONFIG_SYS_FSL_USDHC_NUM    2
 #define CONFIG_SYS_FSL_ESDHC_ADDR       0
 
-#define CONFIG_DOS_PARTITION
-#define CONFIG_CMD_EXT2
-#define CONFIG_CMD_EXT4
-#define CONFIG_CMD_EXT4_WRITE
-#define CONFIG_CMD_FAT
-
 #define CONFIG_SUPPORT_EMMC_BOOT    /* eMMC specific */
 #define CONFIG_SYS_MMC_IMG_LOAD_PART    1
 
--
Quoted 1 line

2.17.1

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot

author reviewer
#3 lore raw

PATCH 1/1 imx8mq_evk_defconfig: Move file system options to Kconfig

Hi Joris,

Quoted 1 line · Offouga Joris

You forgot "y" to this line, correct this in CONFIG_CMD_FAT=y

Thanks! I have just sent a corrected v2.