Skip to contentSkip to conversation

doc: fix a typo in testpmd user guide

PATCH Applied Rami Rosen 4 participants 5 messages Dec 27, 2018 – Jan 8, 2019

v1 of 2 Applied Latest is v2 →

lore
Share & tools
lore

Rami Rosen

author
#0 lore raw

PATCH 1/1 doc: fix a typo in testpmd user guide

This patch fixes a typo in testpmd user guide.

Fixes aac6f11f5864 ("app/testpmd: add ethernet peer command")
---
 doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
doc/guides/testpmd_app_ug/testpmd_funcs.rst +1 -1
index cbf23e928..ab40b9f5f 100644
@@ -1149,7 +1149,7 @@ set eth-peer
 
 Set the forwarding peer address for certain port::
 
-   testpmd> set eth-peer (port_id) (perr_addr)
+   testpmd> set eth-peer (port_id) (peer_addr)
 
 This is equivalent to the ``--eth-peer`` command-line option.
 
Signature · 1 line
2.19.2
#1 lore raw

-----Original Message-----
From: Rami Rosen [mailto:[email protected]]
Sent: Thursday, December 27, 2018 9:59 PM
To: [email protected]
Cc: [email protected]; Wisam Monther; Rami Rosen
Subject: [PATCH] doc: fix a typo in testpmd user guide

This patch fixes a typo in testpmd user guide.

Fixes aac6f11f5864 ("app/testpmd: add ethernet peer command")
---
 doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
doc/guides/testpmd_app_ug/testpmd_funcs.rst +1 -1
index cbf23e928..ab40b9f5f 100644
@@ -1149,7 +1149,7 @@ set eth-peer
 
 Set the forwarding peer address for certain port::
 
-   testpmd> set eth-peer (port_id) (perr_addr)
+   testpmd> set eth-peer (port_id) (peer_addr)
 
 This is equivalent to the ``--eth-peer`` command-line option.
 
Signature · 6 lines
2.19.2

Acked-by: Wisam Jaddo <[email protected]>

BRs,
Wisam Jaddo
Acked-by on v1 1/1
#2 lore raw
In reply to Rami Rosen

Hi Rami,

Quoted 33 lines

-----Original Message-----
From: dev [mailto:[email protected]] On Behalf Of Rami Rosen
Sent: Thursday, December 27, 2018 7:59 PM
To: [email protected]
Cc: [email protected]; [email protected]; Rami Rosen <[email protected]>
Subject: [dpdk-dev] [PATCH] doc: fix a typo in testpmd user guide

This patch fixes a typo in testpmd user guide.

Fixes aac6f11f5864 ("app/testpmd: add ethernet peer command")
---
 doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
doc/guides/testpmd_app_ug/testpmd_funcs.rst +1 -2
index cbf23e928..ab40b9f5f 100644
@@ -1149,7 +1149,7 @@ set eth-peer
 
 Set the forwarding peer address for certain port::
 
-   testpmd> set eth-peer (port_id) (perr_addr)
+   testpmd> set eth-peer (port_id) (peer_addr)
 
 This is equivalent to the ``--eth-peer`` command-line option.
 
--
Quoted 1 line

2.19.2

./dpdk/devtools/checkpatches.sh /home/bairemon/patches_19_02_rc1_patchwork_testpmd/doc-fix-a-typo-in-testpmd-user-guide.patch

### doc: fix a typo in testpmd user guide

WARNING:BAD_SIGN_OFF: Duplicate signature
#25:

total: 0 errors, 1 warnings, 8 lines checked

Otherwise

#3 lore raw
Quoted 39 lines · Bernard

Hi Rami,

Quoted 33 lines

-----Original Message-----
From: dev [mailto:[email protected]] On Behalf Of Rami Rosen
Sent: Thursday, December 27, 2018 7:59 PM
To: [email protected]
Cc: [email protected]; [email protected]; Rami Rosen <[email protected]>
Subject: [dpdk-dev] [PATCH] doc: fix a typo in testpmd user guide

This patch fixes a typo in testpmd user guide.

Fixes aac6f11f5864 ("app/testpmd: add ethernet peer command")
---
 doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
doc/guides/testpmd_app_ug/testpmd_funcs.rst +1 -2
index cbf23e928..ab40b9f5f 100644
@@ -1149,7 +1149,7 @@ set eth-peer
 
 Set the forwarding peer address for certain port::
 
-   testpmd> set eth-peer (port_id) (perr_addr)
+   testpmd> set eth-peer (port_id) (peer_addr)
 
 This is equivalent to the ``--eth-peer`` command-line option.
 
--
Quoted 1 line

2.19.2

./dpdk/devtools/checkpatches.sh /home/bairemon/patches_19_02_rc1_patchwork_testpmd/doc-fix-a-typo-in-testpmd-user-guide.patch

Quoted 7 lines

### doc: fix a typo in testpmd user guide

WARNING:BAD_SIGN_OFF: Duplicate signature
#25:

total: 0 errors, 1 warnings, 8 lines checked

There is no double sign-off, this is because Wisam added his ack without quoting original mail, so patchwork observed second sign-off and added it.

So original patch is OK, please check the error message before copy-paste it from the console.

And with your error copy-paste, patchwork observed sign-off again and now there are three copy same sign-off :)

Quoted 5 lines

Otherwise

Applied
#4 lore raw
In reply to Iremonger, Bernard
Quoted 16 lines · Bernard

Hi Rami,

Quoted 14 lines

-----Original Message-----
From: dev [mailto:[email protected]] On Behalf Of Rami Rosen
Sent: Thursday, December 27, 2018 7:59 PM
To: [email protected]
Cc: [email protected]; [email protected]; Rami Rosen <[email protected]>
Subject: [dpdk-dev] [PATCH] doc: fix a typo in testpmd user guide

This patch fixes a typo in testpmd user guide.

Fixes aac6f11f5864 ("app/testpmd: add ethernet peer command")

...

Quoted 2 lines

Otherwise

Applied to dpdk-next-net/master, thanks.