Skip to contentSkip to conversation

package/php: fix building pcre extension

PATCH New aduskett at gmail.com 3 participants 3 messages Dec 28, 2018 – Jan 10, 2019

lore
Share & tools
lore

aduskett at gmail.com

author
#0 lore raw

PATCH 1/1 package/php: fix building pcre extension

From: Adam Duskett <[email protected]>

The configure option "--with-pcre-regex=$(STAGING_DIR)/usr" is broken. PHP will prepend $(STAGING_DIR)/usr to the paths, which will cause a failure because it won't be able to find pcre, and will then fallback to searching for pcre2, which won't be installed.

Removing "=$(STAGING_DIR)/usr" from --with-pcre-regex fixes the issue.

Fixes:
http://autobuild.buildroot.net/results/586/586f56e8fcf2d2bbbd3bdf69b1c3befff7ce8bbf

Signed-off-by Adam Duskett <[email protected]>
---
 package/php/php.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/php/php.mk +1 -1
index fd428e192a..7d7d78353b 100644
@@ -244,7 +244,7 @@ PHP_POST_CONFIGURE_HOOKS += PHP_DISABLE_VALGRIND
 
 ### Use external PCRE if it's available
 ifeq ($(BR2_PACKAGE_PCRE),y)
-PHP_CONF_OPTS += --with-pcre-regex=$(STAGING_DIR)/usr
+PHP_CONF_OPTS += --with-pcre-regex
 PHP_DEPENDENCIES += pcre
 else
 # The bundled pcre library is not configurable through ./configure options,
Signature · 1 line
2.19.2
#1 lore raw

PATCH 1/1 package/php: fix building pcre extension

Hello Adam

Quoted 21 lines · aduskett at gmail.com

From: Adam Duskett <[email protected]>

The configure option "--with-pcre-regex=$(STAGING_DIR)/usr" is broken. PHP will prepend $(STAGING_DIR)/usr to the paths, which will cause a failure because it won't be able to find pcre, and will then fallback to searching for pcre2, which won't be installed.

Removing "=$(STAGING_DIR)/usr" from --with-pcre-regex fixes the issue.

Fixes:
http://autobuild.buildroot.net/results/586/586f56e8fcf2d2bbbd3bdf69b1c3befff7ce8bbf

Signed-off-by Adam Duskett <[email protected]>
---
 package/php/php.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/php/php.mk +0 -0
index fd428e192a..7d7d78353b 100644

package/php/php.mk PHP_POST_CONFIGURE_HOOKS += PHP_DISABLE_VALGRIND · line 250

Quoted 8 lines
package/php/php.mk +1 -1
@@ -244,7 +244,7 @@ PHP_POST_CONFIGURE_HOOKS += PHP_DISABLE_VALGRIND
 
 ### Use external PCRE if it's available
 ifeq ($(BR2_PACKAGE_PCRE),y)
-PHP_CONF_OPTS += --with-pcre-regex=$(STAGING_DIR)/usr
+PHP_CONF_OPTS += --with-pcre-regex
 PHP_DEPENDENCIES += pcre
 else
 # The bundled pcre library is not configurable through ./configure options,

I can confirm that this fixes
http://autobuild.buildroot.net/results/586/586f56e8fcf2d2bbbd3bdf69b1c3befff7ce8bbf
on my build system.

Tested-by Mark Corbin <[email protected]>
Signature · 3 lines
Mark Corbin
Embecosm Ltd.
https://www.embecosm.com
Applied
#2 lore raw

PATCH 1/1 package/php: fix building pcre extension

In reply to aduskett at gmail.com
Quoted 7 lines · aduskett at gmail.com

From: Adam Duskett <[email protected]>

The configure option "--with-pcre-regex=$(STAGING_DIR)/usr" is broken. PHP will prepend $(STAGING_DIR)/usr to the paths, which will cause a failure because it won't be able to find pcre, and will then fallback to searching for pcre2, which won't be installed.

Quoted 5 lines

Removing "=$(STAGING_DIR)/usr" from --with-pcre-regex fixes the issue.

Fixes:
http://autobuild.buildroot.net/results/586/586f56e8fcf2d2bbbd3bdf69b1c3befff7ce8bbf

Signed-off-by Adam Duskett <[email protected]>

Applied to master, thanks.

Care to add yourself as a developer for php?

Regards,
Arnout

Quoted 18 lines
---
 package/php/php.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/php/php.mk +1 -1
index fd428e192a..7d7d78353b 100644
@@ -244,7 +244,7 @@ PHP_POST_CONFIGURE_HOOKS += PHP_DISABLE_VALGRIND
 
 ### Use external PCRE if it's available
 ifeq ($(BR2_PACKAGE_PCRE),y)
-PHP_CONF_OPTS += --with-pcre-regex=$(STAGING_DIR)/usr
+PHP_CONF_OPTS += --with-pcre-regex
 PHP_DEPENDENCIES += pcre
 else
 # The bundled pcre library is not configurable through ./configure options,