tools headers: move the nolibc header from rcutorture to tools/include/nolibc/
Subsystems (3)
Willy Tarreau
maintainerPATCH 1/1 tools headers: move the nolibc header from rcutorture to tools/include/nolibc/
As suggested by Ingo, this header file might benefit other tools than just rcutorture. For now it's quite limited, but is easy to extend, so exposing it into tools/include/nolibc/ will make it much easier to adopt by other tools.
The mkinitrd.sh script in rcutorture was updated to use this new location.
---
tools/{testing/selftests/rcutorture/bin => include/nolibc}/nolibc.h | 0
tools/testing/selftests/rcutorture/bin/mkinitrd.sh | 4 ++--
2 files changed, 2 insertions(+), 2 deletions(-)
rename tools/{testing/selftests/rcutorture/bin => include/nolibc}/nolibc.h (100%)tools/include/nolibc/nolibc.h renamed from tools/testing/selftests/rcutorture/bin/nolibc.h +0 -0
tools/testing/selftests/rcutorture/bin/mkinitrd.sh +2 -2
@@ -124,8 +124,8 @@ if echo -e "#if __x86_64__||__i386__||__i486__||__i586__||__i686__" \ | grep -q '^yes'; then # architecture supported by nolibc ${CROSS_COMPILE}gcc -fno-asynchronous-unwind-tables -fno-ident \ - -nostdlib -include ../bin/nolibc.h -lgcc -s -static -Os \ - -o init init.c + -nostdlib -include ../../../../include/nolibc/nolibc.h \ + -lgcc -s -static -Os -o init init.c else ${CROSS_COMPILE}gcc -s -static -Os -o init init.c fi
Signature · 1 line
2.9.0
Quoted 11 lines · Willy Tarreau
As suggested by Ingo, this header file might benefit other tools than just rcutorture. For now it's quite limited, but is easy to extend, so exposing it into
tools/include/nolibc/will make it much easier to adopt by other tools.The
mkinitrd.shscript in rcutorture was updated to use this new location.Cc Ingo Molnar <[email protected]>Cc Arnaldo Carvalho de Melo <[email protected]>Cc Paul E. McKenney <[email protected]>Signed-off-by Willy Tarreau <[email protected]>
Thank you, Willy! I have queued all four of these. Should there be a MAINTAINERS file entry for the new include/nolibc home for this library code?
Thanx, Paul
Quoted 28 lines
--- tools/{testing/selftests/rcutorture/bin => include/nolibc}/nolibc.h | 0 tools/testing/selftests/rcutorture/bin/mkinitrd.sh | 4 ++-- 2 files changed, 2 insertions(+), 2 deletions(-) rename tools/{testing/selftests/rcutorture/bin => include/nolibc}/nolibc.h (100%)tools/include/nolibc/nolibc.h renamed from tools/testing/selftests/rcutorture/bin/nolibc.h +0
-0tools/testing/selftests/rcutorture/bin/mkinitrd.sh +2
-2@@ -124,8 +124,8 @@ if echo -e "#if __x86_64__||__i386__||__i486__||__i586__||__i686__" \ | grep -q '^yes'; then # architecture supported by nolibc ${CROSS_COMPILE}gcc -fno-asynchronous-unwind-tables -fno-ident \ - -nostdlib -include ../bin/nolibc.h -lgcc -s -static -Os \ - -o init init.c + -nostdlib -include ../../../../include/nolibc/nolibc.h \ + -lgcc -s -static -Os -o init init.c else ${CROSS_COMPILE}gcc -s -static -Os -o init init.c fiSignature · 1 line
2.9.0
Willy Tarreau
maintainerQuoted 6 lines · Paul E. McKenney
Quoted 5 lines · Willy Tarreau
As suggested by Ingo, this header file might benefit other tools than just rcutorture. For now it's quite limited, but is easy to extend, so exposing it into
tools/include/nolibc/will make it much easier to adopt by other tools.
Quoted 8 lines
Quoted 6 lines
The
mkinitrd.shscript in rcutorture was updated to use this new location.Cc Ingo Molnar <[email protected]>Cc Arnaldo Carvalho de Melo <[email protected]>Cc Paul E. McKenney <[email protected]>Signed-off-by Willy Tarreau <[email protected]>Thank you, Willy!
You're welcome!
Quoted 1 line
I have queued all four of these.
Thanks!
Quoted 3 lines
Should there
be aMAINTAINERSfile entry for the newinclude/nolibchome for this library code?
Good idea, I didn't think about it. Yes, I can add one and will send another patch. In case that helps I've created a repo at /pub/scm/linux/kernel/git/wtarreau/nolibc.git
Cheers,
Willy
Quoted 22 lines · Willy Tarreau
Quoted 6 lines · Paul E. McKenney
Quoted 5 lines · Willy Tarreau
As suggested by Ingo, this header file might benefit other tools than just rcutorture. For now it's quite limited, but is easy to extend, so exposing it into
tools/include/nolibc/will make it much easier to adopt by other tools.Quoted 8 lines
Quoted 6 lines
The
mkinitrd.shscript in rcutorture was updated to use this new location.Cc Ingo Molnar <[email protected]>Cc Arnaldo Carvalho de Melo <[email protected]>Cc Paul E. McKenney <[email protected]>Signed-off-by Willy Tarreau <[email protected]>Thank you, Willy!
You're welcome!
Quoted 1 line
I have queued all four of these.
Thanks!
Quoted 7 lines
Quoted 3 lines
Should there
be aMAINTAINERSfile entry for the newinclude/nolibchome for this library code?Good idea, I didn't think about it. Yes, I can add one and will send another patch. In case that helps I've created a repo at /pub/scm/linux/kernel/git/wtarreau/nolibc.git
And I have queued that one as well, thank you!
I am happy to curate nolibc patches indefinitely, but should some other pathway to mainline become better for you, just let me know.
Thanx, Paul
Willy Tarreau
maintainerQuoted 27 lines · Paul E. McKenney
Quoted 26 lines · Willy Tarreau
Quoted 6 lines · Paul E. McKenney
Quoted 5 lines · Willy Tarreau
As suggested by Ingo, this header file might benefit other tools than just rcutorture. For now it's quite limited, but is easy to extend, so exposing it into
tools/include/nolibc/will make it much easier to adopt by other tools.Quoted 8 lines
Quoted 6 lines
The
mkinitrd.shscript in rcutorture was updated to use this new location.Cc Ingo Molnar <[email protected]>Cc Arnaldo Carvalho de Melo <[email protected]>Cc Paul E. McKenney <[email protected]>Signed-off-by Willy Tarreau <[email protected]>Thank you, Willy!
You're welcome!
Quoted 1 line
I have queued all four of these.
Thanks!
Quoted 3 lines
Should there
be aMAINTAINERSfile entry for the newinclude/nolibchome for this library code?
Quoted 8 lines
Quoted 3 lines
Good idea, I didn't think about it. Yes, I can add one and will send another patch. In case that helps I've created a repo at /pub/scm/linux/kernel/git/wtarreau/nolibc.git
And I have queued that one as well, thank you!
I am happy to curate nolibc patches indefinitely, but should some other pathway to mainline become better for you, just let me know.
Oh perfect, thank you. I'm always having difficulties with processes, so having a known working path to mainline is indeed a much appreciated help!
Thanks,
Willy
Quoted 8 lines · Paul E. McKenney
Quoted 7 lines · Willy Tarreau
As suggested by Ingo, this header file might benefit other tools than just rcutorture. For now it's quite limited, but is easy to extend, so exposing it into
tools/include/nolibc/will make it much easier to adopt by other tools.The
mkinitrd.shscript in rcutorture was updated to use this new location.
Quoted 8 lines
Quoted 4 lines
Cc Ingo Molnar <[email protected]>Cc Arnaldo Carvalho de Melo <[email protected]>Cc Paul E. McKenney <[email protected]>Signed-off-by Willy Tarreau <[email protected]>Thank you, Willy! I have queued all four of these. Should there be a
MAINTAINERSfile entry for the newinclude/nolibchome for this library code?
Very good idea - ack. Could we please also use the opportunity and move nolibc.h to a more prominent place, like in tools/include/nolibc/nolibc.h or so?
Thanks,
Ingo
Willy Tarreau
maintainerOn Sun, Dec 30, 2018 at 12:25:02PM +0100, Ingo Molnar wrote:
Could we please also use the opportunity and move
Quoted 2 lines
nolibc.hto a more prominent place, like intools/include/nolibc/nolibc.hor so?
It's exactly what the last patch does, I followed your suggestion :-)
Willy
Quoted 6 lines · Willy Tarreau
On Sun, Dec 30, 2018 at 12:25:02PM +0100, Ingo Molnar wrote:
Could we please also use the opportunity and moveQuoted 2 lines
nolibc.hto a more prominent place, like intools/include/nolibc/nolibc.hor so?It's exactly what the last patch does, I followed your suggestion :-)
Silly me - I only looked at the series of patches and didn't see a file movement patch there :-)
Thanks,
Ingo