package/docker-containerd: add missing dependency on host-pkgconf
PATCH 1/1 package/docker-containerd: add missing dependency on host-pkgconf
When libsseccomp support is enabled, docker-containerd uses pkg-config to find libsseccomp, so we must depend on host-pkconf.
Fixes the following build issue, detected with per-package directory support:
pkg-config: exec: "pkg-config": executable file not found in $PATH
--- package/docker-containerd/docker-containerd.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/docker-containerd/docker-containerd.mk +1 -1
@@ -19,7 +19,7 @@ DOCKER_CONTAINERD_BUILD_TARGETS = cmd/ctr cmd/containerd cmd/containerd-shim DOCKER_CONTAINERD_INSTALL_BINS = containerd containerd-shim ifeq ($(BR2_PACKAGE_LIBSECCOMP),y) -DOCKER_CONTAINERD_DEPENDENCIES += libseccomp +DOCKER_CONTAINERD_DEPENDENCIES += libseccomp host-pkgconf DOCKER_CONTAINERD_TAGS += seccomp endif
Signature · 1 line
2.20.1
PATCH 1/1 package/docker-containerd: add missing dependency on host-pkgconf
Hi Thomas,
Quoted 3 lines · Thomas Petazzoni
When libsseccomp support is enabled, docker-containerd uses pkg-config to find libsseccomp, so we must depend on host-pkconf. +DOCKER_CONTAINERD_DEPENDENCIES += libseccomp host-pkgconf
LGTM.
- I hope signed-off-by is appropriate here.
Best,
Christian
PATCH 1/1 package/docker-containerd: add missing dependency on host-pkgconf
Hello,
Quoted 7 lines · Christian Stewart
Quoted 3 lines · Thomas Petazzoni
When libsseccomp support is enabled, docker-containerd uses pkg-config to find libsseccomp, so we must depend on host-pkconf. +DOCKER_CONTAINERD_DEPENDENCIES += libseccomp host-pkgconf
LGTM.
Thanks for the review.
Quoted 3 lines
Signed-off-by Christian Stewart <[email protected]>- I hope signed-off-by is appropriate here.
Signed-off-by is when you're the author, or in the chain of developers/maintainers that carry the patch all the way to upstream.
In this case, what you should ideally have used is a Acked-by or Reviewed-by. See also
https://buildroot.org/downloads/manual/manual.html#_reviewing_and_testing_patches.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 package/docker-containerd: add missing dependency on host-pkgconf
In reply to Christian StewartChristian, All,
On 2018-12-28 20:46 -0800, Christian Stewart spake thusly:
Quoted 11 lines
Quoted 3 lines · Thomas Petazzoni
When libsseccomp support is enabled, docker-containerd uses pkg-config to find libsseccomp, so we must depend on host-pkconf. +DOCKER_CONTAINERD_DEPENDENCIES += libseccomp host-pkgconf
LGTM.
Signed-off-by Christian Stewart <[email protected]>- I hope signed-off-by is appropriate here.
No, it's not. A SoB line means that you were part of the chain that got a patch to the list (and eventuakky, the repository), i.e. the author of the patch, or any one taking it from the author up until it's comitted.
Here, you're saying that you looked at the patch, and that it looks OK to you. This is a review, and is denoted by a Reviewed-by tag.
See the manual for more tags:
https://buildroot.org/downloads/manual/manual.html#_reviewing_and_testing_patches
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 1/1 package/docker-containerd: add missing dependency on host-pkgconf
Yann, Thomas,
Quoted 9 lines · Yann E. MORIN
No, it's not. A SoB line means that you were part of the chain that got a patch to the list (and eventuakky, the repository), i.e. the author of the patch, or any one taking it from the author up until it's comitted.
Here, you're saying that you looked at the patch, and that it looks OK to you. This is a review, and is denoted by a Reviewed-by tag.
See the manual for more tags:
https://buildroot.org/downloads/manual/manual.html#_reviewing_and_testing_patches
Appreciated, I will mark these in my notes.
Best regards,
Christian
Thomas Petazzoni
AppliedPATCH 1/1 package/docker-containerd: add missing dependency on host-pkgconf
In reply to Thomas PetazzoniHello,
Quoted 6 lines · Thomas Petazzoni
When libsseccomp support is enabled, docker-containerd uses pkg-config to find libsseccomp, so we must depend on host-pkconf.
Fixes the following build issue, detected with per-package directory support:
Quoted 6 lines
pkg-config: exec: "pkg-config": executable file not found in $PATH
Signed-off-by Thomas Petazzoni <[email protected]>--- package/docker-containerd/docker-containerd.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to master, thanks.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 package/docker-containerd: add missing dependency on host-pkgconf
In reply to Thomas PetazzoniQuoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Thomas" == Thomas Petazzoni <[email protected]> writes:
When libsseccomp support is enabled, docker-containerd uses pkg-config to find libsseccomp, so we must depend on host-pkconf.
Fixes the following build issue, detected with per-package directory support:
pkg-config: exec: "pkg-config": executable file not found in $PATH
Signed-off-by Thomas Petazzoni <[email protected]>
Committed to 2018.11.x, thanks.
Signature · 1 line
Bye, Peter Korsgaard