exempi: new package
PATCH 1/1 exempi: new package
From: Ilya Averyanov <[email protected]>
--- package/Config.in | 1 + package/exempi/Config.in | 5 +++++ package/exempi/exempi.hash | 2 ++ package/exempi/exempi.mk | 16 ++++++++++++++++ 4 files changed, 24 insertions(+) create mode 100644 package/exempi/Config.in create mode 100644 package/exempi/exempi.hash create mode 100644 package/exempi/exempi.mk
package/Config.in +1 -0
@@ -1247,6 +1247,7 @@ menu "Graphics" source "package/cairomm/Config.in" source "package/chipmunk/Config.in" source "package/exiv2/Config.in" + source "package/exempi/Config.in" source "package/fltk/Config.in" source "package/fontconfig/Config.in" source "package/freetype/Config.in"
package/exempi/Config.in new file +5 -0
@@ -0,0 +1,5 @@ +config BR2_PACKAGE_EXEMPI + bool "exempi" + help + Exempi is an implementation of XMP. Version 2.x is based on Adobe XMP SDK. + http://libopenraw.freedesktop.org/wiki/Exempi
package/exempi/exempi.hash new file +2 -0
@@ -0,0 +1,2 @@ +# Locally calculated +sha256 406185feb88e84ea1d4b4251370be2991205790d7113a7e28e192ff46a4f221e exempi-2.4.5.tar.bz2
package/exempi/exempi.mk new file +16 -0
@@ -0,0 +1,16 @@ +################################################################################ +# +# exempi +# +################################################################################ + +EXEMPI_VERSION = 2.4.5 +EXEMPI_SOURCE = exempi-$(EXEMPI_VERSION).tar.bz2 +EXEMPI_SITE = https://libopenraw.freedesktop.org/download +EXEMPI_INSTALL_STAGING = YES +EXEMPI_CONF_OPTS = --enable-unittest=no +EXEMPI_DEPENDENCIES = host-pkgconf +EXEMPI_LICENSE = BSD-3-Clause +EXEMPI_LICENSE_FILES = COPYING + +$(eval $(autotools-package))
Signature · 1 line
2.19.1
Thomas Petazzoni
AppliedPATCH 1/1 exempi: new package
Hello Ilya,
Thanks for your contribution! I have applied your patch, but since this is your first contribution, there were obviously a few issues. Please read below for details about those issues, in order to improve your future contributions!
Quoted 8 lines · averyanovin at gmail.com
From: Ilya Averyanov <[email protected]>
Signed-off-by Ilya Averyanov <[email protected]>--- package/Config.in | 1 + package/exempi/Config.in | 5 +++++ package/exempi/exempi.hash | 2 ++ package/exempi/exempi.mk | 16 ++++++++++++++++
First of all, you should have added an entry in the DEVELOPERS file for this new package. I have done that, and it will ensure that you will receive e-mail notifications if there is a build failure caused by this package.
package/exempi/Config.in line 5
Quoted 11 lines
package/exempi/Config.in new file +5
-0@@ -0,0 +1,5 @@ +config BR2_PACKAGE_EXEMPI + bool "exempi" + help + Exempi is an implementation of XMP. Version 2.x is based on Adobe XMP SDK. + http://libopenraw.freedesktop.org/wiki/Exempi
The indentation was not correct: this could have been detected by running "make check-package", which validates the coding style of packages.
Also, you forgot to select the expat and zlib package, and to depend on C++ support and dynamic library support.
A Config.in comment was missing to document the C++ and dynamic library dependencies.
For your next contribution: remember to use the ./utils/test-pkg script, which will help you validate your package builds fine in a number of configurations.
package/exempi/exempi.hash line 2
Quoted 8 lines
package/exempi/exempi.hash new file +2
-0@@ -0,0 +1,2 @@ +# Locally calculated +sha256 406185feb88e84ea1d4b4251370be2991205790d7113a7e28e192ff46a4f221e exempi-2.4.5.tar.bz2
The hash of the license file was missing.
Quoted 7 lines
package/exempi/exempi.mk new file +1
-0@@ -0,0 +1,16 @@ +################################################################################
package/exempi/exempi.mk line 11
Quoted 10 lines
package/exempi/exempi.mk new file +10
-0+# +# exempi +# +################################################################################ + +EXEMPI_VERSION = 2.4.5 +EXEMPI_SOURCE = exempi-$(EXEMPI_VERSION).tar.bz2 +EXEMPI_SITE = https://libopenraw.freedesktop.org/download +EXEMPI_INSTALL_STAGING = YES +EXEMPI_CONF_OPTS = --enable-unittest=no
We normally use --disable-foo instead of --enable-foo=no.
package/exempi/exempi.mk line 12
Quoted 1 line
package/exempi/exempi.mk new file +1
-0+EXEMPI_DEPENDENCIES = host-pkgconf
expat and zlib were missing from that list.
package/exempi/exempi.mk line 16
Quoted 4 lines
package/exempi/exempi.mk new file +4
-0+EXEMPI_LICENSE = BSD-3-Clause +EXEMPI_LICENSE_FILES = COPYING + +$(eval $(autotools-package))
I've applied with the above issues fixed. Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com