[PATCH] drm/i915: Remove has_pooled_eu static initializer

Jani Nikula

author

2018-12-31 12:22 UTC #0 lore raw

PATCH 1/1 drm/i915: Remove has_pooled_eu static initializer

From: Tvrtko Ursulin <[email protected]>

It is only initialized to zero once so does not need an explicit initializer.

Signed-off-by Tvrtko Ursulin <[email protected]>

Reviewed-by Ville Syrjälä <[email protected]>

Cc Chris Wilson <[email protected]>

Cc Jani Nikula <[email protected]>

Signed-off-by Jani Nikula <[email protected]>

---
 drivers/gpu/drm/i915/i915_pci.c | 1 -
 1 file changed, 1 deletion(-)

drivers/gpu/drm/i915/i915_pci.c +0 -1

index 6350db5503cd..0d342f2b44a5 100644
@@ -532,7 +532,6 @@ static const struct intel_device_info intel_skylake_gt4_info = {
 	.display.has_fbc = 1, \
 	.display.has_psr = 1, \
 	.has_runtime_pm = 1, \
-	.has_pooled_eu = 0, \
 	.display.has_csr = 1, \
 	.has_rc6 = 1, \
 	.display.has_dp_mst = 1, \

Signature · 6 lines

2.11.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Patchwork

CI

2018-12-31 12:59 UTC #1 lore raw

✓ Fi.CI.BAT: success for drm/i915: Remove has_pooled_eu static initializer

== Series Details ==

Series: drm/i915: Remove has_pooled_eu static initializer
URL : https://patchwork.freedesktop.org/series/54585/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5350 -> Patchwork_11170
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/54585/revisions/1/mbox/

Known issues
------------

Here are the changes found in Patchwork_11170 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@amdgpu/amd_basic@cs-compute:
- fi-kbl-8809g: NOTRUN -> FAIL [fdo#108094]

* igt@amdgpu/amd_prime@amd-to-i915:
- fi-kbl-8809g: NOTRUN -> FAIL [fdo#107341]

* igt@gem_mmap_gtt@basic-wc:
- fi-cfl-8109u: PASS -> FAIL [fdo#107307]

* igt@kms_frontbuffer_tracking@basic:
- fi-byt-clapper: NOTRUN -> FAIL [fdo#103167]

* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
- fi-byt-clapper: NOTRUN -> FAIL [fdo#103191] / [fdo#107362]

* igt@kms_pipe_crc_basic@read-crc-pipe-b:
- fi-byt-clapper: NOTRUN -> FAIL [fdo#107362]

#### Possible fixes ####

* igt@amdgpu/amd_basic@userptr:
- fi-kbl-8809g: DMESG-WARN [fdo#108965] -> PASS

* igt@kms_flip@basic-flip-vs-modeset:
- fi-skl-6700hq: DMESG-WARN [fdo#105998] -> PASS +1

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-blb-e6850: INCOMPLETE [fdo#107718] -> PASS

Participating hosts (43 -> 46)
------------------------------

Additional (9): fi-bwr-2160 fi-gdg-551 fi-ivb-3770 fi-pnv-d510 fi-bsw-kefka fi-kbl-7560u fi-byt-n2820 fi-byt-clapper fi-snb-2600
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-bdw-samus

Build changes
-------------

* Linux: CI_DRM_5350 -> Patchwork_11170

CI_DRM_5350: 671b7a1ef332b6a359839a5e84c1de2bd70e7899 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4754: a176905d46d072300ba57f29ac2b98a0228e0e2d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_11170: 3f986ad91ededf61de4307b3f212d24ac036d921 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

3f986ad91ede drm/i915: Remove has_pooled_eu static initializer

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_11170/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Patchwork

CI

2018-12-31 14:01 UTC #2 lore raw

✓ Fi.CI.IGT: success for drm/i915: Remove has_pooled_eu static initializer

In reply to Jani Nikula

== Series Details ==

Series: drm/i915: Remove has_pooled_eu static initializer
URL : https://patchwork.freedesktop.org/series/54585/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5350_full -> Patchwork_11170_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Known issues
------------

Here are the changes found in Patchwork_11170_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@kms_busy@extended-modeset-hang-newfb-render-a:
- shard-skl: PASS -> DMESG-WARN [fdo#107956]

* igt@kms_chv_cursor_fail@pipe-c-128x128-bottom-edge:
- shard-skl: PASS -> FAIL [fdo#104671]

* igt@kms_color@pipe-a-degamma:
- shard-apl: PASS -> FAIL [fdo#104782] / [fdo#108145]

* igt@kms_cursor_crc@cursor-128x128-random:
- shard-iclb: NOTRUN -> FAIL [fdo#103232]

* igt@kms_cursor_crc@cursor-64x21-sliding:
- shard-iclb: NOTRUN -> DMESG-WARN [fdo#107724] / [fdo#108336] +3

* igt@kms_cursor_crc@cursor-64x64-random:
- shard-apl: PASS -> FAIL [fdo#103232]

* igt@kms_draw_crc@draw-method-xrgb2101010-mmap-wc-untiled:
- shard-iclb: PASS -> WARN [fdo#108336] +1

* igt@kms_fbcon_fbt@psr-suspend:
- shard-skl: NOTRUN -> FAIL [fdo#107882]

* igt@kms_flip@2x-modeset-vs-vblank-race:
- shard-hsw: PASS -> DMESG-FAIL [fdo#102614] / [fdo#103060]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen:
- shard-apl: PASS -> FAIL [fdo#103167] +1

* igt@kms_frontbuffer_tracking@fbc-1p-shrfb-fliptrack:
- shard-iclb: PASS -> DMESG-FAIL [fdo#107720] / [fdo#107724]

* igt@kms_frontbuffer_tracking@fbc-tilingchange:
- shard-iclb: NOTRUN -> DMESG-FAIL [fdo#107724] +3

* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-render:
- shard-iclb: PASS -> DMESG-FAIL [fdo#107724] +3

* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-render:
- shard-iclb: PASS -> FAIL [fdo#103167] +1

* igt@kms_frontbuffer_tracking@psr-rgb565-draw-render:
- shard-iclb: PASS -> DMESG-WARN [fdo#107724] / [fdo#108336] +4

* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-c-frame-sequence:
- shard-skl: PASS -> FAIL [fdo#103191] / [fdo#107362]

* igt@kms_pipe_crc_basic@read-crc-pipe-a:
- shard-iclb: PASS -> DMESG-WARN [fdo#107724] +5

* igt@kms_plane@pixel-format-pipe-a-planes:
- shard-skl: NOTRUN -> DMESG-WARN [fdo#106885]

* igt@kms_plane@pixel-format-pipe-b-planes:
- shard-iclb: NOTRUN -> FAIL [fdo#103166]

* igt@kms_plane_alpha_blend@pipe-b-alpha-7efc:
- shard-skl: NOTRUN -> FAIL [fdo#107815] / [fdo#108145]

* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: PASS -> FAIL [fdo#107815]

* igt@kms_plane_multiple@atomic-pipe-c-tiling-y:
- shard-apl: PASS -> FAIL [fdo#103166]

* igt@kms_psr@sprite_blt:
- shard-iclb: NOTRUN -> DMESG-WARN [fdo#107724] +10

* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-kbl: PASS -> DMESG-WARN [fdo#105604]

* igt@perf_pmu@rc6-runtime-pm:
- shard-kbl: PASS -> FAIL [fdo#105010]

* igt@pm_backlight@fade_with_suspend:
- shard-skl: NOTRUN -> FAIL [fdo#107847]

* igt@pm_rpm@drm-resources-equal:
- shard-skl: PASS -> INCOMPLETE [fdo#107807]

#### Possible fixes ####

* igt@gem_eio@unwedge-stress:
- shard-apl: INCOMPLETE [fdo#103927] -> PASS

* igt@kms_busy@extended-modeset-hang-newfb-render-a:
- shard-snb: DMESG-WARN [fdo#107956] -> PASS

* igt@kms_color@pipe-a-ctm-green-to-red:
- shard-skl: FAIL [fdo#107201] -> PASS

* igt@kms_cursor_crc@cursor-128x42-random:
- shard-glk: FAIL [fdo#103232] -> PASS

* igt@kms_cursor_crc@cursor-256x256-sliding:
- shard-apl: FAIL [fdo#103232] -> PASS

* igt@kms_cursor_crc@cursor-256x256-suspend:
- shard-skl: INCOMPLETE [fdo#104108] -> PASS
- shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS

* igt@kms_fbcon_fbt@fbc-suspend:
- shard-skl: INCOMPLETE [fdo#104108] / [fdo#107773] -> PASS

* igt@kms_flip_tiling@flip-changes-tiling-y:
- shard-skl: FAIL [fdo#107931] / [fdo#108303] -> PASS

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
- shard-apl: FAIL [fdo#103167] -> PASS

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
- shard-glk: FAIL [fdo#103167] -> PASS +4

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-pwrite:
- shard-iclb: FAIL [fdo#103167] -> PASS

* igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-mmap-cpu:
- shard-skl: FAIL [fdo#103167] -> PASS

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-skl: FAIL [fdo#103191] / [fdo#107362] -> PASS

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
- shard-kbl: DMESG-WARN [fdo#103558] / [fdo#105602] -> PASS +11

* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: FAIL [fdo#107815] / [fdo#108145] -> PASS

* igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
- shard-glk: FAIL [fdo#103166] -> PASS
- shard-apl: FAIL [fdo#103166] -> PASS +1

* igt@kms_setmode@basic:
- shard-apl: FAIL [fdo#99912] -> PASS
- shard-kbl: FAIL [fdo#99912] -> PASS

* igt@pm_rpm@i2c:
- shard-skl: INCOMPLETE [fdo#107807] -> PASS

* igt@pm_rpm@system-suspend-execbuf:
- shard-skl: INCOMPLETE [fdo#104108] / [fdo#107773] / [fdo#107807] -> PASS

* igt@pm_rpm@universal-planes:
- shard-iclb: DMESG-WARN [fdo#108654] / [fdo#108756] -> PASS

#### Warnings ####

* igt@i915_selftest@live_contexts:
- shard-iclb: INCOMPLETE [fdo#108315] -> DMESG-FAIL [fdo#108569]

* igt@kms_setmode@basic:
- shard-iclb: FAIL [fdo#99912] -> DMESG-FAIL [fdo#107724] / [fdo#99912]

* igt@pm_rpm@modeset-lpsp-stress:
- shard-iclb: INCOMPLETE [fdo#108840] -> DMESG-WARN [fdo#107724]

Participating hosts (7 -> 7)
------------------------------

No changes in participating hosts

Build changes
-------------

* Linux: CI_DRM_5350 -> Patchwork_11170

CI_DRM_5350: 671b7a1ef332b6a359839a5e84c1de2bd70e7899 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4754: a176905d46d072300ba57f29ac2b98a0228e0e2d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_11170: 3f986ad91ededf61de4307b3f212d24ac036d921 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_11170/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Jani Nikula

author

2018-12-31 14:12 UTC #3 lore raw

In reply to Jani Nikula

Quoted 10 lines · Jani Nikula

From: Tvrtko Ursulin <[email protected]>
It is only initialized to zero once so does not need an explicit initializer.
Signed-off-by Tvrtko Ursulin <[email protected]>
Reviewed-by Ville Syrjälä <[email protected]>
Cc Chris Wilson <[email protected]>
Cc Jani Nikula <[email protected]>
Signed-off-by Jani Nikula <[email protected]>

And pushed to dinq, thanks for the patch and review.

BR,
Jani.

Quoted 16 lines

---
 drivers/gpu/drm/i915/i915_pci.c | 1 -
 1 file changed, 1 deletion(-)

drivers/gpu/drm/i915/i915_pci.c +0 -1

index 6350db5503cd..0d342f2b44a5 100644
@@ -532,7 +532,6 @@ static const struct intel_device_info intel_skylake_gt4_info = {
 	.display.has_fbc = 1, \
 	.display.has_psr = 1, \
 	.has_runtime_pm = 1, \
-	.has_pooled_eu = 0, \
 	.display.has_csr = 1, \
 	.has_rc6 = 1, \
 	.display.has_dp_mst = 1, \

Signature · 5 lines

Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx