Skip to contentSkip to conversation

network/busy_poll: Change the "ethtool --show-features to "ethtool -k"

PATCH New Sun Lianwen 2 participants 2 messages Dec 31, 2018 – Jan 1, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 network/busy_poll: Change the "ethtool --show-features to "ethtool -k"

To keep the same struct of "ethtool -i $(tst_iface)", change the "ethtool --show-features" to "ethtool -k".

---
 testcases/network/busy_poll/busy_poll_lib.sh | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
testcases/network/busy_poll/busy_poll_lib.sh +1 -2
index 5270a1bbd..2a24ff262 100755
@@ -22,8 +22,7 @@ busy_poll_check_config()
 	fi
 
 	if tst_kvcmp -lt "4.5"; then
-		ethtool --show-features $(tst_iface) | \
-			grep -q 'busy-poll.*on' || \
+		ethtool -k  $(tst_iface) | grep -q 'busy-poll.*on' || \
 			tst_brk TCONF "busy poll not supported by driver"
 	else
 		drvs="bnx2x|bnxt|cxgb4|enic|benet|ixgbe|ixgbevf|mlx4|mlx5|myri10ge|sfc|virtio"
Signature · 1 line
2.19.0
#1 lore raw

PATCH 1/1 network/busy_poll: Change the "ethtool --show-features to "ethtool -k"

Hi Sun,

Quoted 2 lines

To keep the same struct of "ethtool -i $(tst_iface)", change the "ethtool --show-features" to "ethtool -k".

--show-features is the same as -k, so what is the improvement?

Kind regards,
Petr