Skip to contentSkip to conversation

test driver to analyse vmalloc allocator

RFC Superseded Uladzislau Rezki (Sony) 1 participant 4 messages Jan 2, 2019

Subsystems (4)

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Uladzislau Rezki (Sony)

author maintainer
#0 lore raw

v3 cover test driver to analyse vmalloc allocator

Hello.

This is v3.

The first RFC was here: https://lkml.org/lkml/2018/11/13/957
Please have a look there for detailed description and discussion.

Changes in v3:
- Export __vmalloc_node_range() with _GPL-only prefix;
- Add skip cases if the test can not be executed in current environment. That is kselftest framework requirement.

Changes in v2:
- Code cleanup to make it more simple;
- Now __vmalloc_node_range() is exported if CONFIG_TEST_VMALLOC_MODULE=m
- Integrate vmalloc test suite into tools/testing/selftests/vm

Appreciate your comments and feedback, so please RFC v3.

Thank you.

Uladzislau Rezki (Sony) (3):
vmalloc: export __vmalloc_node_range for CONFIG_TEST_VMALLOC_MODULE
vmalloc: add test driver to analyse vmalloc allocator selftests/vm: add script helper for CONFIG_TEST_VMALLOC_MODULE

 lib/Kconfig.debug                          |  12 +
 lib/Makefile                               |   1 +
 lib/test_vmalloc.c                         | 543 +++++++++++++++++++++++++++++
 mm/vmalloc.c                               |   9 +
 tools/testing/selftests/vm/run_vmtests     |  16 +
 tools/testing/selftests/vm/test_vmalloc.sh | 176 ++++++++++
 6 files changed, 757 insertions(+)
 create mode 100644 lib/test_vmalloc.c
 create mode 100755 tools/testing/selftests/vm/test_vmalloc.sh
Signature · 1 line
2.11.0
author maintainer
#1 lore raw

RFC v3 1/3 vmalloc: export __vmalloc_node_range for CONFIG_TEST_VMALLOC_MODULE

Export __vmaloc_node_range() function if CONFIG_TEST_VMALLOC_MODULE is enabled. Some test cases in vmalloc test suite module require and make use of that function. Please note, that it is not supposed to be used for other purposes.

We need it only for performance analysis, stressing and stability check of vmalloc allocator.

---
 mm/vmalloc.c | 9 +++++++++
 1 file changed, 9 insertions(+)
mm/vmalloc.c +9 -0
index cfea25be7754..1f24aecd1d7e 100644
@@ -1764,6 +1764,15 @@ void *__vmalloc_node_range(unsigned long size, unsigned long align,
 	return NULL;
 }
 
+/*
+ * This is only for performance analysis of vmalloc and stress purpose.
+ * It is required by vmalloc test module, therefore do not use it other
+ * than that.
+ */
+#ifdef CONFIG_TEST_VMALLOC_MODULE
+EXPORT_SYMBOL_GPL(__vmalloc_node_range);
+#endif
+
 /**
  *	__vmalloc_node  -  allocate virtually contiguous memory
  *	@size:		allocation size
Signature · 1 line
2.11.0
author maintainer
#2 lore raw

RFC v3 2/3 vmalloc: add test driver to analyse vmalloc allocator

In reply to Uladzislau Rezki (Sony)

This adds a new kernel module for analysis of vmalloc allocator. It is only enabled as a module. There are two main reasons this module should be used for: performance evaluation and stressing of vmalloc subsystem.

It consists of several test cases. As of now there are 8. The module has five parameters we can specify to change its the behaviour.

1) run_test_mask - set of tests to be run

id: 1, name: fix_size_alloc_test
id: 2, name: full_fit_alloc_test
id: 4, name: long_busy_list_alloc_test
id: 8, name: random_size_alloc_test
id: 16, name: fix_align_alloc_test
id: 32, name: random_size_align_alloc_test
id: 64, name: align_shift_alloc_test
id: 128, name: pcpu_alloc_test

By default all tests are in run test mask. If you want to select some specific tests it is possible to pass the mask. For example for first, second and fourth tests we go 11 value.

2) test_repeat_count - how many times each test should be repeated By default it is one time per test. It is possible to pass any number. As high the value is the test duration gets increased.

3) test_loop_count - internal test loop counter. By default it is set to 1000000.

4) single_cpu_test - use one CPU to run the tests
By default this parameter is set to false. It means that all online CPUs execute tests. By setting it to 1, the tests are executed by first online CPU only.

5) sequential_test_order - run tests in sequential order
By default this parameter is set to false. It means that before running tests the order is shuffled. It is possible to make it sequential, just set it to 1.

Performance analysis:
In order to evaluate performance of vmalloc allocations, usually it makes sense to use only one CPU that runs tests, use sequential order, number of repeat tests can be different as well as set of test mask.

For example if we want to run all tests, to use one CPU and repeat each test 3 times. Insert the module passing following parameters:

single_cpu_test=1 sequential_test_order=1 test_repeat_count=3

with following output:

<snip>
Summary: fix_size_alloc_test passed: 3 failed: 0 repeat: 3 loops: 1000000 avg: 901177 usec
Summary: full_fit_alloc_test passed: 3 failed: 0 repeat: 3 loops: 1000000 avg: 1039341 usec
Summary: long_busy_list_alloc_test passed: 3 failed: 0 repeat: 3 loops: 1000000 avg: 11775763 usec
Summary: random_size_alloc_test passed 3: failed: 0 repeat: 3 loops: 1000000 avg: 6081992 usec
Summary: fix_align_alloc_test passed: 3 failed: 0 repeat: 3, loops: 1000000 avg: 2003712 usec
Summary: random_size_align_alloc_test passed: 3 failed: 0 repeat: 3 loops: 1000000 avg: 2895689 usec
Summary: align_shift_alloc_test passed: 0 failed: 3 repeat: 3 loops: 1000000 avg: 573 usec
Summary: pcpu_alloc_test passed: 3 failed: 0 repeat: 3 loops: 1000000 avg: 95802 usec All test took CPU0=192945605995 cycles
<snip>

The align_shift_alloc_test is expected to be failed.

Stressing:
In order to stress the vmalloc subsystem we run all available test cases on all available CPUs simultaneously. In order to prevent constant behaviour pattern, the test cases array is shuffled by default to randomize the order of test execution.

For example if we want to run all tests(default), use all online CPUs(default) with shuffled order(default) and to repeat each test 30 times. The command would be like:

modprobe vmalloc_test test_repeat_count=30

Expected results are the system is alive, there are no any BUG_ONs or Kernel Panics the tests are completed, no memory leaks.

---
 lib/Kconfig.debug  |  12 ++
 lib/Makefile       |   1 +
 lib/test_vmalloc.c | 543 +++++++++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 556 insertions(+)
 create mode 100644 lib/test_vmalloc.c
lib/Kconfig.debug +12 -0
index 8838d1158d19..0c027b2fef0a 100644
@@ -1851,6 +1851,18 @@ config TEST_LKM
 
 	  If unsure, say N.
 
+config TEST_VMALLOC
+	tristate "Test module for stress/performance analysis of vmalloc allocator"
+	default n
+	depends on m
+	help
+	  This builds the "test_vmalloc" module that should be used for
+	  stress and performance analysis. So, any new change for vmalloc
+	  subsystem can be evaluated from performance and stability point
+	  of view.
+
+	  If unsure, say N.
+
 config TEST_USER_COPY
 	tristate "Test user/kernel boundary protections"
 	default n
lib/Makefile +1 -0
index 90dc5520b784..2caa6161b417 100644
@@ -57,6 +57,7 @@ UBSAN_SANITIZE_test_ubsan.o := y
 obj-$(CONFIG_TEST_KSTRTOX) += test-kstrtox.o
 obj-$(CONFIG_TEST_LIST_SORT) += test_list_sort.o
 obj-$(CONFIG_TEST_LKM) += test_module.o
+obj-$(CONFIG_TEST_VMALLOC) += test_vmalloc.o
 obj-$(CONFIG_TEST_OVERFLOW) += test_overflow.o
 obj-$(CONFIG_TEST_RHASHTABLE) += test_rhashtable.o
 obj-$(CONFIG_TEST_SORT) += test_sort.o
lib/test_vmalloc.c new file +543 -0

543 lines not on this page · raw message

Signature · 1 line
2.11.0
author maintainer
#3 lore raw

RFC v3 3/3 selftests/vm: add script helper for CONFIG_TEST_VMALLOC_MODULE

In reply to Uladzislau Rezki (Sony)

Add the test script for the kernel test driver to analyse vmalloc allocator for benchmarking and stressing purposes. It is just a kernel module loader. You can specify and pass different parameters in order to investigate allocations behaviour. See "usage" output for more details.

Also add basic vmalloc smoke test to the "run_vmtests" suite.

---
 tools/testing/selftests/vm/run_vmtests     |  16 +++
 tools/testing/selftests/vm/test_vmalloc.sh | 176 +++++++++++++++++++++++++++++
 2 files changed, 192 insertions(+)
 create mode 100755 tools/testing/selftests/vm/test_vmalloc.sh
tools/testing/selftests/vm/run_vmtests +16 -0
index 88cbe5575f0c..48ac0f757e9c 100755
@@ -200,4 +200,20 @@ else
     echo "[PASS]"
 fi
 
+echo "------------------------------------"
+echo "running vmalloc stability smoke test"
+echo "------------------------------------"
+./test_vmalloc.sh smoke
+ret_val=$?
+
+if [ $ret_val -eq 0 ]; then
+	echo "[PASS]"
+elif [ $ret_val -eq $ksft_skip ]; then
+	 echo "[SKIP]"
+	 exitcode=$ksft_skip
+else
+	echo "[FAIL]"
+	exitcode=1
+fi
+
 exit $exitcode
tools/testing/selftests/vm/test_vmalloc.sh new file +176 -0

176 lines not on this page · raw message

Signature · 1 line
2.11.0