Skip to contentSkip to conversation

sched/fair: Remove unneeded prototype of capacity_of()

PATCH Superseded Valentin Schneider 2 participants 3 messages Jan 2, 2019 – Jan 28, 2019 Scheduler

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sched/fair: Remove unneeded prototype of capacity_of()

The prototype of that function was already hoisted up in

commit 3b1baa6496e6 ("sched/fair: Add 'group_misfit_task' load-balance type")

but that seems to have been missed. Get rid of the extra prototype.

Fixes 2802bf3cd936 ("sched/fair: Add over-utilization/tipping point indicator")
---
 kernel/sched/fair.c | 1 -
 1 file changed, 1 deletion(-)
kernel/sched/fair.c +0 -1
index 6483834f1278..6d653947a829 100644
@@ -5083,7 +5083,6 @@ static inline void hrtick_update(struct rq *rq)
 
 #ifdef CONFIG_SMP
 static inline unsigned long cpu_util(int cpu);
-static unsigned long capacity_of(int cpu);
 
 static inline bool cpu_overutilized(int cpu)
 {

--
2.20.1

Acked-by on v1 1/1
#1 lore raw

Hi Valentin,

Quoted 5 lines · Valentin Schneider

The prototype of that function was already hoisted up in

commit 3b1baa6496e6 ("sched/fair: Add 'group_misfit_task' load-balance type")

but that seems to have been missed.

Indeed, I missed that one :/

Quoted 21 lines

Get rid of the extra prototype.

Fixes 2802bf3cd936 ("sched/fair: Add over-utilization/tipping point indicator")
---
 kernel/sched/fair.c | 1 -
 1 file changed, 1 deletion(-)
kernel/sched/fair.c +0 -2
index 6483834f1278..6d653947a829 100644
@@ -5083,7 +5083,6 @@ static inline void hrtick_update(struct rq *rq)
 
 #ifdef CONFIG_SMP
 static inline unsigned long cpu_util(int cpu);
-static unsigned long capacity_of(int cpu);
 
 static inline bool cpu_overutilized(int cpu)
 {
--
Quoted 1 line

2.20.1

Thanks for cleaning this up,
Quentin

#2 lore raw
In reply to Valentin Schneider

Hi,

Quoted 8 lines · Valentin Schneider

The prototype of that function was already hoisted up in

commit 3b1baa6496e6 ("sched/fair: Add 'group_misfit_task' load-balance type")

but that seems to have been missed. Get rid of the extra prototype.

Fixes 2802bf3cd936 ("sched/fair: Add over-utilization/tipping point indicator")

I had forgotten about that one... Ping.

Quoted 19 lines
---
 kernel/sched/fair.c | 1 -
 1 file changed, 1 deletion(-)
kernel/sched/fair.c +0 -2
index 6483834f1278..6d653947a829 100644
@@ -5083,7 +5083,6 @@ static inline void hrtick_update(struct rq *rq)
 
 #ifdef CONFIG_SMP
 static inline unsigned long cpu_util(int cpu);
-static unsigned long capacity_of(int cpu);
 
 static inline bool cpu_overutilized(int cpu)
 {
--

2.20.1