glib-networking: depend on target ca-certificates.
PATCH 1/1 glib-networking: depend on target ca-certificates.
From: Adam Duskett <[email protected]>
Currently, glib-networking uses the hosts ca-certificates, which, if not installed or if they are installed in a different directory will cause a configuration error.
Instead, select and depend on ca-certificates, and add $(TARGET_DIR) to the -Dca_certificates_path option.
Fixes:
http://autobuild.buildroot.net/results/cc0/cc094e0a7c130c60641d32e9f4cbc46b0eba0852/build-end.log
--- package/glib-networking/Config.in | 1 + package/glib-networking/glib-networking.mk | 5 +++-- 2 files changed, 4 insertions(+), 2 deletions(-)
package/glib-networking/Config.in +1 -0
@@ -6,6 +6,7 @@ config BR2_PACKAGE_GLIB_NETWORKING depends on !BR2_STATIC_LIBS # gnutls select BR2_PACKAGE_GNUTLS select BR2_PACKAGE_LIBGLIB2 + select BR2_PACKAGE_CA_CERTIFICATES help Network-related GIO modules for glib.
package/glib-networking/glib-networking.mk +3 -2
@@ -14,10 +14,11 @@ GLIB_NETWORKING_DEPENDENCIES = \ host-pkgconf \ host-intltool \ libglib2 \ - gnutls + gnutls \ + ca-certificates GLIB_NETWORKING_CONF_OPTS = \ - -Dca_certificates_path=/etc/ssl/certs/ca-certificates.crt \ + -Dca_certificates_path=$(TARGET_DIR)/etc/ssl/certs/ca-certificates.crt \ -Dlibproxy_support=false \ -Dgnome_proxy_support=false \ -Dpkcs11_support=false
Signature · 1 line
2.20.1
PATCH 1/1 glib-networking: depend on target ca-certificates.
Adam, All,
Thomas, question for you bbelow...
On 2019-01-02 11:54 -0500, aduskett at gmail.com spake thusly:
Quoted 8 lines
From: Adam Duskett <[email protected]>
Currently, glib-networking uses the hosts ca-certificates, which, if not installed or if they are installed in a different directory will cause a configuration error.
Instead, select and depend on ca-certificates, and add $(TARGET_DIR) to the -Dca_certificates_path option.
As discussed on IRC, this is not the correct fix, because that path is used at runtime.
The proper fix would be to fix their meson.build to behave in cross-compilation.
It is to be noted that upstream no longer has the issue, because they changed the way the handle certifcate trust store:
https://gitlab.gnome.org/GNOME/glib-networking/commit/f1c8feee014007cc913b71357acb609f8d1200df
... but we can't backport this as a fix, though... :-(
Thomas: maybe we can look at updating it instead of trying to fix it?
Regards,
Yann E. MORIN.
Quoted 46 lines
Fixes:
http://autobuild.buildroot.net/results/cc0/cc094e0a7c130c60641d32e9f4cbc46b0eba0852/build-end.logSigned-off-by Adam Duskett <[email protected]>--- package/glib-networking/Config.in | 1 + package/glib-networking/glib-networking.mk | 5 +++-- 2 files changed, 4 insertions(+), 2 deletions(-)package/glib-networking/Config.in +1
-0@@ -6,6 +6,7 @@ config BR2_PACKAGE_GLIB_NETWORKING depends on !BR2_STATIC_LIBS # gnutls select BR2_PACKAGE_GNUTLS select BR2_PACKAGE_LIBGLIB2 + select BR2_PACKAGE_CA_CERTIFICATES help Network-related GIO modules for glib.package/glib-networking/glib-networking.mk +3
-2@@ -14,10 +14,11 @@ GLIB_NETWORKING_DEPENDENCIES = \ host-pkgconf \ host-intltool \ libglib2 \ - gnutls + gnutls \ + ca-certificates GLIB_NETWORKING_CONF_OPTS = \ - -Dca_certificates_path=/etc/ssl/certs/ca-certificates.crt \ + -Dca_certificates_path=$(TARGET_DIR)/etc/ssl/certs/ca-certificates.crt \ -Dlibproxy_support=false \ -Dgnome_proxy_support=false \ -Dpkcs11_support=falseSignature · 6 lines
2.20.1 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 1/1 glib-networking: depend on target ca-certificates.
Hello,
Quoted 1 line · Yann E. MORIN
Thomas: maybe we can look at updating it instead of trying to fix it?
Is there a released/stable, non-development version of glib-networking that contains the commit fixing the issue ?
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 glib-networking: depend on target ca-certificates.
Thomas, All,
On 2019-01-02 20:54 +0100, Thomas Petazzoni spake thusly:
Quoted 4 lines · Yann E. MORIN
Quoted 1 line
Thomas: maybe we can look at updating it instead of trying to fix it?
Is there a released/stable, non-development version of glib-networking that contains the commit fixing the issue ?
There's 2.58.0 which contains the change that no longer requires the path to exist at build time.
Adam, are the versions tightly coupled between glib-networking and glib? I.e, is it possible to use glib-networking-2.58.0 with glib-2.56.3, or do we have to bump both simultaneously?
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'