Skip to contentSkip to conversation

gdb-cross-canadian: Add bison-native for gdb-cross-canadian

PATCH In review Khem Raj 4 participants 7 messages Jan 2, 2019

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/2 gdb-cross-canadian: Add bison-native for gdb-cross-canadian

From: pino-kim <[email protected]>

This fixes RISC-V gdb-cross-canadian cross compile configure failure on missing bison.

---
 meta/recipes-devtools/gdb/gdb-cross-canadian.inc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/recipes-devtools/gdb/gdb-cross-canadian.inc +2 -1
index 475e4f08ef..e54766bbb2 100644
@@ -6,7 +6,8 @@ PN = "gdb-cross-canadian-${TRANSLATED_TARGET_ARCH}"
 BPN = "gdb"
 
 DEPENDS = "nativesdk-ncurses nativesdk-expat nativesdk-gettext \
-           virtual/${HOST_PREFIX}gcc-crosssdk virtual/${HOST_PREFIX}binutils-crosssdk virtual/nativesdk-libc"
+           virtual/${HOST_PREFIX}gcc-crosssdk virtual/${HOST_PREFIX}binutils-crosssdk \
+           virtual/nativesdk-libc bison-native"
 
 GDBPROPREFIX = "--program-prefix='${TARGET_PREFIX}'"
 
Signature · 1 line
2.20.1
author
#1 lore raw

PATCH 2/2 busybox: Enable mountpoint and setsid applets

This is needed by some init system services and if init system is not sysvinit then we dont have it, therefore its useful to have it provided via busybox as a backup

Enable CONFIG_SETSID to get setsid, needed by runit

---
 meta/recipes-core/busybox/busybox/defconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta/recipes-core/busybox/busybox/defconfig +2 -2
index 0c4099031f..d11707abc3 100644
@@ -815,13 +815,13 @@ CONFIG_DC=y
 # CONFIG_FEATURE_MAKEDEVS_TABLE is not set
 # CONFIG_MAN is not set
 CONFIG_MICROCOM=y
-# CONFIG_MOUNTPOINT is not set
+CONFIG_MOUNTPOINT=y
 # CONFIG_MT is not set
 # CONFIG_RAIDAUTORUN is not set
 # CONFIG_READAHEAD is not set
 # CONFIG_RUNLEVEL is not set
 # CONFIG_RX is not set
-# CONFIG_SETSID is not set
+CONFIG_SETSID=y
 # CONFIG_SETFATTR is not set
 CONFIG_STRINGS=y
 CONFIG_TIME=y
Signature · 1 line
2.20.1
#2 lore raw
In reply to Khem Raj
Quoted 16 lines · Khem Raj

From: pino-kim <[email protected]>

This fixes RISC-V gdb-cross-canadian cross compile configure failure on missing bison.

---
 meta/recipes-devtools/gdb/gdb-cross-canadian.inc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/recipes-devtools/gdb/gdb-cross-canadian.inc +0 -0
index 475e4f08ef..e54766bbb2 100644

meta/recipes-devtools/gdb/gdb-cross-canadian.inc PN = "gdb-cross-canadian-${TRANSLATED_TARGET_ARCH}" · line 11

Quoted 7 lines
meta/recipes-devtools/gdb/gdb-cross-canadian.inc +2 -1
@@ -6,7 +6,8 @@ PN = "gdb-cross-canadian-${TRANSLATED_TARGET_ARCH}"
 BPN = "gdb"
 
 DEPENDS = "nativesdk-ncurses nativesdk-expat nativesdk-gettext \
-           virtual/${HOST_PREFIX}gcc-crosssdk virtual/${HOST_PREFIX}binutils-crosssdk virtual/nativesdk-libc"
+           virtual/${HOST_PREFIX}gcc-crosssdk virtual/${HOST_PREFIX}binutils-crosssdk \
+           virtual/nativesdk-libc bison-native"
 

Would it make sense to restrict this to DEPENDS_append_riscv32/64 ?

Quoted 10 lines
meta/recipes-devtools/gdb/gdb-cross-canadian.inc +0 -1
 GDBPROPREFIX = "--program-prefix='${TARGET_PREFIX}'"
 
--

2.20.1

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

author
#3 lore raw
Quoted 20 lines · Jacob Kroon
Quoted 18 lines · Khem Raj

From: pino-kim <[email protected]>

This fixes RISC-V gdb-cross-canadian cross compile configure failure on missing bison.

---
 meta/recipes-devtools/gdb/gdb-cross-canadian.inc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/recipes-devtools/gdb/gdb-cross-canadian.inc +0 -0
index 475e4f08ef..e54766bbb2 100644
@@ -6,7 +6,8 @@ PN = "gdb-cross-canadian-${TRANSLATED_TARGET_ARCH}"
 BPN = "gdb"
 
Quoted 7 lines

meta/recipes-devtools/gdb/gdb-cross-canadian.inc PN = "gdb-cross-canadian-${TRANSLATED_TARGET_ARCH}" · line 11

Quoted 5 lines
meta/recipes-devtools/gdb/gdb-cross-canadian.inc +2 -1
 DEPENDS = "nativesdk-ncurses nativesdk-expat nativesdk-gettext \
-           virtual/${HOST_PREFIX}gcc-crosssdk virtual/${HOST_PREFIX}binutils-crosssdk virtual/nativesdk-libc"
+           virtual/${HOST_PREFIX}gcc-crosssdk virtual/${HOST_PREFIX}binutils-crosssdk \
+           virtual/nativesdk-libc bison-native"
 

Would it make sense to restrict this to DEPENDS_append_riscv32/64 ?

Its not particular to riscv, it just happens to unearth the problem for us since its building gdb from upstream
master, we are going to land into this problem eventually when we upgrade.

Quoted 11 lines
Quoted 11 lines
meta/recipes-devtools/gdb/gdb-cross-canadian.inc +0 -1
 GDBPROPREFIX = "--program-prefix='${TARGET_PREFIX}'"
 
--

2.20.1

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#4 lore raw
Quoted 33 lines · Khem Raj
Quoted 21 lines · Jacob Kroon
Quoted 20 lines · Khem Raj

From: pino-kim <[email protected]>

This fixes RISC-V gdb-cross-canadian cross compile configure failure on missing bison.

---
 meta/recipes-devtools/gdb/gdb-cross-canadian.inc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/recipes-devtools/gdb/gdb-cross-canadian.inc +0 -0
index 475e4f08ef..e54766bbb2 100644
@@ -6,7 +6,8 @@ PN = "gdb-cross-canadian-

${TRANSLATED_TARGET_ARCH}"
BPN = "gdb"

Quoted 9 lines
Quoted 7 lines

DEPENDS = "nativesdk-ncurses nativesdk-expat nativesdk-gettext \
- virtual/${HOST_PREFIX}gcc-crosssdk
virtual/${HOST_PREFIX}binutils-crosssdk virtual/nativesdk-libc"
+ virtual/${HOST_PREFIX}gcc-crosssdk
virtual/${HOST_PREFIX}binutils-crosssdk \
+ virtual/nativesdk-libc bison-native"

Would it make sense to restrict this to DEPENDS_append_riscv32/64 ?

Quoted 4 lines

Its not particular to riscv, it just happens to unearth the problem for us since its building gdb from upstream
master, we are going to land into this problem eventually when we upgrade.

Is this not a tarball verses source control issue (the git version needs the dependency, the tarball doesn't)?

Cheers,

Richard

author
#5 lore raw
Quoted 35 lines · Richard Purdie
Quoted 33 lines · Khem Raj
Quoted 30 lines · Jacob Kroon
Quoted 20 lines · Khem Raj

From: pino-kim <[email protected]>

This fixes RISC-V gdb-cross-canadian cross compile configure failure on missing bison.

---
 meta/recipes-devtools/gdb/gdb-cross-canadian.inc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/recipes-devtools/gdb/gdb-cross-canadian.inc +0 -0
index 475e4f08ef..e54766bbb2 100644
@@ -6,7 +6,8 @@ PN = "gdb-cross-canadian-

${TRANSLATED_TARGET_ARCH}"
BPN = "gdb"

Quoted 7 lines

DEPENDS = "nativesdk-ncurses nativesdk-expat nativesdk-gettext \
- virtual/${HOST_PREFIX}gcc-crosssdk
virtual/${HOST_PREFIX}binutils-crosssdk virtual/nativesdk-libc"
+ virtual/${HOST_PREFIX}gcc-crosssdk
virtual/${HOST_PREFIX}binutils-crosssdk \
+ virtual/nativesdk-libc bison-native"

Would it make sense to restrict this to DEPENDS_append_riscv32/64 ?

Quoted 7 lines
Quoted 4 lines

Its not particular to riscv, it just happens to unearth the problem for us since its building gdb from upstream
master, we are going to land into this problem eventually when we upgrade.

Is this not a tarball verses source control issue (the git version needs the dependency, the tarball doesn't)?

yes that has triggered it but I have also seen it on certain bare minimum build host OSes in past
even with tarballs.

#6 lore raw

✗ patchtest: failure for "gdb-cross-canadian: Add bison-..." and 1 more

In reply to Khem Raj

== Series Details ==

Series: "gdb-cross-canadian: Add bison-..." and 1 more
Revision: 1
URL : https://patchwork.openembedded.org/series/15503/
State : failure

== Summary ==

Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures:

* Issue Series does not apply on top of target branch [test_series_merge_on_head]
Suggested fix Rebase your series on top of targeted branch
Targeted branch master (currently at 65c419b8c4)

If you believe any of these test results are incorrect, please reply to the mailing list ([email protected]) raising your concerns. Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...).

---

Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe