block: sunvdc: don't run hw queue synchronously from irq context
PATCH 1/1 block: sunvdc: don't run hw queue synchronously from irq context
vdc_blk_queue_start() may be called from irq context, so we can't run queue via blk_mq_start_hw_queues() since we never allow to run queue from irq context. Use blk_mq_start_stopped_hw_queues(q, true) to fix this issue.
--- drivers/block/sunvdc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/block/sunvdc.c +1 -1
@@ -181,7 +181,7 @@ static void vdc_blk_queue_start(struct vdc_port *port)* allocated a disk. */ if (port->disk &&vdc_tx_dring_avail (dr) *100 /VDC_TX_RING_SIZE >=50 ) -blk_mq_start_hw_queues (port->disk->queue); +blk_mq_start_stopped_hw_queues (port->disk->queue, true); }static void vdc_finish (struct vio_driver_state *vio,int err,int waiting_for)
Signature · 1 line
2.9.5
From: Ming Lei <[email protected]>
Date: Thu, 3 Jan 2019 09:19:48 +0800
Quoted 5 lines
vdc_blk_queue_start()may be called from irq context, so we can't run queue viablk_mq_start_hw_queues()since we never allow to run queue from irq context. Useblk_mq_start_stopped_hw_queues(q, true)to fix this issue.
Quoted 7 lines
Fixes fa182a1fa97dff56cd ("sunvdc: convert to blk-mq")Reported-by Anatoly Pugachev <[email protected]>Tested-by Anatoly Pugachev <[email protected]>Cc Anatoly Pugachev <[email protected]>Cc David Miller <[email protected]>Signed-off-by Ming Lei <[email protected]>
Jens Axboe
maintainerQuoted 4 lines · Ming Lei
vdc_blk_queue_start()may be called from irq context, so we can't run queue viablk_mq_start_hw_queues()since we never allow to run queue from irq context. Useblk_mq_start_stopped_hw_queues(q, true)to fix this issue.
Thanks Ming, applied.
Signature · 1 line
Jens Axboe