ipv6: Fix dump of specific table with strict checking
Subsystems (3)
David Ahern
maintainerPATCH 1/1 ipv6: Fix dump of specific table with strict checking
From: David Ahern <[email protected]>
Dump of a specific table with strict checking enabled is looping. The problem is that the end of the table dump is not marked in the cb. When dumping a specific table, cb args 0 and 1 are not used (they are the hash index and entry with an hash table index when dumping all tables). Re-use args[0] to hold a 'done' flag for the specific table dump.
--- net/ipv6/ip6_fib.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
net/ipv6/ip6_fib.c +5 -1
@@ -627,7 +627,11 @@ static int inet6_dump_fib(struct sk_buff *skb, struct netlink_callback *cb)return -ENOENT ; } - res =fib6_dump_table (tb, skb, cb); +if (!cb->args[0 ]) { + res =fib6_dump_table (tb, skb, cb); +if (!res) + cb->args[0 ] =1 ; + } goto out; }
Signature · 1 line
2.11.0
David Miller
maintainerFrom: David Ahern <[email protected]>
Date: Wed, 2 Jan 2019 18:26:13 -0800
Quoted 11 lines
From: David Ahern <[email protected]>
Dump of a specific table with strict checking enabled is looping. The problem is that the end of the table dump is not marked in the cb. When dumping a specific table, cb args 0 and 1 are not used (they are the hash index and entry with an hash table index when dumping all tables). Re-use args[0] to hold a 'done' flag for the specific table dump.
Fixes 13e38901d46ca ("net/ipv6: Plumb support for filtering route dumps")Reported-by Jakub Kicinski <[email protected]>Signed-off-by David Ahern <[email protected]>
Applied and queued up for -stable.