Skip to contentSkip to conversation

MTD: mxs_nand: Fix BCH read timeout error on boards requiring ECC

PATCH In review Adam Ford 7 participants 11 messages Jan 3, 2019 – Feb 16, 2019

Subsystems (3)
lore
Share & tools
lore

Adam Ford

author
#0 lore raw

PATCH 1/1 MTD: mxs_nand: Fix BCH read timeout error on boards requiring ECC

The LogicPD board uses a Micron Flash with ECC. To boot this from SPL, the ECC needs to be correctly configured or the BCH engine times out.

drivers/mtd/nand/raw/mxs_nand.c +6 -0
index e3341812a2..2d84bfffe2 100644
@@ -1163,6 +1163,12 @@ int mxs_nand_init_spl(struct nand_chip *nand)
 
 	nand_info->gpmi_regs = (struct mxs_gpmi_regs *)MXS_GPMI_BASE;
 	nand_info->bch_regs = (struct mxs_bch_regs *)MXS_BCH_BASE;
+
+	if (is_mx6sx() || is_mx7())
+		nand_info->max_ecc_strength_supported = 62;
+	else
+		nand_info->max_ecc_strength_supported = 40;
+
 	err = mxs_nand_alloc_buffers(nand_info);
 	if (err)
 		return err;
drivers/mtd/nand/raw/mxs_nand_spl.c +1 -0
index c628f3adec..ba85baac60 100644
@@ -201,6 +201,7 @@ static int mxs_nand_init(void)
 	/* setup flash layout (does not scan as we override that) */
 	mtd->size = nand_chip.chipsize;
 	nand_chip.scan_bbt(mtd);
+	mxs_nand_setup_ecc(mtd);
 
 	return 0;
 }
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 MTD: mxs_nand: Fix BCH read timeout error on boards requiring ECC

[this time using reply to all]

Quoted 5 lines · Adam Ford

The LogicPD board uses a Micron Flash with ECC. To boot this from SPL, the ECC needs to be correctly configured or the BCH engine times out.

Looks good to me,

Quoted 31 lines
drivers/mtd/nand/raw/mxs_nand.c +6 -0
index e3341812a2..2d84bfffe2 100644
@@ -1163,6 +1163,12 @@ int mxs_nand_init_spl(struct nand_chip *nand)
 
 	nand_info->gpmi_regs = (struct mxs_gpmi_regs *)MXS_GPMI_BASE;
 	nand_info->bch_regs = (struct mxs_bch_regs *)MXS_BCH_BASE;
+
+	if (is_mx6sx() || is_mx7())
+		nand_info->max_ecc_strength_supported = 62;
+	else
+		nand_info->max_ecc_strength_supported = 40;
+
 	err = mxs_nand_alloc_buffers(nand_info);
 	if (err)
 		return err;
drivers/mtd/nand/raw/mxs_nand_spl.c +1 -0
index c628f3adec..ba85baac60 100644
@@ -201,6 +201,7 @@ static int mxs_nand_init(void)
 	/* setup flash layout (does not scan as we override that) */
 	mtd->size = nand_chip.chipsize;
 	nand_chip.scan_bbt(mtd);
+	mxs_nand_setup_ecc(mtd);
 
 	return 0;
 }
#2 lore raw

PATCH 1/1 MTD: mxs_nand: Fix BCH read timeout error on boards requiring ECC

Hi,

Quoted 7 lines · Stefan Agner

[this time using reply to all]

Quoted 4 lines · Adam Ford

The LogicPD board uses a Micron Flash with ECC. To boot this from SPL, the ECC needs to be correctly configured or the BCH engine times out.

Quoted 5 lines
Quoted 1 line

Looks good to me,

Tested on a custom i.MX6ULL board with Micron NAND flash.

Fixes:

"""
Trying to boot from NAND
MXS NAND: BCH read timeout
...
MXS NAND: BCH read timeout
"""

Quoted 30 lines
Quoted 30 lines
drivers/mtd/nand/raw/mxs_nand.c +6 -0
index e3341812a2..2d84bfffe2 100644
@@ -1163,6 +1163,12 @@ int mxs_nand_init_spl(struct nand_chip *nand)
 
 	nand_info->gpmi_regs = (struct mxs_gpmi_regs *)MXS_GPMI_BASE;
 	nand_info->bch_regs = (struct mxs_bch_regs *)MXS_BCH_BASE;
+
+	if (is_mx6sx() || is_mx7())
+		nand_info->max_ecc_strength_supported = 62;
+	else
+		nand_info->max_ecc_strength_supported = 40;
+
 	err = mxs_nand_alloc_buffers(nand_info);
 	if (err)
 		return err;
drivers/mtd/nand/raw/mxs_nand_spl.c +1 -0
index c628f3adec..ba85baac60 100644
@@ -201,6 +201,7 @@ static int mxs_nand_init(void)
 	/* setup flash layout (does not scan as we override that) */
 	mtd->size = nand_chip.chipsize;
 	nand_chip.scan_bbt(mtd);
+	mxs_nand_setup_ecc(mtd);
 
 	return 0;
 }
#3 lore raw

PATCH 1/1 MTD: mxs_nand: Fix BCH read timeout error on boards requiring ECC

In reply to Adam Ford
Quoted 37 lines · Adam Ford

The LogicPD board uses a Micron Flash with ECC. To boot this from SPL, the ECC needs to be correctly configured or the BCH engine times out.

drivers/mtd/nand/raw/mxs_nand.c +6 -0
index e3341812a2..2d84bfffe2 100644
@@ -1163,6 +1163,12 @@ int mxs_nand_init_spl(struct nand_chip *nand)
 
        nand_info->gpmi_regs = (struct mxs_gpmi_regs *)MXS_GPMI_BASE;
        nand_info->bch_regs = (struct mxs_bch_regs *)MXS_BCH_BASE;
+
+       if (is_mx6sx() || is_mx7())
+               nand_info->max_ecc_strength_supported = 62;
+       else
+               nand_info->max_ecc_strength_supported = 40;
+
        err = mxs_nand_alloc_buffers(nand_info);
        if (err)
                return err;
drivers/mtd/nand/raw/mxs_nand_spl.c +1 -1
index c628f3adec..ba85baac60 100644
@@ -201,6 +201,7 @@ static int mxs_nand_init(void)
        /* setup flash layout (does not scan as we override that) */
        mtd->size = nand_chip.chipsize;
        nand_chip.scan_bbt(mtd);
+       mxs_nand_setup_ecc(mtd);
 
        return 0;
 }
--
Quoted 2 lines

2.17.1

Thanks Adam,

This resolves failed booting on Gateworks Ventana IMX6 with NAND SPL for MT29F2G08AB 2Gbit (oob=64)

for GW5100 with MT29F2G08AB 2Gbit (oob=64)

author
#4 lore raw

PATCH 1/1 MTD: mxs_nand: Fix BCH read timeout error on boards requiring ECC

Quoted 36 lines · Tim Harvey
Quoted 34 lines · Adam Ford

The LogicPD board uses a Micron Flash with ECC. To boot this from SPL, the ECC needs to be correctly configured or the BCH engine times out.

drivers/mtd/nand/raw/mxs_nand.c +6 -0
index e3341812a2..2d84bfffe2 100644
@@ -1163,6 +1163,12 @@ int mxs_nand_init_spl(struct nand_chip *nand)
 
        nand_info->gpmi_regs = (struct mxs_gpmi_regs *)MXS_GPMI_BASE;
        nand_info->bch_regs = (struct mxs_bch_regs *)MXS_BCH_BASE;
+
+       if (is_mx6sx() || is_mx7())
+               nand_info->max_ecc_strength_supported = 62;
+       else
+               nand_info->max_ecc_strength_supported = 40;
+
        err = mxs_nand_alloc_buffers(nand_info);
        if (err)
                return err;
drivers/mtd/nand/raw/mxs_nand_spl.c +1 -0
index c628f3adec..ba85baac60 100644
@@ -201,6 +201,7 @@ static int mxs_nand_init(void)
        /* setup flash layout (does not scan as we override that) */
        mtd->size = nand_chip.chipsize;
        nand_chip.scan_bbt(mtd);
+       mxs_nand_setup_ecc(mtd);
 
Quoted 7 lines
Quoted 5 lines
drivers/mtd/nand/raw/mxs_nand_spl.c +0 -1
        return 0;
 }
--

2.17.1

Thanks Adam,

Scott / Stefano,

Any chance this can get reviewed and/or applied for the next release? We've got a few people who have their respective tested-by comments.

adam

Quoted 8 lines

This resolves failed booting on Gateworks Ventana IMX6 with NAND SPL for MT29F2G08AB 2Gbit (oob=64)

for GW5100 with MT29F2G08AB 2Gbit (oob=64)

author
#5 lore raw

PATCH 1/1 MTD: mxs_nand: Fix BCH read timeout error on boards requiring ECC

Quoted 38 lines · Adam Ford
Quoted 36 lines · Tim Harvey
Quoted 34 lines · Adam Ford

The LogicPD board uses a Micron Flash with ECC. To boot this from SPL, the ECC needs to be correctly configured or the BCH engine times out.

drivers/mtd/nand/raw/mxs_nand.c +6 -0
index e3341812a2..2d84bfffe2 100644
@@ -1163,6 +1163,12 @@ int mxs_nand_init_spl(struct nand_chip *nand)
 
        nand_info->gpmi_regs = (struct mxs_gpmi_regs *)MXS_GPMI_BASE;
        nand_info->bch_regs = (struct mxs_bch_regs *)MXS_BCH_BASE;
+
+       if (is_mx6sx() || is_mx7())
+               nand_info->max_ecc_strength_supported = 62;
+       else
+               nand_info->max_ecc_strength_supported = 40;
+
        err = mxs_nand_alloc_buffers(nand_info);
        if (err)
                return err;
drivers/mtd/nand/raw/mxs_nand_spl.c +1 -0
index c628f3adec..ba85baac60 100644
@@ -201,6 +201,7 @@ static int mxs_nand_init(void)
        /* setup flash layout (does not scan as we override that) */
        mtd->size = nand_chip.chipsize;
        nand_chip.scan_bbt(mtd);
+       mxs_nand_setup_ecc(mtd);
 
Quoted 8 lines
Quoted 7 lines
Quoted 5 lines
drivers/mtd/nand/raw/mxs_nand_spl.c +0 -1
        return 0;
 }
--

2.17.1

Thanks Adam,

Scott / Stefano,

I had to use Scott's other -email.

Any chance this can get reviewed and/or applied for the next release? We've got a few people who have their respective tested-by comments.

adam

Quoted 8 lines
Quoted 8 lines

This resolves failed booting on Gateworks Ventana IMX6 with NAND SPL for MT29F2G08AB 2Gbit (oob=64)

for GW5100 with MT29F2G08AB 2Gbit (oob=64)

#6 lore raw

PATCH 1/1 MTD: mxs_nand: Fix BCH read timeout error on boards requiring ECC

Quoted 49 lines · Adam Ford
Quoted 40 lines · Adam Ford
Quoted 38 lines · Tim Harvey
Quoted 36 lines · Adam Ford

The LogicPD board uses a Micron Flash with ECC. To boot this from SPL, the ECC needs to be correctly configured or the BCH engine times out.

drivers/mtd/nand/raw/mxs_nand.c +6 -0
index e3341812a2..2d84bfffe2 100644
@@ -1163,6 +1163,12 @@ int mxs_nand_init_spl(struct nand_chip *nand)
 
        nand_info->gpmi_regs = (struct mxs_gpmi_regs *)MXS_GPMI_BASE;
        nand_info->bch_regs = (struct mxs_bch_regs *)MXS_BCH_BASE;
+
+       if (is_mx6sx() || is_mx7())
+               nand_info->max_ecc_strength_supported = 62;
+       else
+               nand_info->max_ecc_strength_supported = 40;
+
        err = mxs_nand_alloc_buffers(nand_info);
        if (err)
                return err;
drivers/mtd/nand/raw/mxs_nand_spl.c +1 -0
index c628f3adec..ba85baac60 100644
@@ -201,6 +201,7 @@ static int mxs_nand_init(void)
        /* setup flash layout (does not scan as we override that) */
        mtd->size = nand_chip.chipsize;
        nand_chip.scan_bbt(mtd);
+       mxs_nand_setup_ecc(mtd);
 
Quoted 7 lines
Quoted 7 lines
Quoted 5 lines
drivers/mtd/nand/raw/mxs_nand_spl.c +0 -1
        return 0;
 }
--

2.17.1

Thanks Adam,

Quoted 7 lines

Scott / Stefano,

I had to use Scott's other -email.

Any chance this can get reviewed and/or applied for the next release? We've got a few people who have their respective tested-by comments.

I haven't been involved in U-Boot for a while now.

-Scott

author
#7 lore raw

PATCH 1/1 MTD: mxs_nand: Fix BCH read timeout error on boards requiring ECC

Quoted 53 lines · Scott Wood
Quoted 51 lines · Adam Ford
Quoted 40 lines · Adam Ford
Quoted 38 lines · Tim Harvey
Quoted 36 lines · Adam Ford

The LogicPD board uses a Micron Flash with ECC. To boot this from SPL, the ECC needs to be correctly configured or the BCH engine times out.

drivers/mtd/nand/raw/mxs_nand.c +6 -0
index e3341812a2..2d84bfffe2 100644
@@ -1163,6 +1163,12 @@ int mxs_nand_init_spl(struct nand_chip *nand)
 
        nand_info->gpmi_regs = (struct mxs_gpmi_regs *)MXS_GPMI_BASE;
        nand_info->bch_regs = (struct mxs_bch_regs *)MXS_BCH_BASE;
+
+       if (is_mx6sx() || is_mx7())
+               nand_info->max_ecc_strength_supported = 62;
+       else
+               nand_info->max_ecc_strength_supported = 40;
+
        err = mxs_nand_alloc_buffers(nand_info);
        if (err)
                return err;
drivers/mtd/nand/raw/mxs_nand_spl.c +1 -0
index c628f3adec..ba85baac60 100644
@@ -201,6 +201,7 @@ static int mxs_nand_init(void)
        /* setup flash layout (does not scan as we override that) */
        mtd->size = nand_chip.chipsize;
        nand_chip.scan_bbt(mtd);
+       mxs_nand_setup_ecc(mtd);
 
Quoted 7 lines
Quoted 7 lines
Quoted 5 lines
drivers/mtd/nand/raw/mxs_nand_spl.c +0 -1
        return 0;
 }
--

2.17.1

Thanks Adam,

Scott / Stefano,

Quoted 7 lines
Quoted 5 lines

I had to use Scott's other -email.

Any chance this can get reviewed and/or applied for the next release? We've got a few people who have their respective tested-by comments.

I haven't been involved in U-Boot for a while now.

Tom / Stefano,

Patchwork is showing this is being delegated to Scott, but he's saying he isn't the right person. Is there someone else who can review and/or apply a few of these patches designated to Scott? Both of the patches I care about deligated to him are imx6 related

thanks,

adam

Quoted 4 lines

-Scott

#8 lore raw

PATCH 1/1 MTD: mxs_nand: Fix BCH read timeout error on boards requiring ECC

Quoted 60 lines · Adam Ford
Quoted 59 lines · Scott Wood
Quoted 56 lines · Adam Ford
Quoted 40 lines · Adam Ford
Quoted 38 lines · Tim Harvey
Quoted 36 lines · Adam Ford

The LogicPD board uses a Micron Flash with ECC. To boot this from SPL, the ECC needs to be correctly configured or the BCH engine times out.

drivers/mtd/nand/raw/mxs_nand.c +6 -0
index e3341812a2..2d84bfffe2 100644
@@ -1163,6 +1163,12 @@ int mxs_nand_init_spl(struct nand_chip *nand)
 
        nand_info->gpmi_regs = (struct mxs_gpmi_regs *)MXS_GPMI_BASE;
        nand_info->bch_regs = (struct mxs_bch_regs *)MXS_BCH_BASE;
+
+       if (is_mx6sx() || is_mx7())
+               nand_info->max_ecc_strength_supported = 62;
+       else
+               nand_info->max_ecc_strength_supported = 40;
+
        err = mxs_nand_alloc_buffers(nand_info);
        if (err)
                return err;
drivers/mtd/nand/raw/mxs_nand_spl.c +1 -0
index c628f3adec..ba85baac60 100644
@@ -201,6 +201,7 @@ static int mxs_nand_init(void)
        /* setup flash layout (does not scan as we override that) */
        mtd->size = nand_chip.chipsize;
        nand_chip.scan_bbt(mtd);
+       mxs_nand_setup_ecc(mtd);
 
Quoted 7 lines
Quoted 7 lines
Quoted 5 lines
drivers/mtd/nand/raw/mxs_nand_spl.c +0 -1
        return 0;
 }
--

2.17.1

Thanks Adam,

Scott / Stefano,

I had to use Scott's other -email.

Any chance this can get reviewed and/or applied for the next release? We've got a few people who have their respective tested-by comments.

Quoted 8 lines
Quoted 1 line

I haven't been involved in U-Boot for a while now.

Tom / Stefano,

Patchwork is showing this is being delegated to Scott, but he's saying he isn't the right person. Is there someone else who can review and/or apply a few of these patches designated to Scott? Both of the patches I care about deligated to him are imx6 related

I've assigned the mxs related patches to Stefano, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190212/902fe63b/attachment.sig>
#9 lore raw

PATCH 1/1 MTD: mxs_nand: Fix BCH read timeout error on boards requiring ECC

Quoted 63 lines · Tom Rini
Quoted 62 lines · Adam Ford
Quoted 60 lines · Scott Wood
Quoted 49 lines · Adam Ford
Quoted 40 lines · Adam Ford
Quoted 38 lines · Tim Harvey
Quoted 36 lines · Adam Ford

The LogicPD board uses a Micron Flash with ECC. To boot this from SPL, the ECC needs to be correctly configured or the BCH engine times out.

drivers/mtd/nand/raw/mxs_nand.c +6 -0
index e3341812a2..2d84bfffe2 100644
@@ -1163,6 +1163,12 @@ int mxs_nand_init_spl(struct nand_chip *nand)
 
        nand_info->gpmi_regs = (struct mxs_gpmi_regs *)MXS_GPMI_BASE;
        nand_info->bch_regs = (struct mxs_bch_regs *)MXS_BCH_BASE;
+
+       if (is_mx6sx() || is_mx7())
+               nand_info->max_ecc_strength_supported = 62;
+       else
+               nand_info->max_ecc_strength_supported = 40;
+
        err = mxs_nand_alloc_buffers(nand_info);
        if (err)
                return err;
drivers/mtd/nand/raw/mxs_nand_spl.c +1 -0
index c628f3adec..ba85baac60 100644
@@ -201,6 +201,7 @@ static int mxs_nand_init(void)
        /* setup flash layout (does not scan as we override that) */
        mtd->size = nand_chip.chipsize;
        nand_chip.scan_bbt(mtd);
+       mxs_nand_setup_ecc(mtd);
 
Quoted 7 lines
Quoted 7 lines
Quoted 5 lines
drivers/mtd/nand/raw/mxs_nand_spl.c +0 -1
        return 0;
 }
--

2.17.1

Thanks Adam,

Quoted 7 lines

Scott / Stefano,

I had to use Scott's other -email.

Any chance this can get reviewed and/or applied for the next release? We've got a few people who have their respective tested-by comments.

I haven't been involved in U-Boot for a while now.

Quoted 9 lines
Quoted 6 lines

Tom / Stefano,

Patchwork is showing this is being delegated to Scott, but he's saying he isn't the right person. Is there someone else who can review and/or apply a few of these patches designated to Scott? Both of the patches I care about deligated to him are imx6 related

I've assigned the mxs related patches to Stefano, thanks!

Ok, thanks - I take care of this.

Regards,
Stefano

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#10 lore raw
In reply to Adam Ford
Quoted 30 lines

The LogicPD board uses a Micron Flash with ECC. To boot this from SPL, the ECC needs to be correctly configured or the BCH engine times out.

drivers/mtd/nand/raw/mxs_nand.c +6 -0
index e3341812a2..2d84bfffe2 100644
@@ -1163,6 +1163,12 @@ int mxs_nand_init_spl(struct nand_chip *nand)
 
 	nand_info->gpmi_regs = (struct mxs_gpmi_regs *)MXS_GPMI_BASE;
 	nand_info->bch_regs = (struct mxs_bch_regs *)MXS_BCH_BASE;
+
+	if (is_mx6sx() || is_mx7())
+		nand_info->max_ecc_strength_supported = 62;
+	else
+		nand_info->max_ecc_strength_supported = 40;
+
 	err = mxs_nand_alloc_buffers(nand_info);
 	if (err)
 		return err;
drivers/mtd/nand/raw/mxs_nand_spl.c +0 -0
index c628f3adec..ba85baac60 100644

drivers/mtd/nand/raw/mxs_nand_spl.c static int mxs_nand_init(void) · line 207

Quoted 7 lines
drivers/mtd/nand/raw/mxs_nand_spl.c +1 -0
@@ -201,6 +201,7 @@ static int mxs_nand_init(void)
 	/* setup flash layout (does not scan as we override that) */
 	mtd->size = nand_chip.chipsize;
 	nand_chip.scan_bbt(mtd);
+	mxs_nand_setup_ecc(mtd);
 
 	return 0;
 }

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================