dm: usb: gadget: Fix boot breakage on sunxi platforms
PATCH 1/1 dm: usb: gadget: Fix boot breakage on sunxi platforms
Fixes commit 013116243950 ("dm: usb: create a new UCLASS ID for USB gadget devices")
The UCLASS_DRIVER for id UCLASS_USB_GADGET_GENERIC needs to be declared even for platforms that do not enable DM_USB_GADGET. Otherwise the driver for their usb peripheral controller fails to bind.
---
build status available here: https://travis-ci.org/jjhiblot/u-boot/builds/470396811
drivers/usb/gadget/udc/Makefile | 3 ++- drivers/usb/gadget/udc/udc-uclass.c | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-)
drivers/usb/gadget/udc/Makefile +2 -1
@@ -6,4 +6,5 @@ ifndef CONFIG_$(SPL_)DM_USB_GADGET obj-$(CONFIG_USB_DWC3_GADGET) += udc-core.o endif -obj-$(CONFIG_$(SPL_)DM_USB_GADGET) += udc-uclass.o udc-core.o +obj-$(CONFIG_$(SPL_)DM_USB_GADGET) += udc-core.o +obj-$(CONFIG_$(SPL_)DM) += udc-uclass.o
drivers/usb/gadget/udc/udc-uclass.c +2 -0
@@ -9,6 +9,7 @@#include <dm/device-internal.h> #include <linux/usb/gadget.h> +#if CONFIG_IS_ENABLED (DM_USB_GADGET )#define MAX_UDC_DEVICES 4static struct udevice *dev_array[MAX_UDC_DEVICES ];int usb_gadget_initialize (int index)
@@ -51,6 +52,7 @@ int usb_gadget_handle_interrupts(int index)return -EINVAL ;return dm_usb_gadget_handle_interrupts (dev_array[index]); } +#endif UCLASS_DRIVER (usb_gadget_generic) = { .id =UCLASS_USB_GADGET_GENERIC ,
Signature · 1 line
2.7.4
PATCH 1/1 dm: usb: gadget: Fix boot breakage on sunxi platforms
Quoted 1 line · Jean-Jacques Hiblot
Better to have proper commit head that tells the real issue.
Quoted 6 lines
Fixes commit 013116243950 ("dm: usb: create a new UCLASS ID for USB gadget devices")
The
UCLASS_DRIVERfor idUCLASS_USB_GADGET_GENERICneeds to be declared even for platforms that do not enableDM_USB_GADGET. Otherwise the driver for their usb peripheral controller fails to bind.
Sorry this is unclear, you are trying to skip DM_USB_GADGET code even though UCLASS_USB_GADGET_GENERIC id used. does it make sense?
PATCH 1/1 dm: usb: gadget: Fix boot breakage on sunxi platforms
Quoted 9 lines · Jagan Teki
Quoted 1 line · Jean-Jacques Hiblot
Better to have proper commit head that tells the real issue.
Quoted 3 lines
Fixes commit 013116243950 ("dm: usb: create a new UCLASS ID for USB gadget devices")
Quoted 6 lines
Quoted 3 lines
The
UCLASS_DRIVERfor idUCLASS_USB_GADGET_GENERICneeds to be declared even for platforms that do not enableDM_USB_GADGET. Otherwise the driver for their usb peripheral controller fails to bind.Sorry this is unclear, you are trying to skip
DM_USB_GADGETcode even thoughUCLASS_USB_GADGET_GENERICid used. does it make sense?
Any response on this?
We need the fix asap since the release is about a week.
PATCH 1/1 dm: usb: gadget: Fix boot breakage on sunxi platforms
Quoted 14 lines · Jagan Teki
Quoted 13 lines · Jagan Teki
Quoted 1 line · Jean-Jacques Hiblot
Better to have proper commit head that tells the real issue.
Quoted 6 lines
Fixes commit 013116243950 ("dm: usb: create a new UCLASS ID for USB gadget devices")
The
UCLASS_DRIVERfor idUCLASS_USB_GADGET_GENERICneeds to be declared even for platforms that do not enableDM_USB_GADGET. Otherwise the driver for their usb peripheral controller fails to bind.
Quoted 6 lines
Quoted 2 lines
Sorry this is unclear, you are trying to skip
DM_USB_GADGETcode even thoughUCLASS_USB_GADGET_GENERICid used. does it make sense?Any response on this?
We need the fix asap since the release is about a week.
I suspect most people are having xmas vacation, so pushing hard won't help. It seems you had some comment on the patch, so I expect a reply from Jean and possibly a V2.
Signature · 2 lines
Best regards, Marek Vasut
PATCH 1/1 dm: usb: gadget: Fix boot breakage on sunxi platforms
In reply to Jagan TekiQuoted 3 lines · Jagan Teki
Quoted 2 lines · Jagan Teki
On Fri, Dec 21, 2018 at 2:20 PM Jean-Jacques Hiblot <[email protected]> wrote:
Better to have proper commit head that tells the real issue.
I found it hard to come up with a short description of the real issue.
At least this title makes it clear that it is a regression fix, not a new feature.
The details of the failures are in the commit log (or so I thought)
Quoted 9 lines
Quoted 9 lines
Quoted 7 lines
Fixes commit 013116243950 ("dm: usb: create a new UCLASS ID for USB gadget devices")
The
UCLASS_DRIVERfor idUCLASS_USB_GADGET_GENERICneeds to be declared even for platforms that do not enableDM_USB_GADGET. Otherwise the driver for their usb peripheral controller fails to bind.Sorry this is unclear, you are trying to skip
DM_USB_GADGETcode even thoughUCLASS_USB_GADGET_GENERICid used. does it make sense?
Sorry for the delay. This was indeed a vacation time.
This patch does not skip DM_USB_GADGET. What it does is declare the UCLASS_DRIVER for USB peripheral devices even if DM_USB_GADGET is not set.
DM_USB_GADGET is a new option and not (yet) widely used and some drivers have their own version of the DM support for gadget drivers (ie they implement their own version of usb_gadget_initialize(), usb_gadget_release() and usb_gadget_handle_interrupts()). However all those drivers use the UCLASS_USB_GADGET_GENERIC uclass ID and thus the UCLASS_DRIVER for UCLASS_USB_GADGET_GENERIC must be declared. In the past they used UCLASS_USB_DEV_GENERIC, but this option is intended for the host side.
JJ
Quoted 4 lines
Any response on this?
We need the fix asap since the release is about a week.
PATCH 1/1 dm: usb: gadget: Fix boot breakage on sunxi platforms
Quoted 32 lines · On Wed, 2 Jan 2019 11:38:47 +0100 Jean-Jacques Hiblot <[email protected]> wrote:
Quoted 5 lines · Jagan Teki
Quoted 3 lines · Jagan Teki
On Fri, Dec 21, 2018 at 2:20 PM Jean-Jacques Hiblot <[email protected]> wrote: Better to have proper commit head that tells the real issue.
I found it hard to come up with a short description of the real issue.
At least this title makes it clear that it is a regression fix, not a new feature.
The details of the failures are in the commit log (or so I thought)
Quoted 11 lines
Quoted 11 lines
Quoted 8 lines
Fixes commit 013116243950 ("dm: usb: create a new UCLASS ID for USB gadget devices")
The
UCLASS_DRIVERfor idUCLASS_USB_GADGET_GENERICneeds to be declared even for platforms that do not enableDM_USB_GADGET. Otherwise the driver for their usb peripheral controller fails to bind.Sorry this is unclear, you are trying to skip
DM_USB_GADGETcode even thoughUCLASS_USB_GADGET_GENERICid used. does it make sense?Sorry for the delay. This was indeed a vacation time.
This patch does not skip
DM_USB_GADGET. What it does is declare theUCLASS_DRIVERfor USB peripheral devices even ifDM_USB_GADGETis not set.
Quoted 9 lines
DM_USB_GADGETis a new option and not (yet) widely used and some drivers have their own version of the DM support for gadget drivers (ie they implement their own version ofusb_gadget_initialize(),usb_gadget_release()andusb_gadget_handle_interrupts()). However all those drivers use theUCLASS_USB_GADGET_GENERICuclass ID and thus theUCLASS_DRIVERforUCLASS_USB_GADGET_GENERICmust be declared. In the past they usedUCLASS_USB_DEV_GENERIC, but this option is intended for the host side.
Thanks for a detailed explanation. Would you prepare v2 soon?
Quoted 7 lines
JJ
Quoted 4 lines
Any response on this?
We need the fix asap since the release is about a week.
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190102/46bc6c88/attachment.sig>
PATCH 1/1 dm: usb: gadget: Fix boot breakage on sunxi platforms
Quoted 42 lines · Lukasz Majewski
Quoted 30 lines · On Wed, 2 Jan 2019 11:38:47 +0100 Jean-Jacques Hiblot <[email protected]> wrote:
Quoted 5 lines · Jagan Teki
Quoted 3 lines · Jagan Teki
On Fri, Dec 21, 2018 at 2:20 PM Jean-Jacques Hiblot <[email protected]> wrote: Better to have proper commit head that tells the real issue.
I found it hard to come up with a short description of the real issue.
At least this title makes it clear that it is a regression fix, not a new feature.
The details of the failures are in the commit log (or so I thought)
Quoted 11 lines
Quoted 11 lines
Quoted 8 lines
Fixes commit 013116243950 ("dm: usb: create a new UCLASS ID for USB gadget devices")
The
UCLASS_DRIVERfor idUCLASS_USB_GADGET_GENERICneeds to be declared even for platforms that do not enableDM_USB_GADGET. Otherwise the driver for their usb peripheral controller fails to bind.Sorry this is unclear, you are trying to skip
DM_USB_GADGETcode even thoughUCLASS_USB_GADGET_GENERICid used. does it make sense?Sorry for the delay. This was indeed a vacation time.
This patch does not skip
DM_USB_GADGET. What it does is declare theUCLASS_DRIVERfor USB peripheral devices even ifDM_USB_GADGETis not set.Quoted 9 lines
DM_USB_GADGETis a new option and not (yet) widely used and some drivers have their own version of the DM support for gadget drivers (ie they implement their own version ofusb_gadget_initialize(),usb_gadget_release()andusb_gadget_handle_interrupts()). However all those drivers use theUCLASS_USB_GADGET_GENERICuclass ID and thus theUCLASS_DRIVERforUCLASS_USB_GADGET_GENERICmust be declared. In the past they usedUCLASS_USB_DEV_GENERIC, but this option is intended for the host side.
Quoted 1 line
Thanks for a detailed explanation. Would you prepare v2 soon?
Honestly I don't know what i would change in a v2.
Quoted 19 lines
Quoted 7 lines
JJ
Quoted 4 lines
Any response on this?
We need the fix asap since the release is about a week.
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
PATCH 1/1 dm: usb: gadget: Fix boot breakage on sunxi platforms
In reply to Jean-Jacques HiblotQuoted 29 lines · Jean-Jacques Hiblot
Quoted 3 lines · Jagan Teki
Quoted 2 lines · Jagan Teki
On Fri, Dec 21, 2018 at 2:20 PM Jean-Jacques Hiblot <[email protected]> wrote:
Better to have proper commit head that tells the real issue.I found it hard to come up with a short description of the real issue.
At least this title makes it clear that it is a regression fix, not a new feature.
The details of the failures are in the commit log (or so I thought)
Quoted 9 lines
Quoted 9 lines
Quoted 7 lines
Fixes commit 013116243950 ("dm: usb: create a new UCLASS ID for USB gadget devices")
The
UCLASS_DRIVERfor idUCLASS_USB_GADGET_GENERICneeds to be declared even for platforms that do not enableDM_USB_GADGET. Otherwise the driver for their usb peripheral controller fails to bind.Sorry this is unclear, you are trying to skip
DM_USB_GADGETcode even thoughUCLASS_USB_GADGET_GENERICid used. does it make sense?Sorry for the delay. This was indeed a vacation time.
This patch does not skip
DM_USB_GADGET. What it does is declare theUCLASS_DRIVERfor USB peripheral devices even ifDM_USB_GADGETis not set.
Quoted 8 lines
DM_USB_GADGETis a new option and not (yet) widely used and some drivers have their own version of the DM support for gadget drivers (ie they implement their own version ofusb_gadget_initialize(),usb_gadget_release()andusb_gadget_handle_interrupts()). However all those drivers use theUCLASS_USB_GADGET_GENERICuclass ID and thus theUCLASS_DRIVERforUCLASS_USB_GADGET_GENERICmust be declared. In the past they usedUCLASS_USB_DEV_GENERIC, but this option is intended for the host side.
Marek, any comments?
PATCH 1/1 dm: usb: gadget: Fix boot breakage on sunxi platforms
Hi Jagan,
Quoted 46 lines
Quoted 35 lines · Jean-Jacques Hiblot
Quoted 5 lines · Jagan Teki
Quoted 3 lines · Jagan Teki
On Fri, Dec 21, 2018 at 2:20 PM Jean-Jacques Hiblot <[email protected]> wrote: Better to have proper commit head that tells the real issue.
I found it hard to come up with a short description of the real issue.
At least this title makes it clear that it is a regression fix, not a new feature.
The details of the failures are in the commit log (or so I thought)
Quoted 11 lines
Quoted 11 lines
Quoted 8 lines
Fixes commit 013116243950 ("dm: usb: create a new UCLASS ID for USB gadget devices")
The
UCLASS_DRIVERfor idUCLASS_USB_GADGET_GENERICneeds to be declared even for platforms that do not enableDM_USB_GADGET. Otherwise the driver for their usb peripheral controller fails to bind.Sorry this is unclear, you are trying to skip
DM_USB_GADGETcode even thoughUCLASS_USB_GADGET_GENERICid used. does it make sense?Sorry for the delay. This was indeed a vacation time.
This patch does not skip
DM_USB_GADGET. What it does is declare theUCLASS_DRIVERfor USB peripheral devices even ifDM_USB_GADGETis not set.Quoted 8 lines
DM_USB_GADGETis a new option and not (yet) widely used and some drivers have their own version of the DM support for gadget drivers (ie they implement their own version ofusb_gadget_initialize(),usb_gadget_release()andusb_gadget_handle_interrupts()). However all those drivers use theUCLASS_USB_GADGET_GENERICuclass ID and thus theUCLASS_DRIVERforUCLASS_USB_GADGET_GENERICmust be declared. In the past they usedUCLASS_USB_DEV_GENERIC, but this option is intended for the host side.
Quoted 3 lines
Acked-by Jagan Teki <[email protected]>Marek, any comments?
Yes, lets wait for Marek's comment and I will prepare PR (to Marek), which also includes some other fixes.
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190103/3bf6af50/attachment.sig>
PATCH 1/1 dm: usb: gadget: Fix boot breakage on sunxi platforms
Quoted 48 lines · Lukasz Majewski
Hi Jagan,
Quoted 46 lines
Quoted 43 lines · Jean-Jacques Hiblot
Quoted 5 lines · Jagan Teki
Quoted 3 lines · Jagan Teki
On Fri, Dec 21, 2018 at 2:20 PM Jean-Jacques Hiblot <[email protected]> wrote: Better to have proper commit head that tells the real issue.
I found it hard to come up with a short description of the real issue.
At least this title makes it clear that it is a regression fix, not a new feature.
The details of the failures are in the commit log (or so I thought)
Quoted 11 lines
Quoted 11 lines
Quoted 8 lines
Fixes commit 013116243950 ("dm: usb: create a new UCLASS ID for USB gadget devices")
The
UCLASS_DRIVERfor idUCLASS_USB_GADGET_GENERICneeds to be declared even for platforms that do not enableDM_USB_GADGET. Otherwise the driver for their usb peripheral controller fails to bind.Sorry this is unclear, you are trying to skip
DM_USB_GADGETcode even thoughUCLASS_USB_GADGET_GENERICid used. does it make sense?Sorry for the delay. This was indeed a vacation time.
This patch does not skip
DM_USB_GADGET. What it does is declare theUCLASS_DRIVERfor USB peripheral devices even ifDM_USB_GADGETis not set.
DM_USB_GADGETis a new option and not (yet) widely used and some drivers have their own version of the DM support for gadget drivers (ie they implement their own version ofusb_gadget_initialize(),usb_gadget_release()andusb_gadget_handle_interrupts()). However all those drivers use theUCLASS_USB_GADGET_GENERICuclass ID and thus theUCLASS_DRIVERforUCLASS_USB_GADGET_GENERICmust be declared. In the past they usedUCLASS_USB_DEV_GENERIC, but this option is intended for the host side.
Quoted 6 lines
Quoted 3 lines
Acked-by Jagan Teki <[email protected]>Marek, any comments?
Yes, lets wait for Marek's comment and I will prepare PR (to Marek), which also includes some other fixes.
Comment on what ? What do you need from me here ?
This is gadget code, which is not something I monitor closely.
Signature · 2 lines
Best regards, Marek Vasut
PATCH 1/1 dm: usb: gadget: Fix boot breakage on sunxi platforms
In reply to Lukasz MajewskiQuoted 49 lines · Lukasz Majewski
Hi Jagan,
Quoted 46 lines
Quoted 43 lines · Jean-Jacques Hiblot
Quoted 5 lines · Jagan Teki
Quoted 3 lines · Jagan Teki
On Fri, Dec 21, 2018 at 2:20 PM Jean-Jacques Hiblot <[email protected]> wrote: Better to have proper commit head that tells the real issue.
I found it hard to come up with a short description of the real issue.
At least this title makes it clear that it is a regression fix, not a new feature.
The details of the failures are in the commit log (or so I thought)
Quoted 11 lines
Quoted 11 lines
Quoted 8 lines
Fixes commit 013116243950 ("dm: usb: create a new UCLASS ID for USB gadget devices")
The
UCLASS_DRIVERfor idUCLASS_USB_GADGET_GENERICneeds to be declared even for platforms that do not enableDM_USB_GADGET. Otherwise the driver for their usb peripheral controller fails to bind.Sorry this is unclear, you are trying to skip
DM_USB_GADGETcode even thoughUCLASS_USB_GADGET_GENERICid used. does it make sense?Sorry for the delay. This was indeed a vacation time.
This patch does not skip
DM_USB_GADGET. What it does is declare theUCLASS_DRIVERfor USB peripheral devices even ifDM_USB_GADGETis not set.
DM_USB_GADGETis a new option and not (yet) widely used and some drivers have their own version of the DM support for gadget drivers (ie they implement their own version ofusb_gadget_initialize(),usb_gadget_release()andusb_gadget_handle_interrupts()). However all those drivers use theUCLASS_USB_GADGET_GENERICuclass ID and thus theUCLASS_DRIVERforUCLASS_USB_GADGET_GENERICmust be declared. In the past they usedUCLASS_USB_DEV_GENERIC, but this option is intended for the host side.
Quoted 6 lines
Quoted 3 lines
Acked-by Jagan Teki <[email protected]>Marek, any comments?
Yes, lets wait for Marek's comment and I will prepare PR (to Marek), which also includes some other fixes.
Please don't miss this, sunxi need this fix.
PATCH 1/1 dm: usb: gadget: Fix boot breakage on sunxi platforms
Quoted 50 lines · Jagan Teki
Quoted 49 lines · Lukasz Majewski
Hi Jagan,
Quoted 46 lines
Quoted 43 lines · Jean-Jacques Hiblot
Quoted 5 lines · Jagan Teki
Quoted 3 lines · Jagan Teki
On Fri, Dec 21, 2018 at 2:20 PM Jean-Jacques Hiblot <[email protected]> wrote: Better to have proper commit head that tells the real issue.
I found it hard to come up with a short description of the real issue.
At least this title makes it clear that it is a regression fix, not a new feature.
The details of the failures are in the commit log (or so I thought)
Quoted 11 lines
Quoted 11 lines
Quoted 8 lines
Fixes commit 013116243950 ("dm: usb: create a new UCLASS ID for USB gadget devices")
The
UCLASS_DRIVERfor idUCLASS_USB_GADGET_GENERICneeds to be declared even for platforms that do not enableDM_USB_GADGET. Otherwise the driver for their usb peripheral controller fails to bind.Sorry this is unclear, you are trying to skip
DM_USB_GADGETcode even thoughUCLASS_USB_GADGET_GENERICid used. does it make sense?Sorry for the delay. This was indeed a vacation time.
This patch does not skip
DM_USB_GADGET. What it does is declare theUCLASS_DRIVERfor USB peripheral devices even ifDM_USB_GADGETis not set.
DM_USB_GADGETis a new option and not (yet) widely used and some drivers have their own version of the DM support for gadget drivers (ie they implement their own version ofusb_gadget_initialize(),usb_gadget_release()andusb_gadget_handle_interrupts()). However all those drivers use theUCLASS_USB_GADGET_GENERICuclass ID and thus theUCLASS_DRIVERforUCLASS_USB_GADGET_GENERICmust be declared. In the past they usedUCLASS_USB_DEV_GENERIC, but this option is intended for the host side.
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
Acked-by Jagan Teki <[email protected]>Marek, any comments?
Yes, lets wait for Marek's comment and I will prepare PR (to Marek), which also includes some other fixes.
Please don't miss this, sunxi need this fix.
Absolutely, I have nothing else to do but to monitor this one single patch. Thanks for the pressure, it really helps.
Signature · 2 lines
Best regards, Marek Vasut
PATCH 1/1 dm: usb: gadget: Fix boot breakage on sunxi platforms
In reply to Jagan TekiQuoted 51 lines · On Fri, 4 Jan 2019 01:23:17 +0530 Jagan Teki <[email protected]> wrote:
Quoted 50 lines · Lukasz Majewski
Hi Jagan,
Quoted 47 lines
Quoted 44 lines · Jean-Jacques Hiblot
Quoted 5 lines · Jagan Teki
Quoted 3 lines · Jagan Teki
On Fri, Dec 21, 2018 at 2:20 PM Jean-Jacques Hiblot <[email protected]> wrote: Better to have proper commit head that tells the real issue.
I found it hard to come up with a short description of the real issue.
At least this title makes it clear that it is a regression fix, not a new feature.
The details of the failures are in the commit log (or so I thought)
Quoted 11 lines
Quoted 11 lines
Quoted 8 lines
Fixes commit 013116243950 ("dm: usb: create a new UCLASS ID for USB gadget devices")
The
UCLASS_DRIVERfor idUCLASS_USB_GADGET_GENERICneeds to be declared even for platforms that do not enableDM_USB_GADGET. Otherwise the driver for their usb peripheral controller fails to bind.Sorry this is unclear, you are trying to skip
DM_USB_GADGETcode even thoughUCLASS_USB_GADGET_GENERICid used. does it make sense?Sorry for the delay. This was indeed a vacation time.
This patch does not skip
DM_USB_GADGET. What it does is declare theUCLASS_DRIVERfor USB peripheral devices even ifDM_USB_GADGETis not set.
DM_USB_GADGETis a new option and not (yet) widely used and some drivers have their own version of the DM support for gadget drivers (ie they implement their own version ofusb_gadget_initialize(),usb_gadget_release()andusb_gadget_handle_interrupts()). However all those drivers use theUCLASS_USB_GADGET_GENERICuclass ID and thus theUCLASS_DRIVERforUCLASS_USB_GADGET_GENERICmust be declared. In the past they usedUCLASS_USB_DEV_GENERIC, but this option is intended for the host side.
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
Acked-by Jagan Teki <[email protected]>Marek, any comments?
Yes, lets wait for Marek's comment and I will prepare PR (to Marek), which also includes some other fixes.
Please don't miss this, sunxi need this fix.
I'm now running build tests on this and Sam's patches. I will prepare PR and send it to Marek or Tom (if Marek is overloaded).
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190103/4b65b732/attachment.sig>
PATCH 1/1 dm: usb: gadget: Fix boot breakage on sunxi platforms
Quoted 58 lines · Lukasz Majewski
Quoted 55 lines · On Fri, 4 Jan 2019 01:23:17 +0530 Jagan Teki <[email protected]> wrote:
Quoted 54 lines · Lukasz Majewski
Hi Jagan,
Quoted 50 lines
Quoted 35 lines · Jean-Jacques Hiblot
Quoted 5 lines · Jagan Teki
Quoted 3 lines · Jagan Teki
On Fri, Dec 21, 2018 at 2:20 PM Jean-Jacques Hiblot <[email protected]> wrote: Better to have proper commit head that tells the real issue.
I found it hard to come up with a short description of the real issue.
At least this title makes it clear that it is a regression fix, not a new feature.
The details of the failures are in the commit log (or so I thought)
Quoted 11 lines
Quoted 11 lines
Quoted 8 lines
Fixes commit 013116243950 ("dm: usb: create a new UCLASS ID for USB gadget devices")
The
UCLASS_DRIVERfor idUCLASS_USB_GADGET_GENERICneeds to be declared even for platforms that do not enableDM_USB_GADGET. Otherwise the driver for their usb peripheral controller fails to bind.Sorry this is unclear, you are trying to skip
DM_USB_GADGETcode even thoughUCLASS_USB_GADGET_GENERICid used. does it make sense?Sorry for the delay. This was indeed a vacation time.
This patch does not skip
DM_USB_GADGET. What it does is declare theUCLASS_DRIVERfor USB peripheral devices even ifDM_USB_GADGETis not set.Quoted 9 lines
DM_USB_GADGETis a new option and not (yet) widely used and some drivers have their own version of the DM support for gadget drivers (ie they implement their own version ofusb_gadget_initialize(),usb_gadget_release()andusb_gadget_handle_interrupts()). However all those drivers use theUCLASS_USB_GADGET_GENERICuclass ID and thus theUCLASS_DRIVERforUCLASS_USB_GADGET_GENERICmust be declared. In the past they usedUCLASS_USB_DEV_GENERIC, but this option is intended for the host side.Acked-by Jagan Teki <[email protected]>Marek, any comments?
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
Yes, lets wait for Marek's comment and I will prepare PR (to Marek), which also includes some other fixes.
Please don't miss this, sunxi need this fix.
I'm now running build tests on this and Sam's patches. I will prepare PR and send it to Marek or Tom (if Marek is overloaded).
It is still unclear what you wanted me to comment on.
And you know where to send the PR - u-boot-usb.
Signature · 2 lines
Best regards, Marek Vasut